Skip to content

[release-4.20] NO-JIRA: rhaos-pkgs-match-openshift: exclude known package mismatches#1920

Merged
openshift-merge-bot[bot] merged 2 commits into
openshift:release-4.20from
marmijo:release-4.20-rhaos-pkgs-backport
May 12, 2026
Merged

[release-4.20] NO-JIRA: rhaos-pkgs-match-openshift: exclude known package mismatches#1920
openshift-merge-bot[bot] merged 2 commits into
openshift:release-4.20from
marmijo:release-4.20-rhaos-pkgs-backport

Conversation

@marmijo
Copy link
Copy Markdown
Contributor

@marmijo marmijo commented Mar 31, 2026

Introduce RHAOS_PACKAGE_EXCEPTIONS and build a regex from it to filter out packages that are known to not match the target version of openshift. Use a list-based structure so additional packages can be excluded in the future by appending to the exception array.

Exclude the toolbox and conmon rhaos packages, which are not expected to match.

Also remove the rhaos-pkgs-match-openshift test from the denylist.

See: #1847

This backports:

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 31, 2026
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Mar 31, 2026

@marmijo: This pull request explicitly references no jira issue.

Details

In response to this:

Introduce RHAOS_PACKAGE_EXCEPTIONS and build a regex from it to filter out packages that are known to not match the target version of openshift. Use a list-based structure so additional packages can be excluded in the future by appending to the exception array.

Exclude the toolbox and conmon rhaos packages, which are not expected to match.

Also remove the rhaos-pkgs-match-openshift test from the denylist.

See: #1847

This backports:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci Bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 31, 2026
@openshift-ci openshift-ci Bot requested review from jlebon and jmarrero March 31, 2026 22:16
@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 31, 2026
@marmijo marmijo force-pushed the release-4.20-rhaos-pkgs-backport branch 3 times, most recently from 95d046e to bef29b8 Compare March 31, 2026 22:24
marmijo and others added 2 commits March 31, 2026 16:33
@marmijo
rhaos-pkgs-match-openshift: exclude known package mismatches
62c7456 
Introduce `RHAOS_PACKAGE_EXCEPTIONS` and build a regex from it to filter
out packages that are known to not match the target version of
openshift. Use a list-based structure so additional packages can be
excluded in the future by appending to the exception array.

Exclude the toolbox rhaos package, which is known to not match the
target version of openshift.

Also remove the rhaos-pkgs-match-openshift test from the denylist.

See: openshift#1847

This backports openshift@ef8a3bb
and part of openshift@3f11128
@dustymabe @marmijo
tests: add openshift tag
29092e3 
The build-node-image job only tests tags with the openshift tag
and any tests still in this repo should be running so let's add
the openshift tag to them.
@marmijo marmijo force-pushed the release-4.20-rhaos-pkgs-backport branch from bef29b8 to 29092e3 Compare March 31, 2026 22:34
@openshift-ci openshift-ci Bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 31, 2026
Rolv-Apneseth
Rolv-Apneseth approved these changes Apr 13, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@Rolv-Apneseth Rolv-Apneseth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Apr 13, 2026
@marmijo
Copy link
Copy Markdown
Contributor Author

marmijo commented Apr 13, 2026

/label backport-risk-assessed
/label jira/valid-bug

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 13, 2026

@marmijo: The label(s) backport-risk-assessed cannot be applied or removed, because you are not in one of the allowed teams and are not an allowed user. Must be a member of one of these teams: openshift-patch-managers, openshift-release-oversight, openshift-staff-engineers, openshift-sustaining-engineers

Details

In response to this:

/label backport-risk-assessed
/label jira/valid-bug

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 13, 2026

@marmijo: The label(s) jira/valid-bug cannot be applied or removed, because you are not in one of the allowed teams and are not an allowed user. Must be a member of one of these teams: openshift-patch-managers, openshift-staff-engineers, openshift-release-oversight, openshift-sustaining-engineers

Details

In response to this:

/label backport-risk-assessed
/label jira/valid-bug

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@aaradhak
Copy link
Copy Markdown
Contributor

aaradhak commented May 11, 2026

@sdodson Do you think you ll be able to add these labels below for this PR to move forward?

/label backport-risk-assessed
/label jira/valid-bug

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 11, 2026

@aaradhak: The label(s) backport-risk-assessed cannot be applied or removed, because you are not in one of the allowed teams and are not an allowed user. Must be a member of one of these teams: openshift-patch-managers, openshift-release-oversight, openshift-staff-engineers, openshift-sustaining-engineers

Details

In response to this:

@sdodson Do you think you ll be able to add these labels below for this PR to move forward?

/label backport-risk-assessed
/label jira/valid-bug

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 11, 2026

@aaradhak: The label(s) jira/valid-bug cannot be applied or removed, because you are not in one of the allowed teams and are not an allowed user. Must be a member of one of these teams: openshift-patch-managers, openshift-staff-engineers, openshift-release-oversight, openshift-sustaining-engineers

Details

In response to this:

@sdodson Do you think you ll be able to add these labels below for this PR to move forward?

/label backport-risk-assessed
/label jira/valid-bug

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

travier
travier approved these changes May 12, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@travier travier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@travier travier added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label May 12, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 12, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: marmijo, Rolv-Apneseth, travier

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@travier travier added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label May 12, 2026
@travier
Copy link
Copy Markdown
Member

travier commented May 12, 2026

/verified by CI

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label May 12, 2026
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented May 12, 2026

@travier: This PR has been marked as verified by CI.

Details

In response to this:

/verified by CI

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-bot openshift-merge-bot Bot merged commit ee943c3 into openshift:release-4.20 May 12, 2026
2 checks passed
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 12, 2026

@marmijo: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@travier travier travier approved these changes

@jlebon jlebon Awaiting requested review from jlebon

@jmarrero jmarrero Awaiting requested review from jmarrero

+1 more reviewer

@Rolv-Apneseth Rolv-Apneseth Rolv-Apneseth approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@travier travier

@Rolv-Apneseth Rolv-Apneseth

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@marmijo @openshift-ci-robot @aaradhak @travier @Rolv-Apneseth @dustymabe