Skip to content

"NO-ISSUE: [release-4.22] Migrate OCP-38271 from openshift-tests-private"#31143

Open
openshift-cherrypick-robot wants to merge 1 commit intoopenshift:release-4.22from
openshift-cherrypick-robot:cherry-pick-30960-to-release-4.22
Open

"NO-ISSUE: [release-4.22] Migrate OCP-38271 from openshift-tests-private"#31143
openshift-cherrypick-robot wants to merge 1 commit intoopenshift:release-4.22from
openshift-cherrypick-robot:cherry-pick-30960-to-release-4.22

Conversation

@openshift-cherrypick-robot
Copy link
Copy Markdown

This is an automated cherry-pick of #30960

/assign BhargaviGudi

Add test to verify init containers do not restart when removed from node.

- Add pod-initContainer.yaml template

- Add helper functions in node_utils.go

- Add OCP-38271 test in node_e2e/node.go

Author: minmli@redhat.com (original)

Migrated-by: bgudi@redhat.com

Move OCP-38271 test to separate Describe block

Refactor OCP-38271 to use standard origin patterns instead of compat_otp

Fix race condition and Add retry logic and explicit failure for MicroShift cluster check

Resolved typo issue

Resolved gofmt issue

Missing leading slash in shell command path

Use direct crictl args instead of bash -c

Fix shell command

Container image - Changed from busybox to hello-openshift@sha256:4200f438
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented May 7, 2026

@openshift-cherrypick-robot: Ignoring requests to cherry-pick non-bug issues: OCPNODE-4381

Details

In response to this:

This is an automated cherry-pick of #30960

/assign BhargaviGudi

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 7, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 6efcdbac-3c9c-46ec-9805-536a2f08c663

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 7, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: openshift-cherrypick-robot
Once this PR has been reviewed and has the lgtm label, please assign sairameshv for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot requested review from cpmeadors and sairameshv May 7, 2026 12:07
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 7, 2026

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@BhargaviGudi
Copy link
Copy Markdown
Contributor

/retitle "NO-ISSUE: [release-4.22] Migrate OCP-38271 from openshift-tests-private"

@openshift-ci openshift-ci Bot changed the title [release-4.22] OCPNODE-4381: Migrate OCP-38271 from openshift-tests-private "NO-ISSUE: [release-4.22] Migrate OCP-38271 from openshift-tests-private" May 7, 2026
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 7, 2026
@openshift-ci-robot
Copy link
Copy Markdown

@openshift-cherrypick-robot: This pull request explicitly references no jira issue.

Details

In response to this:

This is an automated cherry-pick of #30960

/assign BhargaviGudi

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

})

//author: bgudi@redhat.com
g.It("[OTP] Init containers should not restart when the exited init container is removed from node [OCP-38271]", func() {
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All testing coming in from otp need to be labelled as informing with "ote.Informing()". I missed this the PR for main. It should be informing as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants