NO-JIRA: Tolerate events during the vSphere CSI driver removal test

[jsafrane]

Test "vSphere CSI Driver Operator Removal" un-installs the CSI driver + installs it back. I.e. a DaemonSet and two Deployment are deleted + re-created with many events like "Created pod: vmware-vsphere-csi-driver-node-tkl25"

See openshift/vmware-vsphere-csi-driver-operator#337 that adds the test + a rehearsal result

Summary by CodeRabbit

• Tests
  • Broadened detection of vSphere CSI-related E2E test intervals to include additional configuration and operator-removal scenarios, improving recognition of relevant test overlaps.
  • Added interval-overlap detection and a storage-specific exception path to better handle upgrade/test timing edge cases in monitoring tests.

[openshift-merge-bot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: automatic mode

[openshift-ci-robot]

@jsafrane: This pull request explicitly references no jira issue.

Details

In response to this:

Test "vSphere CSI Driver Operator Removal" un-installs the CSI driver + installs it back. I.e. a DaemonSet and two Deployment with many events like "Created pod: vmware-vsphere-csi-driver-node-tkl25"

See openshift/vmware-vsphere-csi-driver-operator#337 that adds the test + a rehearsal result

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

Caution

Review failed

Failed to post review comments

Walkthrough

Broadens vSphere-related E2E test detection by adding an additional test-name substring to the interval matcher and introducing a helper that checks whether an upgrade-event interval overlaps any E2E test matching a given substring; the helper is used to refine a storage-specific exception path.

Changes

vSphere E2E Interval Detection and Overlap Handling

Layer / File(s)	Summary
Pattern Matching pkg/monitortestlibrary/pathologicaleventlibrary/duplicated_event_patterns.go	newVsphereConfigurationTestsRollOutTooOftenEventMatcher now treats intervals with Source == monitorapi.SourceE2ETest as vSphere configuration tests when their LocatorE2ETestKey contains either "snapshot options in clusterCSIDriver" or "vSphere CSI Driver Operator Removal" (previously only the first substring was matched).
Overlap Helper pkg/monitortests/clusterversionoperator/legacycvomonitortests/operators.go	Adds intervalOverlapsE2ETest(e2eIntervals, eventInterval, testNameSubstring) which checks whether a given event interval overlaps any E2E test interval whose name contains testNameSubstring (ignoring Info-level entries).
Integration / Exception Wiring pkg/monitortests/clusterversionoperator/legacycvomonitortests/operators.go	Initializes e2eEventIntervals via E2ETestEventIntervals, renames callback parameter to eventInterval, and uses intervalOverlapsE2ETest in the storage operator exception branch to detect overlap with the "vSphere CSI Driver Operator Removal" test and return a specific message.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 11 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (11 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the main change: adding tolerance for events during the vSphere CSI driver removal test, which aligns with the core modifications across both files.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	Modified files are utility code, not Ginkgo test declarations. No Ginkgo test syntax found. Test name references are static strings with no dynamic elements.
Test Structure And Quality	✅ Passed	Custom check requires reviewing Ginkgo test code quality. PR only modifies library/utility code, not Ginkgo test files. Check is not applicable.
Microshift Test Compatibility	✅ Passed	This PR does not add new Ginkgo e2e tests. The modified files are test support libraries. The custom check applies only to Ginkgo test definitions, making it not applicable.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	PR modifies only test monitoring infrastructure, not e2e test definitions. No new Ginkgo tests (It, Describe, Context, When) added. Check not applicable.
Topology-Aware Scheduling Compatibility	✅ Passed	PR contains only test and monitoring infrastructure changes (event matchers, monitor tests). No deployment manifests, operator controllers, or scheduling constraints are introduced or modified.
Ote Binary Stdout Contract	✅ Passed	No process-level stdout writes found. These are library functions without main(), init(), TestMain(), or suite setup functions that could emit unredirected output.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	This PR does not add any new Ginkgo e2e tests. Changes are to monitoring/test analysis helper functions only. The check is not applicable as it applies only to new e2e test definitions.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jsafrane
Once this PR has been reviewed and has the lgtm label, please assign mkowalski for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@jsafrane: This PR was included in a payload test run from openshift/vmware-vsphere-csi-driver-operator#337
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

• periodic-ci-openshift-release-main-nightly-5.0-e2e-vsphere-ovn-serial

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/feb5b540-4879-11f1-9b84-0bd24eaf093f-0

[openshift-merge-bot]

Scheduling required tests:
/test e2e-aws-csi
/test e2e-aws-ovn-fips
/test e2e-aws-ovn-microshift
/test e2e-aws-ovn-microshift-serial
/test e2e-aws-ovn-serial-1of2
/test e2e-aws-ovn-serial-2of2
/test e2e-gcp-csi
/test e2e-gcp-ovn
/test e2e-gcp-ovn-upgrade
/test e2e-metal-ipi-ovn-ipv6
/test e2e-vsphere-ovn
/test e2e-vsphere-ovn-upi

[openshift-ci]

@jsafrane: This PR was included in a payload test run from openshift/vmware-vsphere-csi-driver-operator#337
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

• periodic-ci-openshift-release-main-nightly-5.0-e2e-vsphere-ovn-serial

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/37759370-4936-11f1-9e56-9cae5cc88990-0

[openshift-ci]

@jsafrane: This PR was included in a payload test run from openshift/vmware-vsphere-csi-driver-operator#337
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

• periodic-ci-openshift-release-main-nightly-5.0-e2e-vsphere-ovn-serial

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/96558910-4952-11f1-97b0-fb3ae878c0e7-0

[openshift-ci]

@jsafrane: This PR was included in a payload test run from openshift/vmware-vsphere-csi-driver-operator#337
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

• periodic-ci-openshift-release-main-nightly-5.0-e2e-vsphere-ovn-serial

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/d510caf0-4968-11f1-8c7c-279887907322-0

[openshift-merge-bot]

Scheduling required tests:
/test e2e-aws-csi
/test e2e-aws-ovn-fips
/test e2e-aws-ovn-microshift
/test e2e-aws-ovn-microshift-serial
/test e2e-aws-ovn-serial-1of2
/test e2e-aws-ovn-serial-2of2
/test e2e-gcp-csi
/test e2e-gcp-ovn
/test e2e-gcp-ovn-upgrade
/test e2e-metal-ipi-ovn-ipv6
/test e2e-vsphere-ovn
/test e2e-vsphere-ovn-upi

[openshift-ci]

@jsafrane: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-gcp-ovn	d1d7137	link	true	/test e2e-gcp-ovn
ci/prow/e2e-aws-ovn-microshift	d1d7137	link	true	/test e2e-aws-ovn-microshift
ci/prow/e2e-aws-csi	d1d7137	link	true	/test e2e-aws-csi
ci/prow/e2e-gcp-ovn-upgrade	d1d7137	link	true	/test e2e-gcp-ovn-upgrade

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.