TRT-2573: Show non-blocking failure message in JUnit failure output

[stbenjam]

Summary

• Move the "NON-BLOCKING FAILURE" message into the JUnit FailureOutput.Output field so it's visible in the Spyglass JUnit lens in Prow
• Previously, the message was prepended to testOutputBytes which gets truncated to the last ~100 lines in the failure output, making it invisible for tests with longer output
• The existing informing test in test/extended/extension/extension.go can be used to verify this works in CI

Fixes TRT-2573

Example https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/30921/pull-ci-openshift-origin-main-e2e-aws-ovn-fips/2036093813532921856

Test plan

• Verify the [Suite:openshift/ote] suite runs in CI and the failing informing test shows "NON-BLOCKING FAILURE" in the JUnit lens

🤖 Generated with Claude Code

[openshift-ci-robot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: automatic mode

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 9b1c7a72-64f9-4546-b03d-159c8aa0f815

📥 Commits

Reviewing files that changed from the base of the PR and between 785f8b0 and cd8b853.

📒 Files selected for processing (2)

• pkg/test/ginkgo/cmd_runsuite.go
• pkg/test/ginkgo/junit.go

💤 Files with no reviewable changes (1)

• pkg/test/ginkgo/cmd_runsuite.go

---

Walkthrough

Non-blocking failure handling logic was refactored across two files: removal of output rewriting in cmd_runsuite.go and addition of conditional failure message wrapping in junit.go based on extensionTestResult lifecycle status. The control flow for classifying and printing failures remains unchanged.

Changes

Cohort / File(s)	Summary
Non-blocking failure handling pkg/test/ginkgo/cmd_runsuite.go	Removed logic that prepended *** NON-BLOCKING FAILURE... explanatory message to test output bytes. Control flow for classifying and reporting failures is preserved.
Failure message rendering pkg/test/ginkgo/junit.go	Added extensiontests import and introduced conditional failure message wrapping. For failed tests with non-nil extensionTestResult having Lifecycle equal to extensiontests.LifecycleInforming, failure messages are now wrapped with *** NON-BLOCKING FAILURE... prefix in JUnit output.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~22 minutes

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 golangci-lint (2.11.3)

Error: can't load config: unsupported version of the configuration: "" See https://golangci-lint.run/docs/product/migration-guide for migration instructions
The command is terminated due to an error: can't load config: unsupported version of the configuration: "" See https://golangci-lint.run/docs/product/migration-guide for migration instructions

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[stbenjam]

/test e2e-aws-ovn-fips

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: stbenjam

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [stbenjam]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

@stbenjam: This pull request references TRT-2573 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Summary

• Move the "NON-BLOCKING FAILURE" message into the JUnit FailureOutput.Output field so it's visible in the Spyglass JUnit lens in Prow
• Previously, the message was prepended to testOutputBytes which gets truncated to the last ~100 lines in the failure output, making it invisible for tests with longer output
• The existing informing test in test/extended/extension/extension.go can be used to verify this works in CI

Fixes TRT-2573

Test plan

• Verify the [Suite:openshift/ote] suite runs in CI and the failing informing test shows "NON-BLOCKING FAILURE" in the JUnit lens

🤖 Generated with Claude Code

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@stbenjam: This pull request references TRT-2573 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Summary

• Move the "NON-BLOCKING FAILURE" message into the JUnit FailureOutput.Output field so it's visible in the Spyglass JUnit lens in Prow
• Previously, the message was prepended to testOutputBytes which gets truncated to the last ~100 lines in the failure output, making it invisible for tests with longer output
• The existing informing test in test/extended/extension/extension.go can be used to verify this works in CI

Fixes TRT-2573

Example https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/30921/pull-ci-openshift-origin-main-e2e-aws-ovn-fips/2036093813532921856

Test plan

• Verify the [Suite:openshift/ote] suite runs in CI and the failing informing test shows "NON-BLOCKING FAILURE" in the JUnit lens

🤖 Generated with Claude Code

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

Scheduling required tests:
/test e2e-aws-csi
/test e2e-aws-ovn-fips
/test e2e-aws-ovn-microshift
/test e2e-aws-ovn-microshift-serial
/test e2e-aws-ovn-serial-1of2
/test e2e-aws-ovn-serial-2of2
/test e2e-gcp-csi
/test e2e-gcp-ovn
/test e2e-gcp-ovn-upgrade
/test e2e-metal-ipi-ovn-ipv6
/test e2e-vsphere-ovn
/test e2e-vsphere-ovn-upi

[openshift-ci]

@stbenjam: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.