Skip to content

NO-JIRA: remove extra character#30920

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
dhensel-rh:ocpbugs-79350
Mar 24, 2026
Merged

NO-JIRA: remove extra character#30920
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
dhensel-rh:ocpbugs-79350

Conversation

@dhensel-rh
Copy link
Contributor

@dhensel-rh dhensel-rh commented Mar 23, 2026

/test/extended/two_node/tnf_recovery.go had an extra character in job should recover from network disruption with etcd member re-addition. This removes the extra character

@openshift-ci-robot
Copy link

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: automatic mode

@coderabbitai
Copy link

coderabbitai bot commented Mar 23, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: c28d9e12-994b-4b0e-acb4-344e2d795c07

📥 Commits

Reviewing files that changed from the base of the PR and between 0509de9 and 76da890.

📒 Files selected for processing (1)
  • test/extended/two_node/tnf_recovery.go

Walkthrough

A test registration label in a Ginkgo test was changed from FIt (focused test) to It (normal spec) in the network disruption recovery scenario. This allows the test to execute with other tests instead of running exclusively. No logic or assertions were modified.

Changes

Cohort / File(s) Summary
Test Registration
test/extended/two_node/tnf_recovery.go
Changed Ginkgo test registration from g.FIt(...) to g.It(...), enabling the network disruption recovery spec to run normally instead of being marked as focused/filtered.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 golangci-lint (2.11.3)

Error: can't load config: unsupported version of the configuration: "" See https://golangci-lint.run/docs/product/migration-guide for migration instructions
The command is terminated due to an error: can't load config: unsupported version of the configuration: "" See https://golangci-lint.run/docs/product/migration-guide for migration instructions


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@eggfoobar
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 23, 2026
@openshift-ci-robot
Copy link

Scheduling required tests:
/test e2e-aws-csi
/test e2e-aws-ovn-fips
/test e2e-aws-ovn-microshift
/test e2e-aws-ovn-microshift-serial
/test e2e-aws-ovn-serial-1of2
/test e2e-aws-ovn-serial-2of2
/test e2e-gcp-csi
/test e2e-gcp-ovn
/test e2e-gcp-ovn-upgrade
/test e2e-metal-ipi-ovn-ipv6
/test e2e-vsphere-ovn
/test e2e-vsphere-ovn-upi

@dhensel-rh
Copy link
Contributor Author

/payload-job periodic-ci-openshift-release-main-nightly-4.22-e2e-metal-ovn-two-node-fencing-techpreview

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 23, 2026

@dhensel-rh: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-main-nightly-4.22-e2e-metal-ovn-two-node-fencing-techpreview

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/da2f7150-26e3-11f1-9d89-4636371f089c-0

@stbenjam
Copy link
Member

/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 23, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dhensel-rh, eggfoobar, stbenjam

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@eggfoobar
Copy link
Contributor

@openshift-ci openshift-ci bot changed the title NO-JIRA remove extra character NO-JIRA: remove extra character Mar 24, 2026
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 24, 2026
@openshift-ci-robot
Copy link

@dhensel-rh: This pull request explicitly references no jira issue.

Details

In response to this:

/test/extended/two_node/tnf_recovery.go had an extra character in job should recover from network disruption with etcd member re-addition. This removes the extra character

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

@eggfoobar: This PR has been marked as verified by https://prow.ci.openshift.org/view/gs/test-platform-results/logs/openshift-origin-30920-nightly-4.22-e2e-metal-ovn-two-node-fencing-techpreview/2036151014792368128.

Details

In response to this:

/retitle NO-JIRA: remove extra character
/verified by https://prow.ci.openshift.org/view/gs/test-platform-results/logs/openshift-origin-30920-nightly-4.22-e2e-metal-ovn-two-node-fencing-techpreview/2036151014792368128

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Mar 24, 2026
@dhensel-rh
Copy link
Contributor Author

/pj-rehearse ack

@eggfoobar
Copy link
Contributor

/retest-required

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 24, 2026

@dhensel-rh: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 394edfe into openshift:main Mar 24, 2026
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants