OCPBUGS-78384: changed http to https for three places to reduce test false positives and false negatives

[prb112]

OCPBUGS-78384: changed http to https for three places to reduce test false positives and false negatives

Summary by CodeRabbit

• Bug Fixes
  • Upgraded external service endpoints and network connectivity tests to use HTTPS instead of HTTP, improving security and compliance with modern standards.

[openshift-ci-robot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: automatic mode

[openshift-ci-robot]

@prb112: This pull request references Jira Issue OCPBUGS-78384, which is invalid:

• expected the bug to target the "4.22.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

OCPBUGS-78384: changed http to https for three places to reduce test false positives and false negatives

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: f2e98d98-cb2a-4a83-9de9-656ec3fe18df

📥 Commits

Reviewing files that changed from the base of the PR and between 7fd854e and ac04c3a.

📒 Files selected for processing (3)

• pkg/monitortests/testframework/disruptionexternalservicemonitoring/monitortest.go
• test/extended/machine_config/helpers.go
• test/extended/networking/egress_firewall.go

---

Walkthrough

Three test files are updated to use HTTPS instead of HTTP for external service endpoint URLs. No logic, control flow, or error handling changes are made; only the protocol scheme is updated in single-line modifications.

Changes

Cohort / File(s)	Summary
Protocol scheme updates to HTTPS pkg/monitortests/testframework/disruptionexternalservicemonitoring/monitortest.go, test/extended/machine_config/helpers.go, test/extended/networking/egress_firewall.go	Updated externalServiceURL and curl command URLs from HTTP to HTTPS protocol. Changes affect only the URL scheme without modifying underlying logic, error handling, or test expectations.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Test Structure And Quality	⚠️ Warning	Egress firewall tests bundle multiple behaviors without proper setup/cleanup and lack meaningful assertion messages.	Refactor tests to single behaviors, move setup/cleanup to BeforeEach/AfterEach, delete egressfirewall after each test, add descriptive messages to assertions.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and specifically describes the main change: updating HTTP to HTTPS across three files to reduce test false positives and negatives, which aligns with all three modified files in the changeset.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Stable And Deterministic Test Names	✅ Passed	Pull request changes HTTP URLs to HTTPS in constants and test bodies. Test names are static and descriptive without dynamic identifiers.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

📝 Coding Plan

• Generate coding plan for human review comments

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 golangci-lint (2.5.0)

Error: can't load config: unsupported version of the configuration: "" See https://golangci-lint.run/docs/product/migration-guide for migration instructions
The command is terminated due to an error: can't load config: unsupported version of the configuration: "" See https://golangci-lint.run/docs/product/migration-guide for migration instructions

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

Tip

You can enable review details to help with troubleshooting, context usage and more.

Enable the reviews.review_details setting to include review details such as the model used, the time taken for each step and more in the review comments.

[prb112]

/jira refresh

[openshift-ci-robot]

@prb112: This pull request references Jira Issue OCPBUGS-78384, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.22.0) matches configured target version for branch (4.22.0)
• bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@prb112: This pull request references Jira Issue OCPBUGS-78384, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.22.0) matches configured target version for branch (4.22.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Details

In response to this:

OCPBUGS-78384: changed http to https for three places to reduce test false positives and false negatives

Summary by CodeRabbit

• Bug Fixes
• Upgraded external service endpoints and network connectivity tests to use HTTPS instead of HTTP, improving security and compliance with modern standards.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

Scheduling required tests:
/test e2e-aws-csi
/test e2e-aws-ovn-fips
/test e2e-aws-ovn-microshift
/test e2e-aws-ovn-microshift-serial
/test e2e-aws-ovn-serial-1of2
/test e2e-aws-ovn-serial-2of2
/test e2e-gcp-csi
/test e2e-gcp-ovn
/test e2e-gcp-ovn-upgrade
/test e2e-metal-ipi-ovn-ipv6
/test e2e-vsphere-ovn
/test e2e-vsphere-ovn-upi

[prb112]

/lgtm

[openshift-ci]

@prb112: you cannot LGTM your own PR.

Details

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[prb112]

/test e2e-aws-ovn-microshift

[sherine-k]

/retest-required

[prb112]

Looks like a timeout

/test e2e-aws-ovn-microshift

[prb112]

/test e2e-aws-ovn-microshift

[openshift-trt]

Risk analysis has seen new tests most likely introduced by this PR.
Please ensure that new tests meet guidelines for naming and stability.

New Test Risks for sha: ac04c3a

Job Name	New Test Risk
pull-ci-openshift-origin-main-e2e-aws-ovn-microshift	High - "[Jira:"Cloud Credential Operator"] Cluster_Operator CCO is disabled [Suite:cco/conformance/parallel][OTP][PolarionID:68220] NonHyperShiftHOST-Critical-Leverage Composable OpenShift feature to make cloud-credential optional" is a new test that was not present in all runs against the current commit, and also failed 1 time(s).

New tests seen in this PR at sha: ac04c3a

• "[Jira:"Cloud Credential Operator"] Cluster_Operator CCO is disabled [Suite:cco/conformance/parallel][OTP][PolarionID:68220] NonHyperShiftHOST-Critical-Leverage Composable OpenShift feature to make cloud-credential optional" [Total: 5, Pass: 4, Fail: 1, Flake: 0]

[sherine-k]

/lgtm

[stbenjam]

/lgtm
/verified by CI

[openshift-ci-robot]

@stbenjam: This PR has been marked as verified by CI.

Details

In response to this:

/lgtm
/verified by CI

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: prb112, sherine-k, stbenjam

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [stbenjam]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[stbenjam]

/jira backport release-4.21,release-4.20,release-4.19

[openshift-ci-robot]

@stbenjam: The following backport issues have been created:

• OCPBUGS-78780 for branch release-4.21
• OCPBUGS-78781 for branch release-4.20
• OCPBUGS-78782 for branch release-4.19

Queuing cherrypicks to the requested branches to be created after this PR merges:
/cherrypick release-4.21
/cherrypick release-4.20
/cherrypick release-4.19

Details

In response to this:

/jira backport release-4.21,release-4.20,release-4.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-cherrypick-robot]

@openshift-ci-robot: once the present PR merges, I will cherry-pick it on top of release-4.19, release-4.20, release-4.21 in new PRs and assign them to you.

Details

In response to this:

@stbenjam: The following backport issues have been created:

• OCPBUGS-78780 for branch release-4.21
• OCPBUGS-78781 for branch release-4.20
• OCPBUGS-78782 for branch release-4.19

Queuing cherrypicks to the requested branches to be created after this PR merges:
/cherrypick release-4.21
/cherrypick release-4.20
/cherrypick release-4.19

In response to this:

/jira backport release-4.21,release-4.20,release-4.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[openshift-ci-robot]

Scheduling required tests:
/test e2e-aws-csi
/test e2e-aws-ovn-fips
/test e2e-aws-ovn-microshift
/test e2e-aws-ovn-microshift-serial
/test e2e-aws-ovn-serial-1of2
/test e2e-aws-ovn-serial-2of2
/test e2e-gcp-csi
/test e2e-gcp-ovn
/test e2e-gcp-ovn-upgrade
/test e2e-metal-ipi-ovn-ipv6
/test e2e-vsphere-ovn
/test e2e-vsphere-ovn-upi

[openshift-ci]

@prb112: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[openshift-ci-robot]

@prb112: Jira Issue Verification Checks: Jira Issue OCPBUGS-78384
✔️ This pull request was pre-merge verified.
✔️ All associated pull requests have merged.
✔️ All associated, merged pull requests were pre-merge verified.

Jira Issue OCPBUGS-78384 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓

Details

In response to this:

OCPBUGS-78384: changed http to https for three places to reduce test false positives and false negatives

Summary by CodeRabbit

• Bug Fixes
• Upgraded external service endpoints and network connectivity tests to use HTTPS instead of HTTP, improving security and compliance with modern standards.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-cherrypick-robot]

@openshift-ci-robot: new pull request created: #30902

Details

In response to this:

@stbenjam: The following backport issues have been created:

• OCPBUGS-78780 for branch release-4.21
• OCPBUGS-78781 for branch release-4.20
• OCPBUGS-78782 for branch release-4.19

Queuing cherrypicks to the requested branches to be created after this PR merges:
/cherrypick release-4.21
/cherrypick release-4.20
/cherrypick release-4.19

In response to this:

/jira backport release-4.21,release-4.20,release-4.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[openshift-cherrypick-robot]

@openshift-ci-robot: new pull request created: #30903

Details

In response to this:

@stbenjam: The following backport issues have been created:

• OCPBUGS-78780 for branch release-4.21
• OCPBUGS-78781 for branch release-4.20
• OCPBUGS-78782 for branch release-4.19

Queuing cherrypicks to the requested branches to be created after this PR merges:
/cherrypick release-4.21
/cherrypick release-4.20
/cherrypick release-4.19

In response to this:

/jira backport release-4.21,release-4.20,release-4.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[openshift-cherrypick-robot]

@openshift-ci-robot: #30872 failed to apply on top of branch "release-4.19":

Applying: OCPBUGS-78384: changed http to https for three places to reduce test false positives and false negatives
Using index info to reconstruct a base tree...
M	pkg/monitortests/testframework/disruptionexternalservicemonitoring/monitortest.go
M	test/extended/machine_config/helpers.go
M	test/extended/networking/egress_firewall.go
Falling back to patching base and 3-way merge...
Auto-merging test/extended/networking/egress_firewall.go
CONFLICT (content): Merge conflict in test/extended/networking/egress_firewall.go
Auto-merging test/extended/machine_config/helpers.go
Auto-merging pkg/monitortests/testframework/disruptionexternalservicemonitoring/monitortest.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Patch failed at 0001 OCPBUGS-78384: changed http to https for three places to reduce test false positives and false negatives

Details

In response to this:

@stbenjam: The following backport issues have been created:

• OCPBUGS-78780 for branch release-4.21
• OCPBUGS-78781 for branch release-4.20
• OCPBUGS-78782 for branch release-4.19

Queuing cherrypicks to the requested branches to be created after this PR merges:
/cherrypick release-4.21
/cherrypick release-4.20
/cherrypick release-4.19

In response to this:

/jira backport release-4.21,release-4.20,release-4.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.