Skip to content

UPSTREAM: <carry>: enhance QE cases#666

Open
Xia-Zhao-rh wants to merge 1 commit intoopenshift:mainfrom
Xia-Zhao-rh:enhance_qe_cases
Open

UPSTREAM: <carry>: enhance QE cases#666
Xia-Zhao-rh wants to merge 1 commit intoopenshift:mainfrom
Xia-Zhao-rh:enhance_qe_cases

Conversation

@Xia-Zhao-rh
Copy link
Contributor

This PR enhances QE test cases for OLM v1 ClusterCatalog and ClusterExtension by improving test isolation, reliability, and assertion logic.

Key improvements:

  1. Enhanced test isolation: Added label-based resource selection for multiple test cases (73289, 74948, 74978, 75218, 70723) using case IDs as label values, preventing resource conflicts between concurrent test runs
  2. Improved test assertions:
    - Fixed upgrade verification logic in test 75122 using polling mechanism instead of direct condition checks
    - Updated conflict detection assertions in tests 74923 and 80117 to properly validate error messages
    - Enhanced wait conditions to be more flexible and accurate (checking for "already exists" OR "Conflicting" instead of exact strings)
    - Added better error logging and status output for debugging failures
  3. Better error handling: Added conditional error output in test 82136 to provide more context when failures occur

@openshift-ci openshift-ci bot requested review from grokspawn and pedjak March 17, 2026 08:32
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 17, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Xia-Zhao-rh
Once this PR has been reviewed and has the lgtm label, please assign joelanford for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 17, 2026

@Xia-Zhao-rh: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant