Skip to content

NO-ISSUE: Synchronize From Upstream Repositories#1275

Open
openshift-bot wants to merge 1 commit intoopenshift:mainfrom
openshift-bot:synchronize-upstream
Open

NO-ISSUE: Synchronize From Upstream Repositories#1275
openshift-bot wants to merge 1 commit intoopenshift:mainfrom
openshift-bot:synchronize-upstream

Conversation

@openshift-bot
Copy link
Copy Markdown
Contributor

@openshift-bot openshift-bot commented Apr 4, 2026

The staging/ and vendor/ directories have been synchronized from the upstream repositories, pulling in the following commits:

Date Commit Author Message
2026-04-03 21:09:56 operator-framework/operator-lifecycle-manager@1bf19cc Francesco Giudici OPRUN-4519: block upgrades from 4.23 to 5.0 (#3803)

This pull request is expected to merge without any human intervention. If tests are failing here, changes must land upstream to fix any issues so that future downstreaming efforts succeed.

/cc @openshift/openshift-team-operator-framework

* Fix maxOpenShiftVersion blocking at OCP 4.23/5.0 boundary

OCP 4.23 and 5.0 represent the same release. Add normalizeOCPVersion() to
map 4.23 to 5.0 before computing the next Y-stream and comparing an
operator's declared max version, so both cluster and operator versions
are evaluated consistently.

Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
Signed-off-by: Francesco Giudici <fgiudici@redhat.com>

* Add unit tests for OCP 4.23/5.0 upgrade edge compatibility

Cover cluster versions 4.22, 4.23, 5.0, and 5.1 against operators
declaring maxOpenShiftVersion 4.23, 5.0, and 5.1.
Add TestNormalizeOCPVersion for the new helper.

Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
Signed-off-by: Francesco Giudici <fgiudici@redhat.com>

---------

Signed-off-by: Francesco Giudici <fgiudici@redhat.com>
Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
Upstream-repository: operator-lifecycle-manager
Upstream-commit: 1bf19cc99b6e2c6db041e806593ec3bdd09aec25
@openshift-bot openshift-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. labels Apr 4, 2026
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 4, 2026
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Apr 4, 2026

@openshift-bot: This pull request explicitly references no jira issue.

Details

In response to this:

The staging/ and vendor/ directories have been synchronized from the upstream repositories, pulling in the following commits:

Date Commit Author Message
2026-04-03 21:09:56 operator-framework/operator-lifecycle-manager@1bf19cc Francesco Giudici OPRUN-4519: block upgrades from 4.23 to 5.0 (#3803)

This pull request is expected to merge without any human intervention. If tests are failing here, changes must land upstream to fix any issues so that future downstreaming efforts succeed.

/cc @openshift/openshift-team-operator-framework

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Apr 4, 2026

@openshift-bot: GitHub didn't allow me to request PR reviews from the following users: openshift/openshift-team-operator-framework.

Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs.

Details

In response to this:

The staging/ and vendor/ directories have been synchronized from the upstream repositories, pulling in the following commits:

Date Commit Author Message
2026-04-03 21:09:56 operator-framework/operator-lifecycle-manager@1bf19cc Francesco Giudici OPRUN-4519: block upgrades from 4.23 to 5.0 (#3803)

This pull request is expected to merge without any human intervention. If tests are failing here, changes must land upstream to fix any issues so that future downstreaming efforts succeed.

/cc @openshift/openshift-team-operator-framework

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 4, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 001effd7-584f-4c64-a262-7de7c33809d6

📥 Commits

Reviewing files that changed from the base of the PR and between 51af595 and 09254b4.

⛔ Files ignored due to path filters (1)
  • vendor/github.com/operator-framework/operator-lifecycle-manager/pkg/controller/operators/openshift/helpers.go is excluded by !vendor/**, !**/vendor/**
📒 Files selected for processing (2)
  • staging/operator-lifecycle-manager/pkg/controller/operators/openshift/helpers.go
  • staging/operator-lifecycle-manager/pkg/controller/operators/openshift/helpers_test.go

Walkthrough

The pull request modifies OCP version comparison logic in the operator incompatibility checker by introducing a normalizeOCPVersion helper that maps OCP 4.23 to 5.0, then applies this normalization to both the current cluster release and operator maximum versions before determining incompatibility. Tests are extended to validate this normalization behavior across multiple release boundaries.

Changes

Cohort / File(s) Summary
Core Logic
staging/operator-lifecycle-manager/pkg/controller/operators/openshift/helpers.go
Added normalizeOCPVersion function that maps OCP 4.23 to 5.0 and preserves major/minor components. Modified incompatibleOperators to normalize both current cluster release and operator olm.maxOpenShiftVersion before comparing against next minor version boundary; now skips entries with missing max values.
Test Coverage
staging/operator-lifecycle-manager/pkg/controller/operators/openshift/helpers_test.go
Extended TestIncompatibleOperators with cases for 4.22.0, 4.23.0, 5.0.0, and 5.1.0 to verify version equivalence across release boundaries. Extended TestOCPVersionNextY with nextY advancement expectations. Added new TestNormalizeOCPVersion to assert normalization behavior including 4.23.x-to-5.0 mapping.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Apr 4, 2026

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: openshift-bot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Apr 4, 2026

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: openshift-bot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Apr 4, 2026

@openshift-bot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-scos-images 09254b4 link true /test okd-scos-images

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants