NO-ISSUE: Synchronize From Upstream Repositories#1275
NO-ISSUE: Synchronize From Upstream Repositories#1275openshift-bot wants to merge 1 commit intoopenshift:mainfrom
Conversation
* Fix maxOpenShiftVersion blocking at OCP 4.23/5.0 boundary OCP 4.23 and 5.0 represent the same release. Add normalizeOCPVersion() to map 4.23 to 5.0 before computing the next Y-stream and comparing an operator's declared max version, so both cluster and operator versions are evaluated consistently. Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Francesco Giudici <fgiudici@redhat.com> * Add unit tests for OCP 4.23/5.0 upgrade edge compatibility Cover cluster versions 4.22, 4.23, 5.0, and 5.1 against operators declaring maxOpenShiftVersion 4.23, 5.0, and 5.1. Add TestNormalizeOCPVersion for the new helper. Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Francesco Giudici <fgiudici@redhat.com> --------- Signed-off-by: Francesco Giudici <fgiudici@redhat.com> Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com> Upstream-repository: operator-lifecycle-manager Upstream-commit: 1bf19cc99b6e2c6db041e806593ec3bdd09aec25
|
@openshift-bot: This pull request explicitly references no jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@openshift-bot: GitHub didn't allow me to request PR reviews from the following users: openshift/openshift-team-operator-framework. Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (2)
WalkthroughThe pull request modifies OCP version comparison logic in the operator incompatibility checker by introducing a Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: openshift-bot The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
1 similar comment
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: openshift-bot The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@openshift-bot: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
The staging/ and vendor/ directories have been synchronized from the upstream repositories, pulling in the following commits:
This pull request is expected to merge without any human intervention. If tests are failing here, changes must land upstream to fix any issues so that future downstreaming efforts succeed.
/cc @openshift/openshift-team-operator-framework