Skip to content

DOCPLAN-368: Additional DITA cleanup#112347

Open
abrennan89 wants to merge 1 commit into
openshift:mainfrom
abrennan89:dita-cleanup
Open

DOCPLAN-368: Additional DITA cleanup#112347
abrennan89 wants to merge 1 commit into
openshift:mainfrom
abrennan89:dita-cleanup

Conversation

@abrennan89 abrennan89 added this to the Continuous Release milestone May 27, 2026
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 27, 2026
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented May 27, 2026

@abrennan89: This pull request references DOCPLAN-368 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "5.0.0" version, but no target version was set.

Details

In response to this:

Version(s):
4.20+

Issue:
https://redhat.atlassian.net/browse/DOCPLAN-368

Link to docs preview:

QE review:
n/a

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci Bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 27, 2026
@abrennan89
Copy link
Copy Markdown
Contributor Author

/retest

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented May 27, 2026

@abrennan89: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@danielclowers
Copy link
Copy Markdown
Contributor

danielclowers commented May 27, 2026

✅ LGTM

What passed:

  • ✅ DITA compliance (proper content types, module structure, section IDs)
  • ✅ Red Hat SSG style (formatting, continuation symbols, capitalization)
  • ✅ Technical accuracy (snippet consolidation maintains correctness)
  • ✅ Addresses DOCPLAN-368 DITA cleanup requirements

Summary: Excellent DITA cleanup work. This PR properly converts the PersistentReservation module from PROCEDURE to CONCEPT (correct since it has no steps), adds missing section IDs for DITA processing, fixes AsciiDoc formatting with proper continuation symbols, consolidates the dynamic-key snippet inline for easier maintenance, and ensures proper assembly structure. All changes improve DITA compliance without introducing any style or technical issues.


🤖 Generated with Claude Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch/enterprise-4.20 branch/enterprise-4.21 branch/enterprise-4.22 CNV Label for all CNV PRs jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants