[SRVLOGIC-443] Document Kubernetes service discovery#109172
Open
ochromy wants to merge 1 commit intoopenshift:serverless-docs-mainfrom
Open
[SRVLOGIC-443] Document Kubernetes service discovery#109172ochromy wants to merge 1 commit intoopenshift:serverless-docs-mainfrom
ochromy wants to merge 1 commit intoopenshift:serverless-docs-mainfrom
Conversation
openshift-ci
bot
added
the
size/L
|
🤖 Mon Mar 30 08:52:33 - Prow CI generated the docs preview: |
kaldesai
reviewed
Mar 30, 2026
kaldesai
reviewed
Mar 30, 2026
kaldesai
approved these changes
Mar 30, 2026
kaldesai
left a comment
kaldesai
left a comment
There was a problem hiding this comment.
Excellent work :)
Just a tiny nitpicks you can consider, otherwise LGTM
Peer review is complete
improvements no1 improvements no2 improvements no3 improvements no4 improvements no5 improvements no6 improvements no7 improvements no8 [SRVLOGIC-442] Document Custom podSpec definition. improvements no1 improvements no2 improvements no3 improvements no4 improvements no5 improvements no6 improvements no7 improvements no8 peer review no1 resolve conflict with 442 add include module peer review feedback no1
|
@ochromy: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Version(s):
serverless-docs-1.36serverless-docs-1.37serverless-docs-1.38Issue:
Link to docs preview:
QE review: