Skip to content

CNV-71192: Add TP support for custom video device selection when crea… #104234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
MirzWeiss wants to merge 1 commit into
base: main
Choose a base branch
from
Open

CNV-71192: Add TP support for custom video device selection when crea… #104234

MirzWeiss wants to merge 1 commit into from
+62 −11

Conversation

@MirzWeiss
Copy link
Contributor

@MirzWeiss MirzWeiss commented Dec 21, 2025 •
edited
Loading

Version(s):
Main, 4.21

Issue: CNV-71192

Link to docs preview:

QE review:

  • QE has approved this change.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 21, 2025 •
edited by openshift-ci bot
Loading

@MirzWeiss: This pull request references CNV-71192 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Version(s):
Main, 4.21

Issue: CNV-71192

Link to docs preview

QE review:

  • QE has approved this change.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Dec 21, 2025
@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 21, 2025
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Dec 21, 2025 •
edited
Loading

🤖 Wed Dec 24 09:59:16 - Prow CI generated the docs preview:

https://104234--ocpdocs-pr.netlify.app/openshift-enterprise/latest/virt/creating_vms_advanced/creating_vms_cli/virt-creating-vms-from-cli.html
https://104234--ocpdocs-pr.netlify.app/openshift-rosa-hcp/latest/virt/creating_vms_advanced/creating_vms_cli/virt-creating-vms-from-cli.html
https://104234--ocpdocs-pr.netlify.app/openshift-rosa/latest/virt/creating_vms_advanced/creating_vms_cli/virt-creating-vms-from-cli.html

ocpdocs-vale-bot
ocpdocs-vale-bot reviewed Dec 21, 2025
View reviewed changes
modules/virt-creating-vm-cli.adoc
Copy link
Collaborator

@ocpdocs-vale-bot ocpdocs-vale-bot Dec 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 [error] AsciiDocDITA.ShortDescription: Assign [role="_abstract"] to a paragraph to use it as in DITA.

ocpdocs-vale-bot
ocpdocs-vale-bot reviewed Dec 21, 2025
View reviewed changes
ocpdocs-vale-bot
ocpdocs-vale-bot reviewed Dec 21, 2025
View reviewed changes
virt/creating_vms_advanced/creating_vms_cli/virt-creating-vms-from-cli.adoc
Copy link
Collaborator

@ocpdocs-vale-bot ocpdocs-vale-bot Dec 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 [error] AsciiDocDITA.ShortDescription: Assign [role="_abstract"] to a paragraph to use it as in DITA.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 22, 2025 •
edited by openshift-ci bot
Loading

@MirzWeiss: This pull request references CNV-71192 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Version(s):
Main, 4.21

Issue: CNV-71192

Link to docs preview:

QE review:

  • QE has approved this change.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

dasionov
dasionov reviewed Dec 22, 2025
View reviewed changes
@MirzWeiss MirzWeiss force-pushed the CNV-71192 branch 2 times, most recently from 8d0452e to c67b134 Compare December 23, 2025 08:13
@MirzWeiss MirzWeiss added this to the Planned for 4.21 GA milestone Dec 23, 2025
@MirzWeiss MirzWeiss added CNV Label for all CNV PRs branch/enterprise-4.21 labels Dec 23, 2025
dasionov
dasionov approved these changes Dec 23, 2025
View reviewed changes
Copy link

@dasionov dasionov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MirzWeiss Thank you for this PR!

akri3i
akri3i suggested changes Dec 24, 2025
View reviewed changes
@akri3i
Copy link

akri3i commented Dec 24, 2025

/lgtm

@MirzWeiss MirzWeiss requested a review from akri3i December 24, 2025 09:52
@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 24, 2025 •
edited by openshift-ci bot
Loading

@MirzWeiss: This pull request references CNV-71192 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Version(s):
Main, 4.21

Issue: CNV-71192

Link to docs preview:

QE review:

  • QE has approved this change.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link

openshift-ci bot commented Dec 24, 2025

@akri3i: changing LGTM is restricted to collaborators

Details

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci
Copy link

openshift-ci bot commented Dec 24, 2025

@MirzWeiss: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@akri3i akri3i Awaiting requested review from akri3i

2 more reviewers

@ocpdocs-vale-bot ocpdocs-vale-bot ocpdocs-vale-bot left review comments

@dasionov dasionov dasionov approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

branch/enterprise-4.21 CNV Label for all CNV PRs jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

Planned for 4.21 GA

Development

Successfully merging this pull request may close these issues.

6 participants

@MirzWeiss @openshift-ci-robot @ocpdocs-previewbot @akri3i @ocpdocs-vale-bot @dasionov