Skip to content

use dockerconfigjson format for pull secrets #408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
sanchezl wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

use dockerconfigjson format for pull secrets #408

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions pkg/internalregistry/controllers/image_pull_secret_controller.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -268,6 +268,20 @@ func dockerConfig(token string, urls []string) any {
return auth
}

func dockerConfigJSON(token string, urls []string) any {
// not using credentialprovider.DockerConfigJSON to keep redundant username/password/email out of secret
auths := map[string]map[string]string{}
entry := map[string]string{
"auth": base64.StdEncoding.EncodeToString([]byte("<token>:" + token)),
}
for _, url := range urls {
auths[url] = entry
}
return map[string]map[string]map[string]string{
"auths": auths,
}
}

func isSecretRefreshNeeded(secret *corev1.Secret, urls, kids []string, now time.Time) (bool, *time.Time) {
valid, refreshAt := registryAuthenticationFileValid(secret, urls, kids, now)
return !valid, refreshAt
Expand Down