-
Notifications
You must be signed in to change notification settings - Fork 86
Add kubevirt-datamover plugin support to DPA #2074
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: oadp-dev
Are you sure you want to change the base?
Conversation
WalkthroughAdds support for a new KubeVirt data mover plugin variant to OADP by introducing plugin constants, extending CRD schemas to include the plugin identifier in default plugins and unsupported image overrides, and configuring plugin-specific metadata. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Assessment against linked issues
✨ Finishing touches
Comment |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Joeavaikath The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Adds support for the kubevirt-datamover plugin as a new default plugin
option in the DataProtectionApplication CRD. This plugin enables data
movement capabilities for KubeVirt virtual machines during backup and
restore operations.
Changes include:
- Add DefaultPluginKubeVirtDataMover constant to DefaultPlugin enum
- Add KubeVirtDatamoverImageKey to unsupportedOverrides configuration
- Add plugin image constant and name mapping in pkg/common
- Add credentials and image retrieval logic in pkg/credentials
- Update CRD validation to accept 'kubevirt-datamover' plugin value
- Update bundle manifests with new plugin enum value
Users can now specify 'kubevirt-datamover' in the DPA spec:
spec:
configuration:
velero:
defaultPlugins:
- kubevirt-datamover
Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Signed-off-by: Joseph <jvaikath@redhat.com>
7b870c1 to
9a94818
Compare
|
@Joeavaikath: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Why the changes were made
Adds support for the kubevirt-datamover plugin as a new default plugin option in the DataProtectionApplication CRD. This plugin enables data movement capabilities for KubeVirt virtual machines during backup and restore operations.
Changes include:
Users can now specify 'kubevirt-datamover' in the DPA spec:
spec:
configuration:
velero:
defaultPlugins:
- kubevirt-datamover
This will close #2065
How to test the changes made
Once the kubevirt-datamover image exists to be tested, supplying the
kubevirt-datamoverindefaultPluginsshould work