USHIFT-6950: Ansible: Update host defaults for MicroShift 4.22#6627
USHIFT-6950: Ansible: Update host defaults for MicroShift 4.22#6627sjug wants to merge 1 commit intoopenshift:mainfrom
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@sjug: This pull request references USHIFT-6950 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "5.0.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
WalkthroughTwo independent configuration updates: Go toolchain version incremented from 1.24.4 to 1.25.0 with LVM volume group name changed from ChangesGo Toolchain and LVM Configuration Update
MicroShift Version Support
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 12✅ Passed checks (12 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: sjug The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (4)
ansible/roles/setup-microshift-host/defaults/main.yml (4)
12-13: ⚡ Quick winConsider pinning to a more recent Go 1.25.x patch.
Go 1.25.0 is valid, but Go 1.25.9 (released 2026-04-07) includes security fixes to the go command, the compiler, and several standard library packages. Pinning to
1.25.0skips these security patches.🔧 Proposed update
-go_version: 1.25.0 +go_version: 1.25.9🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@ansible/roles/setup-microshift-host/defaults/main.yml` around lines 12 - 13, Update the Go version pin by setting the go_version default from 1.25.0 to the latest 1.25.x patch (e.g., 1.25.9) and update the dependent go_install_dir value (go_install_dir: /usr/local/go{{ go_version }}) so the role installs the patched Go release; adjust go_version in defaults/main.yml (the go_version and go_install_dir variables) to the newer patch level.
32-33: ⚡ Quick win
default_vg_namerename may break existing environments.Changing from
microshifttorhel_microshiftis intentional to align with standard RHEL installs, but users with an existing VG namedmicroshiftwho don't overridevg_namewill silently target the wrong VG. Consider a note in the role's README or a comment here calling out the migration step.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@ansible/roles/setup-microshift-host/defaults/main.yml` around lines 32 - 33, The rename of the variable default_vg_name from "microshift" to "rhel_microshift" can break environments that rely on the old VG name; update the role to warn and provide migration guidance by adding a clear comment next to default_vg_name and vg_name explaining the rename and the expected override behavior, and update the role README with a short migration note and example override (reference variables default_vg_name and vg_name) so operators know to rename or set vg_name explicitly to "microshift" if needed.
32-33: ⚡ Quick win
default_vg_namerename may silently break existing setups.Users upgrading who still have a VG named
microshiftand don't overridevg_namewill silently target a nonexistent VG. A short comment here (or a note in the role README) calling out the migration step would help.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@ansible/roles/setup-microshift-host/defaults/main.yml` around lines 32 - 33, Add a short inline comment above the default_vg_name and vg_name variables explaining that default_vg_name was renamed from "microshift" to "rhel_microshift" and that upgrades may need a migration: instruct users to set vg_name to "microshift" if they still have the old VG or to rename their VG to "rhel_microshift"; also add the same note to the role README so upgrader guidance is surfaced. Reference the variables default_vg_name and vg_name when adding the comment and README note.
12-13: ⚡ Quick winGo 1.25.0 is released and available. No download/install risk.
However, Go 1.26.3 is the latest stable release as of May 2026. Consider updating to the latest version for recent improvements and security updates.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@ansible/roles/setup-microshift-host/defaults/main.yml` around lines 12 - 13, Update the go_version default from "1.25.0" to the current stable "1.26.3" and adjust the go_install_dir value to match the new version (ensure go_install_dir uses the updated go_version variable so it becomes "/usr/local/go1.26.3"); verify any other references to go_version in the role (e.g., tasks or templates) are consistent with the new version string.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@ansible/roles/setup-microshift-host/defaults/main.yml`:
- Around line 12-13: Update the Go version pin by setting the go_version default
from 1.25.0 to the latest 1.25.x patch (e.g., 1.25.9) and update the dependent
go_install_dir value (go_install_dir: /usr/local/go{{ go_version }}) so the role
installs the patched Go release; adjust go_version in defaults/main.yml (the
go_version and go_install_dir variables) to the newer patch level.
- Around line 32-33: The rename of the variable default_vg_name from
"microshift" to "rhel_microshift" can break environments that rely on the old VG
name; update the role to warn and provide migration guidance by adding a clear
comment next to default_vg_name and vg_name explaining the rename and the
expected override behavior, and update the role README with a short migration
note and example override (reference variables default_vg_name and vg_name) so
operators know to rename or set vg_name explicitly to "microshift" if needed.
- Around line 32-33: Add a short inline comment above the default_vg_name and
vg_name variables explaining that default_vg_name was renamed from "microshift"
to "rhel_microshift" and that upgrades may need a migration: instruct users to
set vg_name to "microshift" if they still have the old VG or to rename their VG
to "rhel_microshift"; also add the same note to the role README so upgrader
guidance is surfaced. Reference the variables default_vg_name and vg_name when
adding the comment and README note.
- Around line 12-13: Update the go_version default from "1.25.0" to the current
stable "1.26.3" and adjust the go_install_dir value to match the new version
(ensure go_install_dir uses the updated go_version variable so it becomes
"/usr/local/go1.26.3"); verify any other references to go_version in the role
(e.g., tasks or templates) are consistent with the new version string.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: 0958c362-1ff7-42b4-a7a4-e55e6e74a7f9
📒 Files selected for processing (2)
ansible/roles/setup-microshift-host/defaults/main.ymlansible/vars/microshift_versions.yml
|
@sjug: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
2 participants
Adds the 4.22 pod-readiness entry, bumps the bundled Go toolchain to 1.25 as required by MicroShift 4.22, and switches the default LVM volume group to
rhel_microshiftto match the VG created by standard RHEL installs.Summary by CodeRabbit
Updates
New Features