CNF-23391: mockgen deprecated: use uber-go/mock instead by sebrandon1 · Pull Request #197 · openshift/managed-node-metadata-operator

sebrandon1 · 2025-11-14T15:57:32Z

https://github.com/golang/mock is marked as archived as of June 27, 2023. They recommend using go.uber.org/mock.

This PR attempts to change the dependency to one that is maintained.

Tracking issue: redhat-best-practices-for-k8s/telco-bot#45

Summary by CodeRabbit

Chores
- Updated the project’s testing mock dependency and adjusted module requirements to use an updated mock library.
- Changes are limited to development/test configuration; no runtime behavior, public APIs, exported interfaces, or tests’ logic were altered.

codecov-commenter · 2025-11-14T16:07:01Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 58.60%. Comparing base (0a6f0ba) to head (db5a001).

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #197   +/-   ##
=======================================
  Coverage   58.60%   58.60%           
=======================================
  Files           5        5           
  Lines         244      244           
=======================================
  Hits          143      143           
  Misses         87       87           
  Partials       14       14

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

sebrandon1 · 2026-01-29T20:20:52Z

/retest

coderabbitai · 2026-04-30T19:01:17Z

Walkthrough

The project switches its gomock provider from github.com/golang/mock to go.uber.org/mock, updating go.mod (removing the old require and adding go.uber.org/mock v0.6.0) and changing the gomock import in controllers/machineset_controller_test.go.

Changes

Mock dependency migration

Layer / File(s)	Summary
Module requirement `go.mod`	Removes `github.com/golang/mock v1.6.0` from the parenthesized `require (...)` list and adds `require go.uber.org/mock v0.6.0` as a direct top-level require.
Tests / Imports `controllers/machineset_controller_test.go`	Updates test import from `github.com/golang/mock/gomock` to `go.uber.org/mock/gomock`; other imports unchanged.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 14 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	The description lacks the required template structure, missing key sections like 'What is being added?', testing checklist, and manual testing steps.	Add the required sections from the template: explain what is being fixed, complete the testing checklist, and provide steps to manually test the changes.

✅ Passed checks (14 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and specifically describes the main change: replacing the deprecated golang/mock with uber-go/mock.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	All Ginkgo test titles use static, deterministic strings. No dynamic content (timestamps, UUIDs, node/pod names, IP addresses) found in any test file.
Test Structure And Quality	✅ Passed	PR only updates mock library import; no test code changes. Tests follow Ginkgo quality patterns (setup/cleanup, single responsibility) though lack assertion failure messages.
Microshift Test Compatibility	✅ Passed	PR updates golang/mock to uber-go/mock. The added file is a unit test, not an e2e test. Custom check applies only to new Ginkgo e2e tests.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	This PR is a dependency update (golang/mock → go.uber.org/mock) with no new Ginkgo e2e tests added. The check only applies to new e2e tests, not unit/integration tests or dependency changes.
Topology-Aware Scheduling Compatibility	✅ Passed	PR updates test dependencies only (gomock import path and go.mod), with no changes to deployment manifests, scheduling constraints, replicas, affinity rules, or topology-aware configurations.
Ote Binary Stdout Contract	✅ Passed	PR changes import gomock only in test files within BeforeEach blocks. No stdout writes in main code or go.uber.org/mock library.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	PR only updates mock library dependency and import path. No new Ginkgo e2e tests are added, so IPv6/disconnected network check is not applicable.
No-Weak-Crypto	✅ Passed	PR contains no weak cryptography: no MD5/SHA1/DES/RC4/3DES/Blowfish/ECB usage, no custom crypto, no insecure secret comparisons. Changes only update mock testing library dependency.
Container-Privileges	✅ Passed	PR only modifies Go dependency (gomock) and test import path; does not change any container or K8s manifests. No privileged settings were introduced or modified.
No-Sensitive-Data-In-Logs	✅ Passed	The PR only updates mock library dependencies (github.com/golang/mock → go.uber.org/mock) with no logging or sensitive data exposure in the changes.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

openshift-ci-robot · 2026-04-30T19:09:39Z

@sebrandon1: This pull request references CNF-23391 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set.

Details

In response to this:

https://github.com/golang/mock is marked as archived as of June 27, 2023. They recommend using go.uber.org/mock.

This PR attempts to change the dependency to one that is maintained.

Tracking issue: redhat-best-practices-for-k8s/telco-bot#45

Summary by CodeRabbit

Chores

Updated internal testing dependencies for improved development infrastructure and maintenance.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

sebrandon1 · 2026-05-20T15:11:22Z

/retest

openshift-ci · 2026-05-20T15:36:43Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sebrandon1
Once this PR has been reviewed and has the lgtm label, please assign sam-nguyen7 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

coderabbitai

🧹 Nitpick comments (1)

go.mod (1)
20-20: ⚡ Quick win

Verify go.uber.org/mock v0.6.0 security & licensing

go.uber.org/mock v0.6.0 is the latest stable release and uses Apache License 2.0.

GitHub security advisory lookup returned no known vulnerabilities for go.uber.org/mock (current advisories list was empty).

Minor consistency: the standalone require go.uber.org/mock v0.6.0 outside the main require (...) block is acceptable, but could be moved into the block for readability.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@go.mod` at line 20, The go.mod has a standalone dependency declaration
"require go.uber.org/mock v0.6.0" — verify and document that this version is
Apache-2.0 licensed and has no known advisories, then move that standalone
"require go.uber.org/mock v0.6.0" line into the main require(...) block in
go.mod for readability and consistency and run go mod tidy to update go.sum
accordingly.

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In `@go.mod`:
- Line 20: The go.mod has a standalone dependency declaration "require
go.uber.org/mock v0.6.0" — verify and document that this version is Apache-2.0
licensed and has no known advisories, then move that standalone "require
go.uber.org/mock v0.6.0" line into the main require(...) block in go.mod for
readability and consistency and run go mod tidy to update go.sum accordingly.

ℹ️ Review info

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 6d7cf807-a275-404f-94a3-e988cf5d0881

📥 Commits

Reviewing files that changed from the base of the PR and between db5a001 and 973dbab.

⛔ Files ignored due to path filters (287)

go.sum is excluded by !**/*.sum
vendor/github.com/aymerick/douceur/LICENSE is excluded by !**/vendor/**, !vendor/**
vendor/github.com/aymerick/douceur/css/declaration.go is excluded by !**/vendor/**, !vendor/**
vendor/github.com/aymerick/douceur/css/rule.go is excluded by !**/vendor/**, !vendor/**
vendor/github.com/aymerick/douceur/css/stylesheet.go is excluded by !**/vendor/**, !vendor/**
vendor/github.com/aymerick/douceur/parser/parser.go is excluded by !**/vendor/**, !vendor/**
vendor/github.com/beorn7/perks/LICENSE is excluded by !**/vendor/**, !vendor/**
vendor/github.com/beorn7/perks/quantile/exampledata.txt is excluded by !**/vendor/**, !vendor/**
vendor/github.com/beorn7/perks/quantile/stream.go is excluded by !**/vendor/**, !vendor/**
vendor/github.com/blang/semver/v4/LICENSE is excluded by !**/vendor/**, !vendor/**
vendor/github.com/blang/semver/v4/json.go is excluded by !**/vendor/**, !vendor/**
vendor/github.com/blang/semver/v4/range.go is excluded by !**/vendor/**, !vendor/**
vendor/github.com/blang/semver/v4/semver.go is excluded by !**/vendor/**, !vendor/**
vendor/github.com/blang/semver/v4/sort.go is excluded by !**/vendor/**, !vendor/**
vendor/github.com/blang/semver/v4/sql.go is excluded by !**/vendor/**, !vendor/**
vendor/github.com/cenkalti/backoff/v4/.gitignore is excluded by !**/vendor/**, !vendor/**
vendor/github.com/cenkalti/backoff/v4/LICENSE is excluded by !**/vendor/**, !vendor/**
vendor/github.com/cenkalti/backoff/v4/README.md is excluded by !**/vendor/**, !vendor/**
vendor/github.com/cenkalti/backoff/v4/backoff.go is excluded by !**/vendor/**, !vendor/**
vendor/github.com/cenkalti/backoff/v4/context.go is excluded by !**/vendor/**, !vendor/**
vendor/github.com/cenkalti/backoff/v4/exponential.go is excluded by !**/vendor/**, !vendor/**
vendor/github.com/cenkalti/backoff/v4/retry.go is excluded by !**/vendor/**, !vendor/**
vendor/github.com/cenkalti/backoff/v4/ticker.go is excluded by !**/vendor/**, !vendor/**
vendor/github.com/cenkalti/backoff/v4/timer.go is excluded by !**/vendor/**, !vendor/**
vendor/github.com/cenkalti/backoff/v4/tries.go is excluded by !**/vendor/**, !vendor/**
vendor/github.com/cespare/xxhash/v2/LICENSE.txt is excluded by !**/vendor/**, !vendor/**
vendor/github.com/cespare/xxhash/v2/README.md is excluded by !**/vendor/**, !vendor/**
vendor/github.com/cespare/xxhash/v2/testall.sh is excluded by !**/vendor/**, !vendor/**
vendor/github.com/cespare/xxhash/v2/xxhash.go is excluded by !**/vendor/**, !vendor/**
vendor/github.com/cespare/xxhash/v2/xxhash_amd64.s is excluded by !**/vendor/**, !vendor/**
vendor/github.com/cespare/xxhash/v2/xxhash_arm64.s is excluded by !**/vendor/**, !vendor/**
vendor/github.com/cespare/xxhash/v2/xxhash_asm.go is excluded by !**/vendor/**, !vendor/**
vendor/github.com/cespare/xxhash/v2/xxhash_other.go is excluded by !**/vendor/**, !vendor/**
vendor/github.com/cespare/xxhash/v2/xxhash_safe.go is excluded by !**/vendor/**, !vendor/**
vendor/github.com/cespare/xxhash/v2/xxhash_unsafe.go is excluded by !**/vendor/**, !vendor/**
vendor/github.com/davecgh/go-spew/LICENSE is excluded by !**/vendor/**, !vendor/**
vendor/github.com/davecgh/go-spew/spew/bypass.go is excluded by !**/vendor/**, !vendor/**
vendor/github.com/davecgh/go-spew/spew/bypasssafe.go is excluded by !**/vendor/**, !vendor/**
vendor/github.com/davecgh/go-spew/spew/common.go is excluded by !**/vendor/**, !vendor/**
vendor/github.com/davecgh/go-spew/spew/config.go is excluded by !**/vendor/**, !vendor/**
vendor/github.com/davecgh/go-spew/spew/doc.go is excluded by !**/vendor/**, !vendor/**
vendor/github.com/davecgh/go-spew/spew/dump.go is excluded by !**/vendor/**, !vendor/**
vendor/github.com/davecgh/go-spew/spew/format.go is excluded by !**/vendor/**, !vendor/**
vendor/github.com/davecgh/go-spew/spew/spew.go is excluded by !**/vendor/**, !vendor/**
vendor/github.com/emicklei/go-restful/v3/.gitignore is excluded by !**/vendor/**, !vendor/**
vendor/github.com/emicklei/go-restful/v3/.goconvey is excluded by !**/vendor/**, !vendor/**
vendor/github.com/emicklei/go-restful/v3/.travis.yml is excluded by !**/vendor/**, !vendor/**
vendor/github.com/emicklei/go-restful/v3/CHANGES.md is excluded by !**/vendor/**, !vendor/**
vendor/github.com/emicklei/go-restful/v3/LICENSE is excluded by !**/vendor/**, !vendor/**
vendor/github.com/emicklei/go-restful/v3/Makefile is excluded by !**/vendor/**, !vendor/**
vendor/github.com/emicklei/go-restful/v3/README.md is excluded by !**/vendor/**, !vendor/**
vendor/github.com/emicklei/go-restful/v3/SECURITY.md is excluded by !**/vendor/**, !vendor/**
vendor/github.com/emicklei/go-restful/v3/Srcfile is excluded by !**/vendor/**, !vendor/**
vendor/github.com/emicklei/go-restful/v3/bench_test.sh is excluded by !**/vendor/**, !vendor/**
vendor/github.com/emicklei/go-restful/v3/compress.go is excluded by !**/vendor/**, !vendor/**
vendor/github.com/emicklei/go-restful/v3/compressor_cache.go is excluded by !**/vendor/**, !vendor/**
vendor/github.com/emicklei/go-restful/v3/compressor_pools.go is excluded by !**/vendor/**, !vendor/**
vendor/github.com/emicklei/go-restful/v3/compressors.go is excluded by !**/vendor/**, !vendor/**
vendor/github.com/emicklei/go-restful/v3/constants.go is excluded by !**/vendor/**, !vendor/**
vendor/github.com/emicklei/go-restful/v3/container.go is excluded by !**/vendor/**, !vendor/**
vendor/github.com/emicklei/go-restful/v3/cors_filter.go is excluded by !**/vendor/**, !vendor/**
vendor/github.com/emicklei/go-restful/v3/coverage.sh is excluded by !**/vendor/**, !vendor/**
vendor/github.com/emicklei/go-restful/v3/curly.go is excluded by !**/vendor/**, !vendor/**
vendor/github.com/emicklei/go-restful/v3/curly_route.go is excluded by !**/vendor/**, !vendor/**
vendor/github.com/emicklei/go-restful/v3/custom_verb.go is excluded by !**/vendor/**, !vendor/**
vendor/github.com/emicklei/go-restful/v3/doc.go is excluded by !**/vendor/**, !vendor/**
vendor/github.com/emicklei/go-restful/v3/entity_accessors.go is excluded by !**/vendor/**, !vendor/**
vendor/github.com/emicklei/go-restful/v3/extensions.go is excluded by !**/vendor/**, !vendor/**
vendor/github.com/emicklei/go-restful/v3/filter.go is excluded by !**/vendor/**, !vendor/**
vendor/github.com/emicklei/go-restful/v3/filter_adapter.go is excluded by !**/vendor/**, !vendor/**
vendor/github.com/emicklei/go-restful/v3/json.go is excluded by !**/vendor/**, !vendor/**
vendor/github.com/emicklei/go-restful/v3/jsoniter.go is excluded by !**/vendor/**, !vendor/**
vendor/github.com/emicklei/go-restful/v3/jsr311.go is excluded by !**/vendor/**, !vendor/**
vendor/github.com/emicklei/go-restful/v3/log/log.go is excluded by !**/vendor/**, !vendor/**
vendor/github.com/emicklei/go-restful/v3/logger.go is excluded by !**/vendor/**, !vendor/**
vendor/github.com/emicklei/go-restful/v3/mime.go is excluded by !**/vendor/**, !vendor/**
vendor/github.com/emicklei/go-restful/v3/options_filter.go is excluded by !**/vendor/**, !vendor/**
vendor/github.com/emicklei/go-restful/v3/parameter.go is excluded by !**/vendor/**, !vendor/**
vendor/github.com/emicklei/go-restful/v3/path_expression.go is excluded by !**/vendor/**, !vendor/**
vendor/github.com/emicklei/go-restful/v3/path_processor.go is excluded by !**/vendor/**, !vendor/**
vendor/github.com/emicklei/go-restful/v3/request.go is excluded by !**/vendor/**, !vendor/**
vendor/github.com/emicklei/go-restful/v3/response.go is excluded by !**/vendor/**, !vendor/**
vendor/github.com/emicklei/go-restful/v3/route.go is excluded by !**/vendor/**, !vendor/**
vendor/github.com/emicklei/go-restful/v3/route_builder.go is excluded by !**/vendor/**, !vendor/**
vendor/github.com/emicklei/go-restful/v3/route_reader.go is excluded by !**/vendor/**, !vendor/**
vendor/github.com/emicklei/go-restful/v3/router.go is excluded by !**/vendor/**, !vendor/**
vendor/github.com/emicklei/go-restful/v3/service_error.go is excluded by !**/vendor/**, !vendor/**
vendor/github.com/emicklei/go-restful/v3/web_service.go is excluded by !**/vendor/**, !vendor/**
vendor/github.com/emicklei/go-restful/v3/web_service_container.go is excluded by !**/vendor/**, !vendor/**
vendor/github.com/evanphx/json-patch/v5/LICENSE is excluded by !**/vendor/**, !vendor/**
vendor/github.com/evanphx/json-patch/v5/errors.go is excluded by !**/vendor/**, !vendor/**
vendor/github.com/evanphx/json-patch/v5/internal/json/decode.go is excluded by !**/vendor/**, !vendor/**
vendor/github.com/evanphx/json-patch/v5/internal/json/encode.go is excluded by !**/vendor/**, !vendor/**
vendor/github.com/evanphx/json-patch/v5/internal/json/fold.go is excluded by !**/vendor/**, !vendor/**
vendor/github.com/evanphx/json-patch/v5/internal/json/fuzz.go is excluded by !**/vendor/**, !vendor/**
vendor/github.com/evanphx/json-patch/v5/internal/json/indent.go is excluded by !**/vendor/**, !vendor/**
vendor/github.com/evanphx/json-patch/v5/internal/json/scanner.go is excluded by !**/vendor/**, !vendor/**
vendor/github.com/evanphx/json-patch/v5/internal/json/stream.go is excluded by !**/vendor/**, !vendor/**
vendor/github.com/evanphx/json-patch/v5/internal/json/tables.go is excluded by !**/vendor/**, !vendor/**
vendor/github.com/evanphx/json-patch/v5/internal/json/tags.go is excluded by !**/vendor/**, !vendor/**
vendor/github.com/evanphx/json-patch/v5/merge.go is excluded by !**/vendor/**, !vendor/**
vendor/github.com/evanphx/json-patch/v5/patch.go is excluded by !**/vendor/**, !vendor/**
vendor/github.com/fsnotify/fsnotify/.cirrus.yml is excluded by !**/vendor/**, !vendor/**
vendor/github.com/fsnotify/fsnotify/.editorconfig is excluded by !**/vendor/**, !vendor/**
vendor/github.com/fsnotify/fsnotify/.gitattributes is excluded by !**/vendor/**, !vendor/**
vendor/github.com/fsnotify/fsnotify/.gitignore is excluded by !**/vendor/**, !vendor/**
vendor/github.com/fsnotify/fsnotify/.mailmap is excluded by !**/vendor/**, !vendor/**
vendor/github.com/fsnotify/fsnotify/CHANGELOG.md is excluded by !**/vendor/**, !vendor/**
vendor/github.com/fsnotify/fsnotify/CONTRIBUTING.md is excluded by !**/vendor/**, !vendor/**
vendor/github.com/fsnotify/fsnotify/LICENSE is excluded by !**/vendor/**, !vendor/**
vendor/github.com/fsnotify/fsnotify/README.md is excluded by !**/vendor/**, !vendor/**
vendor/github.com/fsnotify/fsnotify/backend_fen.go is excluded by !**/vendor/**, !vendor/**
vendor/github.com/fsnotify/fsnotify/backend_inotify.go is excluded by !**/vendor/**, !vendor/**
vendor/github.com/fsnotify/fsnotify/backend_kqueue.go is excluded by !**/vendor/**, !vendor/**
vendor/github.com/fsnotify/fsnotify/backend_other.go is excluded by !**/vendor/**, !vendor/**
vendor/github.com/fsnotify/fsnotify/backend_windows.go is excluded by !**/vendor/**, !vendor/**
vendor/github.com/fsnotify/fsnotify/fsnotify.go is excluded by !**/vendor/**, !vendor/**
vendor/github.com/fsnotify/fsnotify/mkdoc.zsh is excluded by !**/vendor/**, !vendor/**
vendor/github.com/fsnotify/fsnotify/system_bsd.go is excluded by !**/vendor/**, !vendor/**
vendor/github.com/fsnotify/fsnotify/system_darwin.go is excluded by !**/vendor/**, !vendor/**
vendor/github.com/fxamacker/cbor/v2/.gitignore is excluded by !**/vendor/**, !vendor/**
vendor/github.com/fxamacker/cbor/v2/.golangci.yml is excluded by !**/vendor/**, !vendor/**
vendor/github.com/fxamacker/cbor/v2/CODE_OF_CONDUCT.md is excluded by !**/vendor/**, !vendor/**
vendor/github.com/fxamacker/cbor/v2/CONTRIBUTING.md is excluded by !**/vendor/**, !vendor/**
vendor/github.com/fxamacker/cbor/v2/LICENSE is excluded by !**/vendor/**, !vendor/**
vendor/github.com/fxamacker/cbor/v2/README.md is excluded by !**/vendor/**, !vendor/**
vendor/github.com/fxamacker/cbor/v2/SECURITY.md is excluded by !**/vendor/**, !vendor/**
vendor/github.com/fxamacker/cbor/v2/bytestring.go is excluded by !**/vendor/**, !vendor/**
vendor/github.com/fxamacker/cbor/v2/cache.go is excluded by !**/vendor/**, !vendor/**
vendor/github.com/fxamacker/cbor/v2/common.go is excluded by !**/vendor/**, !vendor/**
vendor/github.com/fxamacker/cbor/v2/decode.go is excluded by !**/vendor/**, !vendor/**
vendor/github.com/fxamacker/cbor/v2/diagnose.go is excluded by !**/vendor/**, !vendor/**
vendor/github.com/fxamacker/cbor/v2/doc.go is excluded by !**/vendor/**, !vendor/**
vendor/github.com/fxamacker/cbor/v2/encode.go is excluded by !**/vendor/**, !vendor/**
vendor/github.com/fxamacker/cbor/v2/encode_map.go is excluded by !**/vendor/**, !vendor/**
vendor/github.com/fxamacker/cbor/v2/omitzero_go124.go is excluded by !**/vendor/**, !vendor/**
vendor/github.com/fxamacker/cbor/v2/omitzero_pre_go124.go is excluded by !**/vendor/**, !vendor/**
vendor/github.com/fxamacker/cbor/v2/simplevalue.go is excluded by !**/vendor/**, !vendor/**
vendor/github.com/fxamacker/cbor/v2/stream.go is excluded by !**/vendor/**, !vendor/**
vendor/github.com/fxamacker/cbor/v2/structfields.go is excluded by !**/vendor/**, !vendor/**
vendor/github.com/fxamacker/cbor/v2/tag.go is excluded by !**/vendor/**, !vendor/**
vendor/github.com/fxamacker/cbor/v2/valid.go is excluded by !**/vendor/**, !vendor/**
vendor/github.com/go-logr/logr/.golangci.yaml is excluded by !**/vendor/**, !vendor/**
vendor/github.com/go-logr/logr/CHANGELOG.md is excluded by !**/vendor/**, !vendor/**
vendor/github.com/go-logr/logr/CONTRIBUTING.md is excluded by !**/vendor/**, !vendor/**
vendor/github.com/go-logr/logr/LICENSE is excluded by !**/vendor/**, !vendor/**
vendor/github.com/go-logr/logr/README.md is excluded by !**/vendor/**, !vendor/**
vendor/github.com/go-logr/logr/SECURITY.md is excluded by !**/vendor/**, !vendor/**
vendor/github.com/go-logr/logr/context.go is excluded by !**/vendor/**, !vendor/**
vendor/github.com/go-logr/logr/context_noslog.go is excluded by !**/vendor/**, !vendor/**
vendor/github.com/go-logr/logr/context_slog.go is excluded by !**/vendor/**, !vendor/**
vendor/github.com/go-logr/logr/discard.go is excluded by !**/vendor/**, !vendor/**
vendor/github.com/go-logr/logr/funcr/funcr.go is excluded by !**/vendor/**, !vendor/**
vendor/github.com/go-logr/logr/funcr/slogsink.go is excluded by !**/vendor/**, !vendor/**
vendor/github.com/go-logr/logr/logr.go is excluded by !**/vendor/**, !vendor/**
vendor/github.com/go-logr/logr/sloghandler.go is excluded by !**/vendor/**, !vendor/**
vendor/github.com/go-logr/logr/slogr.go is excluded by !**/vendor/**, !vendor/**
vendor/github.com/go-logr/logr/slogr/slogr.go is excluded by !**/vendor/**, !vendor/**
vendor/github.com/go-logr/logr/slogsink.go is excluded by !**/vendor/**, !vendor/**
vendor/github.com/go-logr/zapr/.gitignore is excluded by !**/vendor/**, !vendor/**
vendor/github.com/go-logr/zapr/.golangci.yaml is excluded by !**/vendor/**, !vendor/**
vendor/github.com/go-logr/zapr/LICENSE is excluded by !**/vendor/**, !vendor/**
vendor/github.com/go-logr/zapr/README.md is excluded by !**/vendor/**, !vendor/**
vendor/github.com/go-logr/zapr/slogzapr.go is excluded by !**/vendor/**, !vendor/**
vendor/github.com/go-logr/zapr/zapr.go is excluded by !**/vendor/**, !vendor/**
vendor/github.com/go-logr/zapr/zapr_noslog.go is excluded by !**/vendor/**, !vendor/**
vendor/github.com/go-logr/zapr/zapr_slog.go is excluded by !**/vendor/**, !vendor/**
vendor/github.com/go-openapi/jsonpointer/.editorconfig is excluded by !**/vendor/**, !vendor/**
vendor/github.com/go-openapi/jsonpointer/.gitignore is excluded by !**/vendor/**, !vendor/**
vendor/github.com/go-openapi/jsonpointer/.golangci.yml is excluded by !**/vendor/**, !vendor/**
vendor/github.com/go-openapi/jsonpointer/CODE_OF_CONDUCT.md is excluded by !**/vendor/**, !vendor/**
vendor/github.com/go-openapi/jsonpointer/LICENSE is excluded by !**/vendor/**, !vendor/**
vendor/github.com/go-openapi/jsonpointer/README.md is excluded by !**/vendor/**, !vendor/**
vendor/github.com/go-openapi/jsonpointer/pointer.go is excluded by !**/vendor/**, !vendor/**
vendor/github.com/go-openapi/jsonreference/.gitignore is excluded by !**/vendor/**, !vendor/**
vendor/github.com/go-openapi/jsonreference/.golangci.yml is excluded by !**/vendor/**, !vendor/**
vendor/github.com/go-openapi/jsonreference/CODE_OF_CONDUCT.md is excluded by !**/vendor/**, !vendor/**
vendor/github.com/go-openapi/jsonreference/LICENSE is excluded by !**/vendor/**, !vendor/**
vendor/github.com/go-openapi/jsonreference/README.md is excluded by !**/vendor/**, !vendor/**
vendor/github.com/go-openapi/jsonreference/internal/normalize_url.go is excluded by !**/vendor/**, !vendor/**
vendor/github.com/go-openapi/jsonreference/reference.go is excluded by !**/vendor/**, !vendor/**
vendor/github.com/go-openapi/swag/.editorconfig is excluded by !**/vendor/**, !vendor/**
vendor/github.com/go-openapi/swag/.gitattributes is excluded by !**/vendor/**, !vendor/**
vendor/github.com/go-openapi/swag/.gitignore is excluded by !**/vendor/**, !vendor/**
vendor/github.com/go-openapi/swag/.golangci.yml is excluded by !**/vendor/**, !vendor/**
vendor/github.com/go-openapi/swag/BENCHMARK.md is excluded by !**/vendor/**, !vendor/**
vendor/github.com/go-openapi/swag/CODE_OF_CONDUCT.md is excluded by !**/vendor/**, !vendor/**
vendor/github.com/go-openapi/swag/LICENSE is excluded by !**/vendor/**, !vendor/**
vendor/github.com/go-openapi/swag/README.md is excluded by !**/vendor/**, !vendor/**
vendor/github.com/go-openapi/swag/convert.go is excluded by !**/vendor/**, !vendor/**
vendor/github.com/go-openapi/swag/convert_types.go is excluded by !**/vendor/**, !vendor/**
vendor/github.com/go-openapi/swag/doc.go is excluded by !**/vendor/**, !vendor/**
vendor/github.com/go-openapi/swag/file.go is excluded by !**/vendor/**, !vendor/**
vendor/github.com/go-openapi/swag/initialism_index.go is excluded by !**/vendor/**, !vendor/**
vendor/github.com/go-openapi/swag/json.go is excluded by !**/vendor/**, !vendor/**
vendor/github.com/go-openapi/swag/loading.go is excluded by !**/vendor/**, !vendor/**
vendor/github.com/go-openapi/swag/name_lexem.go is excluded by !**/vendor/**, !vendor/**
vendor/github.com/go-openapi/swag/net.go is excluded by !**/vendor/**, !vendor/**
vendor/github.com/go-openapi/swag/path.go is excluded by !**/vendor/**, !vendor/**
vendor/github.com/go-openapi/swag/split.go is excluded by !**/vendor/**, !vendor/**
vendor/github.com/go-openapi/swag/string_bytes.go is excluded by !**/vendor/**, !vendor/**
vendor/github.com/go-openapi/swag/util.go is excluded by !**/vendor/**, !vendor/**
vendor/github.com/go-openapi/swag/yaml.go is excluded by !**/vendor/**, !vendor/**
vendor/github.com/go-task/slim-sprig/v3/.editorconfig is excluded by !**/vendor/**, !vendor/**
vendor/github.com/go-task/slim-sprig/v3/.gitattributes is excluded by !**/vendor/**, !vendor/**
vendor/github.com/go-task/slim-sprig/v3/.gitignore is excluded by !**/vendor/**, !vendor/**
vendor/github.com/go-task/slim-sprig/v3/CHANGELOG.md is excluded by !**/vendor/**, !vendor/**
vendor/github.com/go-task/slim-sprig/v3/LICENSE.txt is excluded by !**/vendor/**, !vendor/**
vendor/github.com/go-task/slim-sprig/v3/README.md is excluded by !**/vendor/**, !vendor/**
vendor/github.com/go-task/slim-sprig/v3/Taskfile.yml is excluded by !**/vendor/**, !vendor/**
vendor/github.com/go-task/slim-sprig/v3/crypto.go is excluded by !**/vendor/**, !vendor/**
vendor/github.com/go-task/slim-sprig/v3/date.go is excluded by !**/vendor/**, !vendor/**
vendor/github.com/go-task/slim-sprig/v3/defaults.go is excluded by !**/vendor/**, !vendor/**
vendor/github.com/go-task/slim-sprig/v3/dict.go is excluded by !**/vendor/**, !vendor/**
vendor/github.com/go-task/slim-sprig/v3/doc.go is excluded by !**/vendor/**, !vendor/**
vendor/github.com/go-task/slim-sprig/v3/functions.go is excluded by !**/vendor/**, !vendor/**
vendor/github.com/go-task/slim-sprig/v3/list.go is excluded by !**/vendor/**, !vendor/**
vendor/github.com/go-task/slim-sprig/v3/network.go is excluded by !**/vendor/**, !vendor/**
vendor/github.com/go-task/slim-sprig/v3/numeric.go is excluded by !**/vendor/**, !vendor/**
vendor/github.com/go-task/slim-sprig/v3/reflect.go is excluded by !**/vendor/**, !vendor/**
vendor/github.com/go-task/slim-sprig/v3/regex.go is excluded by !**/vendor/**, !vendor/**
vendor/github.com/go-task/slim-sprig/v3/strings.go is excluded by !**/vendor/**, !vendor/**
vendor/github.com/go-task/slim-sprig/v3/url.go is excluded by !**/vendor/**, !vendor/**
vendor/github.com/gogo/protobuf/AUTHORS is excluded by !**/vendor/**, !vendor/**
vendor/github.com/gogo/protobuf/CONTRIBUTORS is excluded by !**/vendor/**, !vendor/**
vendor/github.com/gogo/protobuf/LICENSE is excluded by !**/vendor/**, !vendor/**
vendor/github.com/gogo/protobuf/proto/Makefile is excluded by !**/vendor/**, !vendor/**
vendor/github.com/gogo/protobuf/proto/clone.go is excluded by !**/vendor/**, !vendor/**
vendor/github.com/gogo/protobuf/proto/custom_gogo.go is excluded by !**/vendor/**, !vendor/**
vendor/github.com/gogo/protobuf/proto/decode.go is excluded by !**/vendor/**, !vendor/**
vendor/github.com/gogo/protobuf/proto/deprecated.go is excluded by !**/vendor/**, !vendor/**
vendor/github.com/gogo/protobuf/proto/discard.go is excluded by !**/vendor/**, !vendor/**
vendor/github.com/gogo/protobuf/proto/duration.go is excluded by !**/vendor/**, !vendor/**
vendor/github.com/gogo/protobuf/proto/duration_gogo.go is excluded by !**/vendor/**, !vendor/**
vendor/github.com/gogo/protobuf/proto/encode.go is excluded by !**/vendor/**, !vendor/**
vendor/github.com/gogo/protobuf/proto/encode_gogo.go is excluded by !**/vendor/**, !vendor/**
vendor/github.com/gogo/protobuf/proto/equal.go is excluded by !**/vendor/**, !vendor/**
vendor/github.com/gogo/protobuf/proto/extensions.go is excluded by !**/vendor/**, !vendor/**
vendor/github.com/gogo/protobuf/proto/extensions_gogo.go is excluded by !**/vendor/**, !vendor/**
vendor/github.com/gogo/protobuf/proto/lib.go is excluded by !**/vendor/**, !vendor/**
vendor/github.com/gogo/protobuf/proto/lib_gogo.go is excluded by !**/vendor/**, !vendor/**
vendor/github.com/gogo/protobuf/proto/message_set.go is excluded by !**/vendor/**, !vendor/**
vendor/github.com/gogo/protobuf/proto/pointer_reflect.go is excluded by !**/vendor/**, !vendor/**
vendor/github.com/gogo/protobuf/proto/pointer_reflect_gogo.go is excluded by !**/vendor/**, !vendor/**
vendor/github.com/gogo/protobuf/proto/pointer_unsafe.go is excluded by !**/vendor/**, !vendor/**
vendor/github.com/gogo/protobuf/proto/pointer_unsafe_gogo.go is excluded by !**/vendor/**, !vendor/**
vendor/github.com/gogo/protobuf/proto/properties.go is excluded by !**/vendor/**, !vendor/**
vendor/github.com/gogo/protobuf/proto/properties_gogo.go is excluded by !**/vendor/**, !vendor/**
vendor/github.com/gogo/protobuf/proto/skip_gogo.go is excluded by !**/vendor/**, !vendor/**
vendor/github.com/gogo/protobuf/proto/table_marshal.go is excluded by !**/vendor/**, !vendor/**
vendor/github.com/gogo/protobuf/proto/table_marshal_gogo.go is excluded by !**/vendor/**, !vendor/**
vendor/github.com/gogo/protobuf/proto/table_merge.go is excluded by !**/vendor/**, !vendor/**
vendor/github.com/gogo/protobuf/proto/table_unmarshal.go is excluded by !**/vendor/**, !vendor/**
vendor/github.com/gogo/protobuf/proto/table_unmarshal_gogo.go is excluded by !**/vendor/**, !vendor/**
vendor/github.com/gogo/protobuf/proto/text.go is excluded by !**/vendor/**, !vendor/**
vendor/github.com/gogo/protobuf/proto/text_gogo.go is excluded by !**/vendor/**, !vendor/**
vendor/github.com/gogo/protobuf/proto/text_parser.go is excluded by !**/vendor/**, !vendor/**
vendor/github.com/gogo/protobuf/proto/timestamp.go is excluded by !**/vendor/**, !vendor/**
vendor/github.com/gogo/protobuf/proto/timestamp_gogo.go is excluded by !**/vendor/**, !vendor/**
vendor/github.com/gogo/protobuf/proto/wrappers.go is excluded by !**/vendor/**, !vendor/**
vendor/github.com/gogo/protobuf/proto/wrappers_gogo.go is excluded by !**/vendor/**, !vendor/**
vendor/github.com/gogo/protobuf/sortkeys/sortkeys.go is excluded by !**/vendor/**, !vendor/**
vendor/github.com/golang-jwt/jwt/v4/.gitignore is excluded by !**/vendor/**, !vendor/**
vendor/github.com/golang-jwt/jwt/v4/LICENSE is excluded by !**/vendor/**, !vendor/**
vendor/github.com/golang-jwt/jwt/v4/MIGRATION_GUIDE.md is excluded by !**/vendor/**, !vendor/**
vendor/github.com/golang-jwt/jwt/v4/README.md is excluded by !**/vendor/**, !vendor/**
vendor/github.com/golang-jwt/jwt/v4/SECURITY.md is excluded by !**/vendor/**, !vendor/**
vendor/github.com/golang-jwt/jwt/v4/VERSION_HISTORY.md is excluded by !**/vendor/**, !vendor/**
vendor/github.com/golang-jwt/jwt/v4/claims.go is excluded by !**/vendor/**, !vendor/**
vendor/github.com/golang-jwt/jwt/v4/doc.go is excluded by !**/vendor/**, !vendor/**
vendor/github.com/golang-jwt/jwt/v4/ecdsa.go is excluded by !**/vendor/**, !vendor/**
vendor/github.com/golang-jwt/jwt/v4/ecdsa_utils.go is excluded by !**/vendor/**, !vendor/**
vendor/github.com/golang-jwt/jwt/v4/ed25519.go is excluded by !**/vendor/**, !vendor/**
vendor/github.com/golang-jwt/jwt/v4/ed25519_utils.go is excluded by !**/vendor/**, !vendor/**
vendor/github.com/golang-jwt/jwt/v4/errors.go is excluded by !**/vendor/**, !vendor/**
vendor/github.com/golang-jwt/jwt/v4/hmac.go is excluded by !**/vendor/**, !vendor/**
vendor/github.com/golang-jwt/jwt/v4/map_claims.go is excluded by !**/vendor/**, !vendor/**
vendor/github.com/golang-jwt/jwt/v4/none.go is excluded by !**/vendor/**, !vendor/**
vendor/github.com/golang-jwt/jwt/v4/parser.go is excluded by !**/vendor/**, !vendor/**
vendor/github.com/golang-jwt/jwt/v4/parser_option.go is excluded by !**/vendor/**, !vendor/**
vendor/github.com/golang-jwt/jwt/v4/rsa.go is excluded by !**/vendor/**, !vendor/**
vendor/github.com/golang-jwt/jwt/v4/rsa_pss.go is excluded by !**/vendor/**, !vendor/**
vendor/github.com/golang-jwt/jwt/v4/rsa_utils.go is excluded by !**/vendor/**, !vendor/**
vendor/github.com/golang-jwt/jwt/v4/signing_method.go is excluded by !**/vendor/**, !vendor/**
vendor/github.com/golang-jwt/jwt/v4/staticcheck.conf is excluded by !**/vendor/**, !vendor/**
vendor/github.com/golang-jwt/jwt/v4/token.go is excluded by !**/vendor/**, !vendor/**
vendor/github.com/golang-jwt/jwt/v4/types.go is excluded by !**/vendor/**, !vendor/**

📒 Files selected for processing (2)

controllers/machineset_controller_test.go
go.mod

🚧 Files skipped from review as they are similar to previous changes (1)

controllers/machineset_controller_test.go

openshift-ci · 2026-05-29T15:54:03Z

@sebrandon1: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/coverage	`973dbab`	link	true	`/test coverage`
ci/prow/e2e-binary-build-success	`973dbab`	link	true	`/test e2e-binary-build-success`
ci/prow/validate	`973dbab`	link	true	`/test validate`
ci/prow/test	`973dbab`	link	true	`/test test`
ci/prow/lint	`973dbab`	link	true	`/test lint`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci Bot requested review from rbhilare and tkong-redhat November 14, 2025 15:58

sebrandon1 mentioned this pull request Nov 14, 2025

Tracking Deprecated golang/mock Usage redhat-best-practices-for-k8s/telco-bot#45

Open

openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 19, 2025

sebrandon1 force-pushed the mockgen_deprecation branch from b315a55 to 12c7562 Compare November 21, 2025 16:42

openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 21, 2025

sebrandon1 force-pushed the mockgen_deprecation branch from 12c7562 to fbbe9a4 Compare January 16, 2026 17:35

sebrandon1 force-pushed the mockgen_deprecation branch from 3c693d9 to e0e7a9a Compare January 28, 2026 20:24

sebrandon1 force-pushed the mockgen_deprecation branch from e0e7a9a to 67171a4 Compare February 18, 2026 15:20

sebrandon1 force-pushed the mockgen_deprecation branch from 67171a4 to 21bf24b Compare February 27, 2026 20:57

sebrandon1 force-pushed the mockgen_deprecation branch from 21bf24b to 922f4dd Compare March 20, 2026 19:44

sebrandon1 force-pushed the mockgen_deprecation branch from 922f4dd to c90eb57 Compare April 30, 2026 19:01

sebrandon1 changed the title ~~mockgen deprecated: use uber-go/mock instead~~ CNF-23391: mockgen deprecated: use uber-go/mock instead Apr 30, 2026

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 30, 2026

sebrandon1 force-pushed the mockgen_deprecation branch from c90eb57 to 499e9a3 Compare May 5, 2026 22:35

sebrandon1 force-pushed the mockgen_deprecation branch from 499e9a3 to db5a001 Compare May 20, 2026 15:25

mockgen deprecated: use uber-go/mock instead

973dbab

sebrandon1 force-pushed the mockgen_deprecation branch from db5a001 to 973dbab Compare May 29, 2026 15:09

coderabbitai Bot reviewed May 29, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

CNF-23391: mockgen deprecated: use uber-go/mock instead#197

CNF-23391: mockgen deprecated: use uber-go/mock instead#197
sebrandon1 wants to merge 1 commit into
openshift:mainfrom
sebrandon1:mockgen_deprecation

sebrandon1 commented Nov 14, 2025 •

edited by coderabbitai Bot

Loading

Uh oh!

codecov-commenter commented Nov 14, 2025 •

edited

Loading

Uh oh!

sebrandon1 commented Jan 29, 2026

Uh oh!

coderabbitai Bot commented Apr 30, 2026 •

edited

Loading

❌ Failed checks (1 warning)

Uh oh!

openshift-ci-robot commented Apr 30, 2026 •

edited by atlassian Bot

Loading

Summary by CodeRabbit

Uh oh!

sebrandon1 commented May 20, 2026

Uh oh!

openshift-ci Bot commented May 20, 2026

Uh oh!

coderabbitai Bot left a comment

Uh oh!

openshift-ci Bot commented May 29, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

sebrandon1 commented Nov 14, 2025 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

codecov-commenter commented Nov 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

sebrandon1 commented Jan 29, 2026

Uh oh!

coderabbitai Bot commented Apr 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

❌ Failed checks (1 warning)

Uh oh!

openshift-ci-robot commented Apr 30, 2026 • edited by atlassian Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

sebrandon1 commented May 20, 2026

Uh oh!

openshift-ci Bot commented May 20, 2026

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

openshift-ci Bot commented May 29, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

sebrandon1 commented Nov 14, 2025 •

edited by coderabbitai Bot

Loading

codecov-commenter commented Nov 14, 2025 •

edited

Loading

coderabbitai Bot commented Apr 30, 2026 •

edited

Loading

openshift-ci-robot commented Apr 30, 2026 •

edited by atlassian Bot

Loading