Skip to content

Fix flaky TestStaleAnnotationClearedOnLayerOnlyChange#5995

Open
dkhater-redhat wants to merge 1 commit into
openshift:mainfrom
dkhater-redhat:fix-flaky-stale-annotation-test
Open

Fix flaky TestStaleAnnotationClearedOnLayerOnlyChange#5995
dkhater-redhat wants to merge 1 commit into
openshift:mainfrom
dkhater-redhat:fix-flaky-stale-annotation-test

Conversation

@dkhater-redhat
Copy link
Copy Markdown
Contributor

Move node labeling to after initial pool update check. The test was timing out because it labeled a node before creating the pool, causing the pool to wait for node update (10-20min) but timeout was only 10min.

Now pool starts empty, reaches Updated=True quickly (2min), then node is added when actually needed for stale annotation testing.

Reduces timeout flakiness from ~50% failure to expected 0%.

- What I did

- How to verify it

- Description for the changelog

Move node labeling to after initial pool update check. The test was
timing out because it labeled a node before creating the pool, causing
the pool to wait for node update (10-20min) but timeout was only 10min.

Now pool starts empty, reaches Updated=True quickly (2min), then node
is added when actually needed for stale annotation testing.

Reduces timeout flakiness from ~50% failure to expected 0%.
@openshift-merge-bot
Copy link
Copy Markdown
Contributor

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 4, 2026

Warning

Rate limit exceeded

@dkhater-redhat has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 27 minutes and 6 seconds before requesting another review.

To keep reviews running without waiting, you can enable usage-based add-on for your organization. This allows additional reviews beyond the hourly cap. Account admins can enable it under billing.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: f06da841-d5e4-462a-b19b-059471df72c0

📥 Commits

Reviewing files that changed from the base of the PR and between a7a332d and 02b3a83.

📒 Files selected for processing (1)
  • test/e2e-ocl-2of2/onclusterlayering_test.go
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci Bot requested review from cheesesashimi and yuqi-zhang May 4, 2026 21:08
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 4, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dkhater-redhat

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 4, 2026
@dkhater-redhat
Copy link
Copy Markdown
Contributor Author

/test ci/prow/e2e-gcp-op-ocl-part1

@dkhater-redhat
Copy link
Copy Markdown
Contributor Author

/test e2e-gcp-op-ocl-part2

1 similar comment
@dkhater-redhat
Copy link
Copy Markdown
Contributor Author

/test e2e-gcp-op-ocl-part2

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 5, 2026

@dkhater-redhat: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-op-ocl-part1 02b3a83 link true /test e2e-gcp-op-ocl-part1
ci/prow/e2e-gcp-op-ocl-part2 02b3a83 link true /test e2e-gcp-op-ocl-part2

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant