Fix flaky TestStaleAnnotationClearedOnLayerOnlyChange#5995
Fix flaky TestStaleAnnotationClearedOnLayerOnlyChange#5995dkhater-redhat wants to merge 1 commit into
Conversation
Move node labeling to after initial pool update check. The test was timing out because it labeled a node before creating the pool, causing the pool to wait for node update (10-20min) but timeout was only 10min. Now pool starts empty, reaches Updated=True quickly (2min), then node is added when actually needed for stale annotation testing. Reduces timeout flakiness from ~50% failure to expected 0%.
|
Pipeline controller notification For optional jobs, comment This repository is configured in: LGTM mode |
|
Warning Rate limit exceeded
To keep reviews running without waiting, you can enable usage-based add-on for your organization. This allows additional reviews beyond the hourly cap. Account admins can enable it under billing. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Repository: openshift/coderabbit/.coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dkhater-redhat The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test ci/prow/e2e-gcp-op-ocl-part1 |
|
/test e2e-gcp-op-ocl-part2 |
1 similar comment
|
/test e2e-gcp-op-ocl-part2 |
|
@dkhater-redhat: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Move node labeling to after initial pool update check. The test was timing out because it labeled a node before creating the pool, causing the pool to wait for node update (10-20min) but timeout was only 10min.
Now pool starts empty, reaches Updated=True quickly (2min), then node is added when actually needed for stale annotation testing.
Reduces timeout flakiness from ~50% failure to expected 0%.
- What I did
- How to verify it
- Description for the changelog