Skip to content

NO-JIRA: bump openshift/client-go #5500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
sanchezl wants to merge 3 commits into
base: main
Choose a base branch
from
Open

NO-JIRA: bump openshift/client-go #5500

sanchezl wants to merge 3 commits into from
+12,510 −7,372

Conversation

@sanchezl
Copy link
Contributor

@sanchezl sanchezl commented Dec 15, 2025 •
edited
Loading

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Dec 15, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Dec 15, 2025

@sanchezl: This pull request explicitly references no jira issue.

Details

In response to this:

  • proof: temp deps
  • proof: update vendor
  • proof: update references

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 15, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 15, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@sanchezl sanchezl mentioned this pull request Dec 16, 2025
Merged
@sanchezl sanchezl changed the title NO-JIRA: bump NO-JIRA: openshift/client-go Dec 16, 2025
@sanchezl
Copy link
Contributor Author

sanchezl commented Dec 16, 2025

/hold for openshift/client-go#354

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 16, 2025
@sanchezl sanchezl changed the title NO-JIRA: openshift/client-go NO-JIRA: bump openshift/client-go Dec 16, 2025
@sanchezl sanchezl marked this pull request as ready for review December 16, 2025 15:13
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 16, 2025
@sanchezl sanchezl force-pushed the cluster-image-policy-rename branch 4 times, most recently from 11e7245 to b9fa75f Compare December 17, 2025 21:48
@sanchezl sanchezl force-pushed the cluster-image-policy-rename branch from b9fa75f to 5804f34 Compare January 7, 2026 15:28
This was referenced Jan 7, 2026
Open
Merged
@sanchezl sanchezl force-pushed the cluster-image-policy-rename branch from 5804f34 to df949af Compare January 9, 2026 05:33
@sanchezl
Copy link
Contributor Author

sanchezl commented Jan 9, 2026

@QiWang19 I am having trouble with the bootstrap-unit tests. Please advise.

@sanchezl
Copy link
Contributor Author

sanchezl commented Jan 9, 2026

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 9, 2026
isabella-janssen
isabella-janssen reviewed Jan 9, 2026
View reviewed changes
Copy link
Member

@isabella-janssen isabella-janssen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Clear version bump & tests look to be passing as expected.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 9, 2026
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 9, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: isabella-janssen, sanchezl

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 9, 2026
@isabella-janssen
Copy link
Member

isabella-janssen commented Jan 9, 2026

/verified bypass

No verification needed beyond presubmits passing.

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Jan 9, 2026
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 9, 2026

@isabella-janssen: The verified label has been added.

Details

In response to this:

/verified bypass

No verification needed beyond presubmits passing.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 9, 2026

/retest-required

Remaining retests: 0 against base HEAD 718463b and 2 for PR HEAD df949af in total

@sanchezl
Copy link
Contributor Author

sanchezl commented Jan 9, 2026

FYI openshift/origin#30659 bumps the tests in origin

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 9, 2026

@sanchezl: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-hypershift df949af link true /test e2e-hypershift
ci/prow/bootstrap-unit df949af link false /test bootstrap-unit

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dkhater-redhat dkhater-redhat Awaiting requested review from dkhater-redhat

@QiWang19 QiWang19 Awaiting requested review from QiWang19

1 more reviewer

@isabella-janssen isabella-janssen isabella-janssen left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@isabella-janssen isabella-janssen

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sanchezl @openshift-ci-robot @isabella-janssen