-
Notifications
You must be signed in to change notification settings - Fork 462
NO-JIRA: kubelet: drop pod-infra-container-image usage #5460
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Peter Hunt <pehunt@redhat.com>
|
Should we wait for 4.22 to branch this friday or should we get this in to 4.21 ahead of the kube update |
|
we can wait till branch I think |
|
/approve |
|
Would you like to attach a Jira @haircommander or should we just NO-JIRA this in? |
|
@haircommander: This pull request explicitly references no jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
I think NO-JIRA works for this |
|
/retest-required |
isabella-janssen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
This looks like a fair change based on the conversation here.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: haircommander, isabella-janssen, yuqi-zhang The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest-required |
1 similar comment
|
/retest-required |
|
/verified by @jacobsee |
|
@jacobsee: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@haircommander: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/retest-required |
1 similar comment
|
/retest-required |
|
/override ci/prow/okd-scos-images |
|
@sdodson: Overrode contexts on behalf of sdodson: ci/prow/okd-scos-images DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
- What I did
- How to verify it
- Description for the changelog