-
Notifications
You must be signed in to change notification settings - Fork 231
SPLAT-2582: Updated IPAM references to use v1beta2 #1445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
@vr4manta: This pull request references SPLAT-2582 which is a valid jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
1 similar comment
|
@vr4manta: This pull request references SPLAT-2582 which is a valid jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/payload-job periodic-ci-openshift-release-master-nightly-4.21-e2e-vsphere-static-ovn |
|
@vr4manta: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/91dca1f0-d460-11f0-9d86-f7e380d1078d-0 |
|
@vr4manta: This pull request references SPLAT-2582 which is a valid jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Not sure why the |
|
/test unit |
|
/hold We are working on a different fix, will keep you posted |
|
cc. @mdbooth |
|
/retest |
1 similar comment
|
/retest |
|
@vr4manta: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
Taking a deeper look at unit test issues |
SPLAT-2582
Changes
Notes
This is not a must have, but after recent bumps, we are getting a lot of warning messages about using the deprecated v1beta1 APIs.
After this change happens, installer will also need to be updated to generate IPAM v1beta2 versions of IPAddress and IPAddressClaims for vSphere static IP.
Currently vSphere static IP periodicals for 4.21+ are failing due to crd changes. Once those are fixed, this PR should have the static IP jobs pass with no warning messages for IPAddressClaims.