Skip to content

OLS-3059: Extract GET /health liveness endpoint#47

Open
onmete wants to merge 1 commit into
openshift:mainfrom
onmete:ols-3059-health-endpoint
Open

OLS-3059: Extract GET /health liveness endpoint#47
onmete wants to merge 1 commit into
openshift:mainfrom
onmete:ols-3059-health-endpoint

Conversation

@onmete
Copy link
Copy Markdown
Contributor

@onmete onmete commented May 20, 2026 •
edited by openshift-ci Bot
Loading

Summary

  • Extract GET /health liveness into health.py (register_health_routes) for a clear home ahead of OLS-3060 /ready
  • Add unit tests for the health payload and route
  • Update spec cross-references (provider-architecture.md, configuration.md, run-api.md)

Keeps /health as the canonical liveness path per health-probes.md (no /liveness rename).

Related

Test plan

  • make test
  • make lint

Made with Cursor

@onmete @cursoragent
Extract GET /health liveness into health module (OLS-3059)
ab90641 
Move the liveness handler into health.py with unit tests. Keeps
/health as the canonical path per health-probes.md; /ready follows
in OLS-3060.

Co-authored-by: Cursor <cursoragent@cursor.com>
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 20, 2026
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented May 20, 2026 •
edited by openshift-ci Bot
Loading

@onmete: This pull request references OLS-3059 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set.

Details

In response to this:

Summary

  • Extract GET /health liveness into health.py (register_health_routes) for a clear home ahead of OLS-3060 /ready
  • Add unit tests for the health payload and route
  • Update spec cross-references (provider-architecture.md, configuration.md, run-api.md)

Keeps /health as the canonical liveness path per health-probes.md (no /liveness rename).

Related

Test plan

  • make test
  • make lint

Made with Cursor

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci Bot requested review from blublinsky and xrajesh May 20, 2026 12:25
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented May 20, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign blublinsky for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@onmete onmete mentioned this pull request May 20, 2026
Open
2 tasks
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented May 21, 2026

@onmete: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@blublinsky blublinsky Awaiting requested review from blublinsky

@xrajesh xrajesh Awaiting requested review from xrajesh

Assignees

No one assigned

Labels

jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@onmete @openshift-ci-robot