Skip to content

OCPSTRAT-2713: Bump ignition from 3.2 to 3.6#10392

Open
fangge1212 wants to merge 1 commit intoopenshift:mainfrom
fangge1212:ignition-3.6-bump
Open

OCPSTRAT-2713: Bump ignition from 3.2 to 3.6#10392
fangge1212 wants to merge 1 commit intoopenshift:mainfrom
fangge1212:ignition-3.6-bump

Conversation

@fangge1212
Copy link
Contributor

The latest ignition contains the API addtion to deploy confidential clusters.

@coderabbitai
Copy link

coderabbitai bot commented Mar 16, 2026

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

  • ▶️ Resume reviews
  • 🔍 Trigger review

Walkthrough

Updated dependency versions in go.mod and replaced Ignition imports across the codebase from github.com/coreos/ignition/v2/config/v3_2/types to github.com/coreos/ignition/v2/config/v3_6/types, adjusted parsing usage where applicable, and updated test expected Ignition versions from 3.2.0 to 3.6.0.

Changes

Cohort / File(s) Summary
Dependency Management
go.mod
Bumped many modules (Google Cloud, Azure SDKs, CoreOS Ignition, google.golang.org/, golang.org/x/, OpenTelemetry, Envoy/XDS, gRPC, genproto, protobuf, and other indirects). No go directive or replace edits.
Agent assets
pkg/asset/agent/image/ignition.go, pkg/asset/agent/image/ignition_test.go, pkg/asset/agent/image/unconfigured_ignition.go, pkg/asset/agent/joiner/clusterinfo.go, pkg/asset/agent/joiner/clusterinfo_test.go
Switched Ignition import alias from v3_2 → v3_6; tests updated (embedded ignition.version and types).
Cluster / bootstrap ignition
pkg/asset/cluster/tfvars/tfvars.go, pkg/asset/ignition/bootstrap/ibmcloud/storage.go, pkg/asset/ignition/bootstrap/bootstrap_ignition.go, pkg/asset/ignition/bootstrap/bootstrap_ignition_test.go, pkg/asset/ignition/bootstrap/common.go
Ignition types upgraded to v3_6; usages updated and tests adjusted where applicable.
Machine assets
pkg/asset/ignition/machine/arbiter.go, pkg/asset/ignition/machine/arbiter_ignition_customizations_test.go, pkg/asset/ignition/machine/master.go, pkg/asset/ignition/machine/node.go, pkg/asset/ignition/machine/worker.go, pkg/asset/machines/machineconfig/...
All Ignition types imports moved to v3_6; several public struct fields referencing igntypes.Config now point to v3_6 types; tests and helpers updated accordingly.
Image-based ignition
pkg/asset/imagebased/image/ignition.go, pkg/asset/imagebased/image/ignition_test.go
Switched parsing/imports from v3_2 → v3_6 and changed parse call to v3_6-compatible API; tests updated.
MachineConfig-related files
pkg/asset/machines/machineconfig/authorizedkeys.go, chrony.go, disks.go, disks_test.go, fips.go, hyperthreading.go, ipv6.go, multipath.go, powersmt.go, routes.go
Ignition types imports updated to v3_6; construction and conversion of Ignition objects unchanged aside from type source; tests adjusted where applicable.
Infrastructure providers
pkg/infrastructure/baremetal/bootstrap.go, pkg/infrastructure/clusterapi/helpers.go, pkg/infrastructure/clusterapi/ignition.go, pkg/infrastructure/openstack/preprovision/bootstrapignition.go
Ignition types imports updated to v3_6 across infra providers; logic unchanged aside from type package.
Bootstrap / node assets
pkg/asset/ignition/bootstrap/..., pkg/asset/ignition/node.go
Ignition types import changed to v3_6 in bootstrap and node-related files; tests adjusted for version strings.
Other helpers / types
pkg/types/nutanix/helpers.go
Ignition types import changed to v3_6 in Nutanix helper functions.
Tests: expected ignition versions
pkg/asset/machines/arbiter_test.go, pkg/asset/machines/master_test.go, pkg/asset/machines/worker_test.go, various *_test.go`
Updated expected ignition.version strings from 3.2.0 to 3.6.0 in test fixtures and expected outputs.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci bot requested review from andfasano and eranco74 March 16, 2026 07:09
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 16, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign bfournie for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fangge1212 fangge1212 force-pushed the ignition-3.6-bump branch 2 times, most recently from e046b7a to b7c3925 Compare March 16, 2026 08:15
@fangge1212 fangge1212 marked this pull request as draft March 17, 2026 10:55
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 17, 2026
@fangge1212 fangge1212 force-pushed the ignition-3.6-bump branch 2 times, most recently from d078874 to 0889fd9 Compare March 20, 2026 09:03
@fangge1212 fangge1212 changed the title Bump ignition from 3.2 to 3.6 OCPSTRAT-2713: Bump ignition from 3.2 to 3.6 Mar 20, 2026
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Mar 20, 2026

@fangge1212: This pull request references OCPSTRAT-2713 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the feature to target either version "4.22." or "openshift-4.22.", but it targets "openshift-5.0" instead.

Details

In response to this:

The latest ignition contains the API addtion to deploy confidential clusters.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 20, 2026
@rna-afk
Copy link
Contributor

rna-afk commented Mar 20, 2026

Might want to run these tests. I'm thinking moving the draft state to open will trigger it. Ready if you are.

@fangge1212 fangge1212 marked this pull request as ready for review March 23, 2026 01:21
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 23, 2026
@openshift-ci openshift-ci bot requested a review from dtantsur March 23, 2026 01:22
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@go.mod`:
- Line 114: Update the grpc dependency in go.mod by replacing the pinned version
"google.golang.org/grpc v1.78.0" with "google.golang.org/grpc v1.79.3" (or any
later patch >= v1.79.3) to address the GHSA-p77j-4mvh-x3m3 vulnerability; after
changing the version, run the module tooling (e.g., go get
google.golang.org/grpc@v1.79.3 and go mod tidy) to update go.sum and ensure the
build uses the new version.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 24371491-1d7d-4df6-babc-dce6748c4d7d

📥 Commits

Reviewing files that changed from the base of the PR and between b7c3925 and 0889fd9.

⛔ Files ignored due to path filters (263)
  • go.sum is excluded by !**/*.sum
  • vendor/cloud.google.com/go/.release-please-manifest-individual.json is excluded by !vendor/**, !**/vendor/**
  • vendor/cloud.google.com/go/.release-please-manifest-submodules.json is excluded by !vendor/**, !**/vendor/**
  • vendor/cloud.google.com/go/.release-please-manifest.json is excluded by !vendor/**, !**/vendor/**
  • vendor/cloud.google.com/go/CHANGES.md is excluded by !vendor/**, !**/vendor/**
  • vendor/cloud.google.com/go/README.md is excluded by !vendor/**, !**/vendor/**
  • vendor/cloud.google.com/go/auth/CHANGES.md is excluded by !vendor/**, !**/vendor/**
  • vendor/cloud.google.com/go/auth/credentials/detect.go is excluded by !vendor/**, !**/vendor/**
  • vendor/cloud.google.com/go/auth/credentials/filetypes.go is excluded by !vendor/**, !**/vendor/**
  • vendor/cloud.google.com/go/auth/internal/credsfile/credsfile.go is excluded by !vendor/**, !**/vendor/**
  • vendor/cloud.google.com/go/auth/internal/credsfile/filetype.go is excluded by !vendor/**, !**/vendor/**
  • vendor/cloud.google.com/go/auth/internal/credsfile/parse.go is excluded by !vendor/**, !**/vendor/**
  • vendor/cloud.google.com/go/auth/internal/internal.go is excluded by !vendor/**, !**/vendor/**
  • vendor/cloud.google.com/go/auth/internal/version.go is excluded by !vendor/**, !**/vendor/**
  • vendor/cloud.google.com/go/go.work is excluded by !**/*.work, !vendor/**, !**/vendor/**
  • vendor/cloud.google.com/go/go.work.sum is excluded by !**/*.sum, !vendor/**, !**/vendor/**
  • vendor/cloud.google.com/go/internal/.repo-metadata-full.json is excluded by !vendor/**, !**/vendor/**
  • vendor/cloud.google.com/go/kms/apiv1/autokey_admin_client.go is excluded by !vendor/**, !**/vendor/**
  • vendor/cloud.google.com/go/kms/apiv1/autokey_client.go is excluded by !vendor/**, !**/vendor/**
  • vendor/cloud.google.com/go/kms/apiv1/ekm_client.go is excluded by !vendor/**, !**/vendor/**
  • vendor/cloud.google.com/go/kms/apiv1/gapic_metadata.json is excluded by !vendor/**, !**/vendor/**
  • vendor/cloud.google.com/go/kms/apiv1/key_management_client.go is excluded by !vendor/**, !**/vendor/**
  • vendor/cloud.google.com/go/kms/apiv1/kmspb/autokey.pb.go is excluded by !**/*.pb.go, !vendor/**, !**/vendor/**
  • vendor/cloud.google.com/go/kms/apiv1/kmspb/autokey_admin.pb.go is excluded by !**/*.pb.go, !vendor/**, !**/vendor/**
  • vendor/cloud.google.com/go/kms/apiv1/kmspb/autokey_admin_grpc.pb.go is excluded by !**/*.pb.go, !vendor/**, !**/vendor/**
  • vendor/cloud.google.com/go/kms/apiv1/kmspb/autokey_grpc.pb.go is excluded by !**/*.pb.go, !vendor/**, !**/vendor/**
  • vendor/cloud.google.com/go/kms/apiv1/kmspb/ekm_service.pb.go is excluded by !**/*.pb.go, !vendor/**, !**/vendor/**
  • vendor/cloud.google.com/go/kms/apiv1/kmspb/ekm_service_grpc.pb.go is excluded by !**/*.pb.go, !vendor/**, !**/vendor/**
  • vendor/cloud.google.com/go/kms/apiv1/kmspb/resources.pb.go is excluded by !**/*.pb.go, !vendor/**, !**/vendor/**
  • vendor/cloud.google.com/go/kms/apiv1/kmspb/service.pb.go is excluded by !**/*.pb.go, !vendor/**, !**/vendor/**
  • vendor/cloud.google.com/go/kms/apiv1/kmspb/service_grpc.pb.go is excluded by !**/*.pb.go, !vendor/**, !**/vendor/**
  • vendor/cloud.google.com/go/kms/internal/version.go is excluded by !vendor/**, !**/vendor/**
  • vendor/cloud.google.com/go/longrunning/CHANGES.md is excluded by !vendor/**, !**/vendor/**
  • vendor/cloud.google.com/go/longrunning/autogen/helpers.go is excluded by !vendor/**, !**/vendor/**
  • vendor/cloud.google.com/go/longrunning/autogen/longrunningpb/operations.pb.go is excluded by !**/*.pb.go, !vendor/**, !**/vendor/**
  • vendor/cloud.google.com/go/longrunning/autogen/operations_client.go is excluded by !vendor/**, !**/vendor/**
  • vendor/cloud.google.com/go/monitoring/apiv3/v2/alert_policy_client.go is excluded by !vendor/**, !**/vendor/**
  • vendor/cloud.google.com/go/monitoring/apiv3/v2/group_client.go is excluded by !vendor/**, !**/vendor/**
  • vendor/cloud.google.com/go/monitoring/apiv3/v2/helpers.go is excluded by !vendor/**, !**/vendor/**
  • vendor/cloud.google.com/go/monitoring/apiv3/v2/metric_client.go is excluded by !vendor/**, !**/vendor/**
  • vendor/cloud.google.com/go/monitoring/apiv3/v2/monitoringpb/alert.pb.go is excluded by !**/*.pb.go, !vendor/**, !**/vendor/**
  • vendor/cloud.google.com/go/monitoring/apiv3/v2/monitoringpb/alert_service.pb.go is excluded by !**/*.pb.go, !vendor/**, !**/vendor/**
  • vendor/cloud.google.com/go/monitoring/apiv3/v2/monitoringpb/alert_service_grpc.pb.go is excluded by !**/*.pb.go, !vendor/**, !**/vendor/**
  • vendor/cloud.google.com/go/monitoring/apiv3/v2/monitoringpb/common.pb.go is excluded by !**/*.pb.go, !vendor/**, !**/vendor/**
  • vendor/cloud.google.com/go/monitoring/apiv3/v2/monitoringpb/dropped_labels.pb.go is excluded by !**/*.pb.go, !vendor/**, !**/vendor/**
  • vendor/cloud.google.com/go/monitoring/apiv3/v2/monitoringpb/group.pb.go is excluded by !**/*.pb.go, !vendor/**, !**/vendor/**
  • vendor/cloud.google.com/go/monitoring/apiv3/v2/monitoringpb/group_service.pb.go is excluded by !**/*.pb.go, !vendor/**, !**/vendor/**
  • vendor/cloud.google.com/go/monitoring/apiv3/v2/monitoringpb/group_service_grpc.pb.go is excluded by !**/*.pb.go, !vendor/**, !**/vendor/**
  • vendor/cloud.google.com/go/monitoring/apiv3/v2/monitoringpb/metric.pb.go is excluded by !**/*.pb.go, !vendor/**, !**/vendor/**
  • vendor/cloud.google.com/go/monitoring/apiv3/v2/monitoringpb/metric_service.pb.go is excluded by !**/*.pb.go, !vendor/**, !**/vendor/**
  • vendor/cloud.google.com/go/monitoring/apiv3/v2/monitoringpb/metric_service_grpc.pb.go is excluded by !**/*.pb.go, !vendor/**, !**/vendor/**
  • vendor/cloud.google.com/go/monitoring/apiv3/v2/monitoringpb/mutation_record.pb.go is excluded by !**/*.pb.go, !vendor/**, !**/vendor/**
  • vendor/cloud.google.com/go/monitoring/apiv3/v2/monitoringpb/notification.pb.go is excluded by !**/*.pb.go, !vendor/**, !**/vendor/**
  • vendor/cloud.google.com/go/monitoring/apiv3/v2/monitoringpb/notification_service.pb.go is excluded by !**/*.pb.go, !vendor/**, !**/vendor/**
  • vendor/cloud.google.com/go/monitoring/apiv3/v2/monitoringpb/notification_service_grpc.pb.go is excluded by !**/*.pb.go, !vendor/**, !**/vendor/**
  • vendor/cloud.google.com/go/monitoring/apiv3/v2/monitoringpb/query_service.pb.go is excluded by !**/*.pb.go, !vendor/**, !**/vendor/**
  • vendor/cloud.google.com/go/monitoring/apiv3/v2/monitoringpb/query_service_grpc.pb.go is excluded by !**/*.pb.go, !vendor/**, !**/vendor/**
  • vendor/cloud.google.com/go/monitoring/apiv3/v2/monitoringpb/service.pb.go is excluded by !**/*.pb.go, !vendor/**, !**/vendor/**
  • vendor/cloud.google.com/go/monitoring/apiv3/v2/monitoringpb/service_service.pb.go is excluded by !**/*.pb.go, !vendor/**, !**/vendor/**
  • vendor/cloud.google.com/go/monitoring/apiv3/v2/monitoringpb/service_service_grpc.pb.go is excluded by !**/*.pb.go, !vendor/**, !**/vendor/**
  • vendor/cloud.google.com/go/monitoring/apiv3/v2/monitoringpb/snooze.pb.go is excluded by !**/*.pb.go, !vendor/**, !**/vendor/**
  • vendor/cloud.google.com/go/monitoring/apiv3/v2/monitoringpb/snooze_service.pb.go is excluded by !**/*.pb.go, !vendor/**, !**/vendor/**
  • vendor/cloud.google.com/go/monitoring/apiv3/v2/monitoringpb/snooze_service_grpc.pb.go is excluded by !**/*.pb.go, !vendor/**, !**/vendor/**
  • vendor/cloud.google.com/go/monitoring/apiv3/v2/monitoringpb/span_context.pb.go is excluded by !**/*.pb.go, !vendor/**, !**/vendor/**
  • vendor/cloud.google.com/go/monitoring/apiv3/v2/monitoringpb/uptime.pb.go is excluded by !**/*.pb.go, !vendor/**, !**/vendor/**
  • vendor/cloud.google.com/go/monitoring/apiv3/v2/monitoringpb/uptime_service.pb.go is excluded by !**/*.pb.go, !vendor/**, !**/vendor/**
  • vendor/cloud.google.com/go/monitoring/apiv3/v2/monitoringpb/uptime_service_grpc.pb.go is excluded by !**/*.pb.go, !vendor/**, !**/vendor/**
  • vendor/cloud.google.com/go/monitoring/apiv3/v2/notification_channel_client.go is excluded by !vendor/**, !**/vendor/**
  • vendor/cloud.google.com/go/monitoring/apiv3/v2/query_client.go is excluded by !vendor/**, !**/vendor/**
  • vendor/cloud.google.com/go/monitoring/apiv3/v2/service_monitoring_client.go is excluded by !vendor/**, !**/vendor/**
  • vendor/cloud.google.com/go/monitoring/apiv3/v2/snooze_client.go is excluded by !vendor/**, !**/vendor/**
  • vendor/cloud.google.com/go/monitoring/apiv3/v2/uptime_check_client.go is excluded by !vendor/**, !**/vendor/**
  • vendor/cloud.google.com/go/monitoring/internal/version.go is excluded by !vendor/**, !**/vendor/**
  • vendor/cloud.google.com/go/release-please-config-individual.json is excluded by !vendor/**, !**/vendor/**
  • vendor/cloud.google.com/go/release-please-config-yoshi-submodules.json is excluded by !vendor/**, !**/vendor/**
  • vendor/cloud.google.com/go/storage/.repo-metadata.json is excluded by !vendor/**, !**/vendor/**
  • vendor/cloud.google.com/go/storage/CHANGES.md is excluded by !vendor/**, !**/vendor/**
  • vendor/cloud.google.com/go/storage/bucket.go is excluded by !vendor/**, !**/vendor/**
  • vendor/cloud.google.com/go/storage/client.go is excluded by !vendor/**, !**/vendor/**
  • vendor/cloud.google.com/go/storage/contexts.go is excluded by !vendor/**, !**/vendor/**
  • vendor/cloud.google.com/go/storage/copy.go is excluded by !vendor/**, !**/vendor/**
  • vendor/cloud.google.com/go/storage/doc.go is excluded by !vendor/**, !**/vendor/**
  • vendor/cloud.google.com/go/storage/emulator_test.sh is excluded by !vendor/**, !**/vendor/**
  • vendor/cloud.google.com/go/storage/grpc_client.go is excluded by !vendor/**, !**/vendor/**
  • vendor/cloud.google.com/go/storage/grpc_reader.go is excluded by !vendor/**, !**/vendor/**
  • vendor/cloud.google.com/go/storage/grpc_reader_multi_range.go is excluded by !vendor/**, !**/vendor/**
  • vendor/cloud.google.com/go/storage/grpc_writer.go is excluded by !vendor/**, !**/vendor/**
  • vendor/cloud.google.com/go/storage/http_client.go is excluded by !vendor/**, !**/vendor/**
  • vendor/cloud.google.com/go/storage/internal/apiv2/.repo-metadata.json is excluded by !vendor/**, !**/vendor/**
  • vendor/cloud.google.com/go/storage/internal/apiv2/storage_client.go is excluded by !vendor/**, !**/vendor/**
  • vendor/cloud.google.com/go/storage/internal/apiv2/storagepb/storage.pb.go is excluded by !**/*.pb.go, !vendor/**, !**/vendor/**
  • vendor/cloud.google.com/go/storage/internal/apiv2/storagepb/storage_grpc.pb.go is excluded by !**/*.pb.go, !vendor/**, !**/vendor/**
  • vendor/cloud.google.com/go/storage/internal/version.go is excluded by !vendor/**, !**/vendor/**
  • vendor/cloud.google.com/go/storage/pcu.go is excluded by !vendor/**, !**/vendor/**
  • vendor/cloud.google.com/go/storage/reader.go is excluded by !vendor/**, !**/vendor/**
  • vendor/cloud.google.com/go/storage/storage.go is excluded by !vendor/**, !**/vendor/**
  • vendor/cloud.google.com/go/storage/writer.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/Azure/azure-sdk-for-go/sdk/azcore/CHANGELOG.md is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/Azure/azure-sdk-for-go/sdk/azcore/arm/internal/resource/resource_identifier.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/Azure/azure-sdk-for-go/sdk/azcore/internal/exported/exported.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/Azure/azure-sdk-for-go/sdk/azcore/internal/shared/constants.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/Azure/azure-sdk-for-go/sdk/azcore/runtime/pager.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/Azure/azure-sdk-for-go/sdk/azidentity/CHANGELOG.md is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/Azure/azure-sdk-for-go/sdk/azidentity/developer_credential_util.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/Azure/azure-sdk-for-go/sdk/azidentity/developer_credential_util_nonwindows.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/Azure/azure-sdk-for-go/sdk/azidentity/developer_credential_util_windows.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/Azure/azure-sdk-for-go/sdk/azidentity/version.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/Azure/azure-sdk-for-go/sdk/storage/azblob/CHANGELOG.md is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/Azure/azure-sdk-for-go/sdk/storage/azblob/internal/exported/version.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/AzureAD/microsoft-authentication-library-for-go/apps/confidential/confidential.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/AzureAD/microsoft-authentication-library-for-go/apps/internal/base/base.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/AzureAD/microsoft-authentication-library-for-go/apps/internal/base/storage/items.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/AzureAD/microsoft-authentication-library-for-go/apps/internal/base/storage/storage.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/AzureAD/microsoft-authentication-library-for-go/apps/internal/oauth/ops/accesstokens/accesstokens.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/AzureAD/microsoft-authentication-library-for-go/apps/internal/oauth/ops/authority/authority.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/AzureAD/microsoft-authentication-library-for-go/apps/public/public.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/GoogleCloudPlatform/opentelemetry-operations-go/exporter/metric/metric.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/GoogleCloudPlatform/opentelemetry-operations-go/exporter/metric/option.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/GoogleCloudPlatform/opentelemetry-operations-go/exporter/metric/version.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/GoogleCloudPlatform/opentelemetry-operations-go/internal/resourcemapping/resourcemapping.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/cncf/xds/go/udpa/annotations/migrate.pb.go is excluded by !**/*.pb.go, !vendor/**, !**/vendor/**
  • vendor/github.com/cncf/xds/go/udpa/annotations/security.pb.go is excluded by !**/*.pb.go, !vendor/**, !**/vendor/**
  • vendor/github.com/cncf/xds/go/udpa/annotations/sensitive.pb.go is excluded by !**/*.pb.go, !vendor/**, !**/vendor/**
  • vendor/github.com/cncf/xds/go/udpa/annotations/status.pb.go is excluded by !**/*.pb.go, !vendor/**, !**/vendor/**
  • vendor/github.com/cncf/xds/go/udpa/annotations/versioning.pb.go is excluded by !**/*.pb.go, !vendor/**, !**/vendor/**
  • vendor/github.com/cncf/xds/go/udpa/type/v1/typed_struct.pb.go is excluded by !**/*.pb.go, !vendor/**, !**/vendor/**
  • vendor/github.com/cncf/xds/go/xds/annotations/v3/migrate.pb.go is excluded by !**/*.pb.go, !vendor/**, !**/vendor/**
  • vendor/github.com/cncf/xds/go/xds/annotations/v3/security.pb.go is excluded by !**/*.pb.go, !vendor/**, !**/vendor/**
  • vendor/github.com/cncf/xds/go/xds/annotations/v3/sensitive.pb.go is excluded by !**/*.pb.go, !vendor/**, !**/vendor/**
  • vendor/github.com/cncf/xds/go/xds/annotations/v3/status.pb.go is excluded by !**/*.pb.go, !vendor/**, !**/vendor/**
  • vendor/github.com/cncf/xds/go/xds/annotations/v3/versioning.pb.go is excluded by !**/*.pb.go, !vendor/**, !**/vendor/**
  • vendor/github.com/cncf/xds/go/xds/core/v3/authority.pb.go is excluded by !**/*.pb.go, !vendor/**, !**/vendor/**
  • vendor/github.com/cncf/xds/go/xds/core/v3/cidr.pb.go is excluded by !**/*.pb.go, !vendor/**, !**/vendor/**
  • vendor/github.com/cncf/xds/go/xds/core/v3/collection_entry.pb.go is excluded by !**/*.pb.go, !vendor/**, !**/vendor/**
  • vendor/github.com/cncf/xds/go/xds/core/v3/context_params.pb.go is excluded by !**/*.pb.go, !vendor/**, !**/vendor/**
  • vendor/github.com/cncf/xds/go/xds/core/v3/extension.pb.go is excluded by !**/*.pb.go, !vendor/**, !**/vendor/**
  • vendor/github.com/cncf/xds/go/xds/core/v3/resource.pb.go is excluded by !**/*.pb.go, !vendor/**, !**/vendor/**
  • vendor/github.com/cncf/xds/go/xds/core/v3/resource_locator.pb.go is excluded by !**/*.pb.go, !vendor/**, !**/vendor/**
  • vendor/github.com/cncf/xds/go/xds/core/v3/resource_name.pb.go is excluded by !**/*.pb.go, !vendor/**, !**/vendor/**
  • vendor/github.com/cncf/xds/go/xds/data/orca/v3/orca_load_report.pb.go is excluded by !**/*.pb.go, !vendor/**, !**/vendor/**
  • vendor/github.com/cncf/xds/go/xds/service/orca/v3/orca.pb.go is excluded by !**/*.pb.go, !vendor/**, !**/vendor/**
  • vendor/github.com/cncf/xds/go/xds/service/orca/v3/orca_grpc.pb.go is excluded by !**/*.pb.go, !vendor/**, !**/vendor/**
  • vendor/github.com/cncf/xds/go/xds/type/matcher/v3/cel.pb.go is excluded by !**/*.pb.go, !vendor/**, !**/vendor/**
  • vendor/github.com/cncf/xds/go/xds/type/matcher/v3/domain.pb.go is excluded by !**/*.pb.go, !vendor/**, !**/vendor/**
  • vendor/github.com/cncf/xds/go/xds/type/matcher/v3/http_inputs.pb.go is excluded by !**/*.pb.go, !vendor/**, !**/vendor/**
  • vendor/github.com/cncf/xds/go/xds/type/matcher/v3/ip.pb.go is excluded by !**/*.pb.go, !vendor/**, !**/vendor/**
  • vendor/github.com/cncf/xds/go/xds/type/matcher/v3/matcher.pb.go is excluded by !**/*.pb.go, !vendor/**, !**/vendor/**
  • vendor/github.com/cncf/xds/go/xds/type/matcher/v3/range.pb.go is excluded by !**/*.pb.go, !vendor/**, !**/vendor/**
  • vendor/github.com/cncf/xds/go/xds/type/matcher/v3/regex.pb.go is excluded by !**/*.pb.go, !vendor/**, !**/vendor/**
  • vendor/github.com/cncf/xds/go/xds/type/matcher/v3/string.pb.go is excluded by !**/*.pb.go, !vendor/**, !**/vendor/**
  • vendor/github.com/cncf/xds/go/xds/type/v3/cel.pb.go is excluded by !**/*.pb.go, !vendor/**, !**/vendor/**
  • vendor/github.com/cncf/xds/go/xds/type/v3/range.pb.go is excluded by !**/*.pb.go, !vendor/**, !**/vendor/**
  • vendor/github.com/cncf/xds/go/xds/type/v3/typed_struct.pb.go is excluded by !**/*.pb.go, !vendor/**, !**/vendor/**
  • vendor/github.com/coreos/ignition/v2/config/v3_3/config.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/coreos/ignition/v2/config/v3_3/translate/translate.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/coreos/ignition/v2/config/v3_3/types/clevis.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/coreos/ignition/v2/config/v3_3/types/config.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/coreos/ignition/v2/config/v3_3/types/device.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/coreos/ignition/v2/config/v3_3/types/directory.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/coreos/ignition/v2/config/v3_3/types/disk.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/coreos/ignition/v2/config/v3_3/types/file.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/coreos/ignition/v2/config/v3_3/types/filesystem.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/coreos/ignition/v2/config/v3_3/types/headers.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/coreos/ignition/v2/config/v3_3/types/ignition.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/coreos/ignition/v2/config/v3_3/types/kargs.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/coreos/ignition/v2/config/v3_3/types/luks.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/coreos/ignition/v2/config/v3_3/types/mode.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/coreos/ignition/v2/config/v3_3/types/node.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/coreos/ignition/v2/config/v3_3/types/partition.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/coreos/ignition/v2/config/v3_3/types/passwd.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/coreos/ignition/v2/config/v3_3/types/path.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/coreos/ignition/v2/config/v3_3/types/proxy.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/coreos/ignition/v2/config/v3_3/types/raid.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/coreos/ignition/v2/config/v3_3/types/resource.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/coreos/ignition/v2/config/v3_3/types/schema.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/coreos/ignition/v2/config/v3_3/types/storage.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/coreos/ignition/v2/config/v3_3/types/systemd.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/coreos/ignition/v2/config/v3_3/types/tang.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/coreos/ignition/v2/config/v3_3/types/tls.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/coreos/ignition/v2/config/v3_3/types/unit.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/coreos/ignition/v2/config/v3_3/types/url.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/coreos/ignition/v2/config/v3_3/types/verification.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/coreos/ignition/v2/config/v3_4/config.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/coreos/ignition/v2/config/v3_4/translate/translate.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/coreos/ignition/v2/config/v3_4/types/clevis.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/coreos/ignition/v2/config/v3_4/types/config.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/coreos/ignition/v2/config/v3_4/types/device.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/coreos/ignition/v2/config/v3_4/types/directory.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/coreos/ignition/v2/config/v3_4/types/disk.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/coreos/ignition/v2/config/v3_4/types/file.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/coreos/ignition/v2/config/v3_4/types/filesystem.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/coreos/ignition/v2/config/v3_4/types/headers.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/coreos/ignition/v2/config/v3_4/types/ignition.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/coreos/ignition/v2/config/v3_4/types/kargs.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/coreos/ignition/v2/config/v3_4/types/luks.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/coreos/ignition/v2/config/v3_4/types/mode.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/coreos/ignition/v2/config/v3_4/types/node.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/coreos/ignition/v2/config/v3_4/types/partition.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/coreos/ignition/v2/config/v3_4/types/passwd.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/coreos/ignition/v2/config/v3_4/types/path.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/coreos/ignition/v2/config/v3_4/types/proxy.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/coreos/ignition/v2/config/v3_4/types/raid.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/coreos/ignition/v2/config/v3_4/types/resource.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/coreos/ignition/v2/config/v3_4/types/schema.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/coreos/ignition/v2/config/v3_4/types/storage.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/coreos/ignition/v2/config/v3_4/types/systemd.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/coreos/ignition/v2/config/v3_4/types/tang.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/coreos/ignition/v2/config/v3_4/types/tls.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/coreos/ignition/v2/config/v3_4/types/unit.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/coreos/ignition/v2/config/v3_4/types/url.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/coreos/ignition/v2/config/v3_4/types/verification.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/coreos/ignition/v2/config/v3_5/config.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/coreos/ignition/v2/config/v3_5/translate/translate.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/coreos/ignition/v2/config/v3_5/types/cex.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/coreos/ignition/v2/config/v3_5/types/clevis.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/coreos/ignition/v2/config/v3_5/types/config.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/coreos/ignition/v2/config/v3_5/types/device.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/coreos/ignition/v2/config/v3_5/types/directory.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/coreos/ignition/v2/config/v3_5/types/disk.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/coreos/ignition/v2/config/v3_5/types/file.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/coreos/ignition/v2/config/v3_5/types/filesystem.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/coreos/ignition/v2/config/v3_5/types/headers.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/coreos/ignition/v2/config/v3_5/types/ignition.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/coreos/ignition/v2/config/v3_5/types/kargs.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/coreos/ignition/v2/config/v3_5/types/luks.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/coreos/ignition/v2/config/v3_5/types/mode.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/coreos/ignition/v2/config/v3_5/types/node.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/coreos/ignition/v2/config/v3_5/types/partition.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/coreos/ignition/v2/config/v3_5/types/passwd.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/coreos/ignition/v2/config/v3_5/types/path.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/coreos/ignition/v2/config/v3_5/types/proxy.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/coreos/ignition/v2/config/v3_5/types/raid.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/coreos/ignition/v2/config/v3_5/types/resource.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/coreos/ignition/v2/config/v3_5/types/schema.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/coreos/ignition/v2/config/v3_5/types/storage.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/coreos/ignition/v2/config/v3_5/types/systemd.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/coreos/ignition/v2/config/v3_5/types/tang.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/coreos/ignition/v2/config/v3_5/types/tls.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/coreos/ignition/v2/config/v3_5/types/unit.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/coreos/ignition/v2/config/v3_5/types/url.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/coreos/ignition/v2/config/v3_5/types/verification.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/coreos/ignition/v2/config/v3_6/config.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/coreos/ignition/v2/config/v3_6/translate/translate.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/coreos/ignition/v2/config/v3_6/types/cex.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/coreos/ignition/v2/config/v3_6/types/clevis.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/coreos/ignition/v2/config/v3_6/types/config.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/coreos/ignition/v2/config/v3_6/types/device.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/coreos/ignition/v2/config/v3_6/types/directory.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/coreos/ignition/v2/config/v3_6/types/disk.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/coreos/ignition/v2/config/v3_6/types/file.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/coreos/ignition/v2/config/v3_6/types/filesystem.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/coreos/ignition/v2/config/v3_6/types/headers.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/coreos/ignition/v2/config/v3_6/types/ignition.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/coreos/ignition/v2/config/v3_6/types/kargs.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/coreos/ignition/v2/config/v3_6/types/luks.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/coreos/ignition/v2/config/v3_6/types/mode.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/coreos/ignition/v2/config/v3_6/types/node.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/coreos/ignition/v2/config/v3_6/types/partition.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/coreos/ignition/v2/config/v3_6/types/passwd.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/coreos/ignition/v2/config/v3_6/types/path.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/coreos/ignition/v2/config/v3_6/types/proxy.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/coreos/ignition/v2/config/v3_6/types/raid.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/coreos/ignition/v2/config/v3_6/types/resource.go is excluded by !vendor/**, !**/vendor/**
📒 Files selected for processing (37)
  • go.mod
  • pkg/asset/agent/image/ignition.go
  • pkg/asset/agent/image/ignition_test.go
  • pkg/asset/agent/image/unconfigured_ignition.go
  • pkg/asset/agent/joiner/clusterinfo.go
  • pkg/asset/agent/joiner/clusterinfo_test.go
  • pkg/asset/cluster/tfvars/tfvars.go
  • pkg/asset/ignition/bootstrap/bootstrap_ignition.go
  • pkg/asset/ignition/bootstrap/bootstrap_ignition_test.go
  • pkg/asset/ignition/bootstrap/common.go
  • pkg/asset/ignition/bootstrap/ibmcloud/storage.go
  • pkg/asset/ignition/machine/arbiter.go
  • pkg/asset/ignition/machine/arbiter_ignition_customizations_test.go
  • pkg/asset/ignition/machine/master.go
  • pkg/asset/ignition/machine/node.go
  • pkg/asset/ignition/machine/worker.go
  • pkg/asset/ignition/node.go
  • pkg/asset/imagebased/image/ignition.go
  • pkg/asset/imagebased/image/ignition_test.go
  • pkg/asset/machines/arbiter_test.go
  • pkg/asset/machines/machineconfig/authorizedkeys.go
  • pkg/asset/machines/machineconfig/chrony.go
  • pkg/asset/machines/machineconfig/disks.go
  • pkg/asset/machines/machineconfig/disks_test.go
  • pkg/asset/machines/machineconfig/fips.go
  • pkg/asset/machines/machineconfig/hyperthreading.go
  • pkg/asset/machines/machineconfig/ipv6.go
  • pkg/asset/machines/machineconfig/multipath.go
  • pkg/asset/machines/machineconfig/powersmt.go
  • pkg/asset/machines/machineconfig/routes.go
  • pkg/asset/machines/master_test.go
  • pkg/asset/machines/worker_test.go
  • pkg/infrastructure/baremetal/bootstrap.go
  • pkg/infrastructure/clusterapi/helpers.go
  • pkg/infrastructure/clusterapi/ignition.go
  • pkg/infrastructure/openstack/preprovision/bootstrapignition.go
  • pkg/types/nutanix/helpers.go
✅ Files skipped from review due to trivial changes (18)
  • pkg/asset/ignition/bootstrap/common.go
  • pkg/asset/ignition/bootstrap/bootstrap_ignition.go
  • pkg/asset/machines/machineconfig/chrony.go
  • pkg/asset/ignition/machine/node.go
  • pkg/asset/machines/arbiter_test.go
  • pkg/asset/machines/machineconfig/routes.go
  • pkg/asset/ignition/bootstrap/ibmcloud/storage.go
  • pkg/asset/ignition/machine/arbiter_ignition_customizations_test.go
  • pkg/asset/agent/joiner/clusterinfo.go
  • pkg/asset/cluster/tfvars/tfvars.go
  • pkg/asset/imagebased/image/ignition_test.go
  • pkg/asset/machines/machineconfig/ipv6.go
  • pkg/infrastructure/clusterapi/helpers.go
  • pkg/asset/ignition/machine/master.go
  • pkg/infrastructure/clusterapi/ignition.go
  • pkg/asset/machines/machineconfig/powersmt.go
  • pkg/asset/machines/machineconfig/disks.go
  • pkg/asset/agent/image/ignition.go
🚧 Files skipped from review as they are similar to previous changes (11)
  • pkg/asset/agent/joiner/clusterinfo_test.go
  • pkg/asset/machines/machineconfig/hyperthreading.go
  • pkg/asset/imagebased/image/ignition.go
  • pkg/asset/machines/machineconfig/disks_test.go
  • pkg/asset/machines/machineconfig/fips.go
  • pkg/asset/machines/machineconfig/multipath.go
  • pkg/infrastructure/baremetal/bootstrap.go
  • pkg/asset/ignition/machine/arbiter.go
  • pkg/asset/ignition/machine/worker.go
  • pkg/asset/machines/machineconfig/authorizedkeys.go
  • pkg/asset/ignition/node.go

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@go.mod`:
- Line 176: Update the pinned OpenTelemetry SDK version from v1.39.0 to v1.40.0
by changing the module entry for go.opentelemetry.io/otel/sdk in go.mod to
v1.40.0 and then run `go mod tidy` to refresh the dependency graph and ensure
indirect deps are consistent; target the module symbol
"go.opentelemetry.io/otel/sdk" and ensure the version string is v1.40.0.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 729948e1-3b20-4708-84e9-80823e6b277a

📥 Commits

Reviewing files that changed from the base of the PR and between 0889fd9 and 1f93d32.

⛔ Files ignored due to path filters (263)
  • go.sum is excluded by !**/*.sum
  • vendor/cloud.google.com/go/.release-please-manifest-individual.json is excluded by !vendor/**, !**/vendor/**
  • vendor/cloud.google.com/go/.release-please-manifest-submodules.json is excluded by !vendor/**, !**/vendor/**
  • vendor/cloud.google.com/go/.release-please-manifest.json is excluded by !vendor/**, !**/vendor/**
  • vendor/cloud.google.com/go/CHANGES.md is excluded by !vendor/**, !**/vendor/**
  • vendor/cloud.google.com/go/README.md is excluded by !vendor/**, !**/vendor/**
  • vendor/cloud.google.com/go/auth/CHANGES.md is excluded by !vendor/**, !**/vendor/**
  • vendor/cloud.google.com/go/auth/credentials/detect.go is excluded by !vendor/**, !**/vendor/**
  • vendor/cloud.google.com/go/auth/credentials/filetypes.go is excluded by !vendor/**, !**/vendor/**
  • vendor/cloud.google.com/go/auth/internal/credsfile/credsfile.go is excluded by !vendor/**, !**/vendor/**
  • vendor/cloud.google.com/go/auth/internal/credsfile/filetype.go is excluded by !vendor/**, !**/vendor/**
  • vendor/cloud.google.com/go/auth/internal/credsfile/parse.go is excluded by !vendor/**, !**/vendor/**
  • vendor/cloud.google.com/go/auth/internal/internal.go is excluded by !vendor/**, !**/vendor/**
  • vendor/cloud.google.com/go/auth/internal/version.go is excluded by !vendor/**, !**/vendor/**
  • vendor/cloud.google.com/go/go.work is excluded by !**/*.work, !vendor/**, !**/vendor/**
  • vendor/cloud.google.com/go/go.work.sum is excluded by !**/*.sum, !vendor/**, !**/vendor/**
  • vendor/cloud.google.com/go/internal/.repo-metadata-full.json is excluded by !vendor/**, !**/vendor/**
  • vendor/cloud.google.com/go/kms/apiv1/autokey_admin_client.go is excluded by !vendor/**, !**/vendor/**
  • vendor/cloud.google.com/go/kms/apiv1/autokey_client.go is excluded by !vendor/**, !**/vendor/**
  • vendor/cloud.google.com/go/kms/apiv1/ekm_client.go is excluded by !vendor/**, !**/vendor/**
  • vendor/cloud.google.com/go/kms/apiv1/gapic_metadata.json is excluded by !vendor/**, !**/vendor/**
  • vendor/cloud.google.com/go/kms/apiv1/key_management_client.go is excluded by !vendor/**, !**/vendor/**
  • vendor/cloud.google.com/go/kms/apiv1/kmspb/autokey.pb.go is excluded by !**/*.pb.go, !vendor/**, !**/vendor/**
  • vendor/cloud.google.com/go/kms/apiv1/kmspb/autokey_admin.pb.go is excluded by !**/*.pb.go, !vendor/**, !**/vendor/**
  • vendor/cloud.google.com/go/kms/apiv1/kmspb/autokey_admin_grpc.pb.go is excluded by !**/*.pb.go, !vendor/**, !**/vendor/**
  • vendor/cloud.google.com/go/kms/apiv1/kmspb/autokey_grpc.pb.go is excluded by !**/*.pb.go, !vendor/**, !**/vendor/**
  • vendor/cloud.google.com/go/kms/apiv1/kmspb/ekm_service.pb.go is excluded by !**/*.pb.go, !vendor/**, !**/vendor/**
  • vendor/cloud.google.com/go/kms/apiv1/kmspb/ekm_service_grpc.pb.go is excluded by !**/*.pb.go, !vendor/**, !**/vendor/**
  • vendor/cloud.google.com/go/kms/apiv1/kmspb/resources.pb.go is excluded by !**/*.pb.go, !vendor/**, !**/vendor/**
  • vendor/cloud.google.com/go/kms/apiv1/kmspb/service.pb.go is excluded by !**/*.pb.go, !vendor/**, !**/vendor/**
  • vendor/cloud.google.com/go/kms/apiv1/kmspb/service_grpc.pb.go is excluded by !**/*.pb.go, !vendor/**, !**/vendor/**
  • vendor/cloud.google.com/go/kms/internal/version.go is excluded by !vendor/**, !**/vendor/**
  • vendor/cloud.google.com/go/longrunning/CHANGES.md is excluded by !vendor/**, !**/vendor/**
  • vendor/cloud.google.com/go/longrunning/autogen/helpers.go is excluded by !vendor/**, !**/vendor/**
  • vendor/cloud.google.com/go/longrunning/autogen/longrunningpb/operations.pb.go is excluded by !**/*.pb.go, !vendor/**, !**/vendor/**
  • vendor/cloud.google.com/go/longrunning/autogen/operations_client.go is excluded by !vendor/**, !**/vendor/**
  • vendor/cloud.google.com/go/monitoring/apiv3/v2/alert_policy_client.go is excluded by !vendor/**, !**/vendor/**
  • vendor/cloud.google.com/go/monitoring/apiv3/v2/group_client.go is excluded by !vendor/**, !**/vendor/**
  • vendor/cloud.google.com/go/monitoring/apiv3/v2/helpers.go is excluded by !vendor/**, !**/vendor/**
  • vendor/cloud.google.com/go/monitoring/apiv3/v2/metric_client.go is excluded by !vendor/**, !**/vendor/**
  • vendor/cloud.google.com/go/monitoring/apiv3/v2/monitoringpb/alert.pb.go is excluded by !**/*.pb.go, !vendor/**, !**/vendor/**
  • vendor/cloud.google.com/go/monitoring/apiv3/v2/monitoringpb/alert_service.pb.go is excluded by !**/*.pb.go, !vendor/**, !**/vendor/**
  • vendor/cloud.google.com/go/monitoring/apiv3/v2/monitoringpb/alert_service_grpc.pb.go is excluded by !**/*.pb.go, !vendor/**, !**/vendor/**
  • vendor/cloud.google.com/go/monitoring/apiv3/v2/monitoringpb/common.pb.go is excluded by !**/*.pb.go, !vendor/**, !**/vendor/**
  • vendor/cloud.google.com/go/monitoring/apiv3/v2/monitoringpb/dropped_labels.pb.go is excluded by !**/*.pb.go, !vendor/**, !**/vendor/**
  • vendor/cloud.google.com/go/monitoring/apiv3/v2/monitoringpb/group.pb.go is excluded by !**/*.pb.go, !vendor/**, !**/vendor/**
  • vendor/cloud.google.com/go/monitoring/apiv3/v2/monitoringpb/group_service.pb.go is excluded by !**/*.pb.go, !vendor/**, !**/vendor/**
  • vendor/cloud.google.com/go/monitoring/apiv3/v2/monitoringpb/group_service_grpc.pb.go is excluded by !**/*.pb.go, !vendor/**, !**/vendor/**
  • vendor/cloud.google.com/go/monitoring/apiv3/v2/monitoringpb/metric.pb.go is excluded by !**/*.pb.go, !vendor/**, !**/vendor/**
  • vendor/cloud.google.com/go/monitoring/apiv3/v2/monitoringpb/metric_service.pb.go is excluded by !**/*.pb.go, !vendor/**, !**/vendor/**
  • vendor/cloud.google.com/go/monitoring/apiv3/v2/monitoringpb/metric_service_grpc.pb.go is excluded by !**/*.pb.go, !vendor/**, !**/vendor/**
  • vendor/cloud.google.com/go/monitoring/apiv3/v2/monitoringpb/mutation_record.pb.go is excluded by !**/*.pb.go, !vendor/**, !**/vendor/**
  • vendor/cloud.google.com/go/monitoring/apiv3/v2/monitoringpb/notification.pb.go is excluded by !**/*.pb.go, !vendor/**, !**/vendor/**
  • vendor/cloud.google.com/go/monitoring/apiv3/v2/monitoringpb/notification_service.pb.go is excluded by !**/*.pb.go, !vendor/**, !**/vendor/**
  • vendor/cloud.google.com/go/monitoring/apiv3/v2/monitoringpb/notification_service_grpc.pb.go is excluded by !**/*.pb.go, !vendor/**, !**/vendor/**
  • vendor/cloud.google.com/go/monitoring/apiv3/v2/monitoringpb/query_service.pb.go is excluded by !**/*.pb.go, !vendor/**, !**/vendor/**
  • vendor/cloud.google.com/go/monitoring/apiv3/v2/monitoringpb/query_service_grpc.pb.go is excluded by !**/*.pb.go, !vendor/**, !**/vendor/**
  • vendor/cloud.google.com/go/monitoring/apiv3/v2/monitoringpb/service.pb.go is excluded by !**/*.pb.go, !vendor/**, !**/vendor/**
  • vendor/cloud.google.com/go/monitoring/apiv3/v2/monitoringpb/service_service.pb.go is excluded by !**/*.pb.go, !vendor/**, !**/vendor/**
  • vendor/cloud.google.com/go/monitoring/apiv3/v2/monitoringpb/service_service_grpc.pb.go is excluded by !**/*.pb.go, !vendor/**, !**/vendor/**
  • vendor/cloud.google.com/go/monitoring/apiv3/v2/monitoringpb/snooze.pb.go is excluded by !**/*.pb.go, !vendor/**, !**/vendor/**
  • vendor/cloud.google.com/go/monitoring/apiv3/v2/monitoringpb/snooze_service.pb.go is excluded by !**/*.pb.go, !vendor/**, !**/vendor/**
  • vendor/cloud.google.com/go/monitoring/apiv3/v2/monitoringpb/snooze_service_grpc.pb.go is excluded by !**/*.pb.go, !vendor/**, !**/vendor/**
  • vendor/cloud.google.com/go/monitoring/apiv3/v2/monitoringpb/span_context.pb.go is excluded by !**/*.pb.go, !vendor/**, !**/vendor/**
  • vendor/cloud.google.com/go/monitoring/apiv3/v2/monitoringpb/uptime.pb.go is excluded by !**/*.pb.go, !vendor/**, !**/vendor/**
  • vendor/cloud.google.com/go/monitoring/apiv3/v2/monitoringpb/uptime_service.pb.go is excluded by !**/*.pb.go, !vendor/**, !**/vendor/**
  • vendor/cloud.google.com/go/monitoring/apiv3/v2/monitoringpb/uptime_service_grpc.pb.go is excluded by !**/*.pb.go, !vendor/**, !**/vendor/**
  • vendor/cloud.google.com/go/monitoring/apiv3/v2/notification_channel_client.go is excluded by !vendor/**, !**/vendor/**
  • vendor/cloud.google.com/go/monitoring/apiv3/v2/query_client.go is excluded by !vendor/**, !**/vendor/**
  • vendor/cloud.google.com/go/monitoring/apiv3/v2/service_monitoring_client.go is excluded by !vendor/**, !**/vendor/**
  • vendor/cloud.google.com/go/monitoring/apiv3/v2/snooze_client.go is excluded by !vendor/**, !**/vendor/**
  • vendor/cloud.google.com/go/monitoring/apiv3/v2/uptime_check_client.go is excluded by !vendor/**, !**/vendor/**
  • vendor/cloud.google.com/go/monitoring/internal/version.go is excluded by !vendor/**, !**/vendor/**
  • vendor/cloud.google.com/go/release-please-config-individual.json is excluded by !vendor/**, !**/vendor/**
  • vendor/cloud.google.com/go/release-please-config-yoshi-submodules.json is excluded by !vendor/**, !**/vendor/**
  • vendor/cloud.google.com/go/storage/.repo-metadata.json is excluded by !vendor/**, !**/vendor/**
  • vendor/cloud.google.com/go/storage/CHANGES.md is excluded by !vendor/**, !**/vendor/**
  • vendor/cloud.google.com/go/storage/bucket.go is excluded by !vendor/**, !**/vendor/**
  • vendor/cloud.google.com/go/storage/client.go is excluded by !vendor/**, !**/vendor/**
  • vendor/cloud.google.com/go/storage/contexts.go is excluded by !vendor/**, !**/vendor/**
  • vendor/cloud.google.com/go/storage/copy.go is excluded by !vendor/**, !**/vendor/**
  • vendor/cloud.google.com/go/storage/doc.go is excluded by !vendor/**, !**/vendor/**
  • vendor/cloud.google.com/go/storage/emulator_test.sh is excluded by !vendor/**, !**/vendor/**
  • vendor/cloud.google.com/go/storage/grpc_client.go is excluded by !vendor/**, !**/vendor/**
  • vendor/cloud.google.com/go/storage/grpc_reader.go is excluded by !vendor/**, !**/vendor/**
  • vendor/cloud.google.com/go/storage/grpc_reader_multi_range.go is excluded by !vendor/**, !**/vendor/**
  • vendor/cloud.google.com/go/storage/grpc_writer.go is excluded by !vendor/**, !**/vendor/**
  • vendor/cloud.google.com/go/storage/http_client.go is excluded by !vendor/**, !**/vendor/**
  • vendor/cloud.google.com/go/storage/internal/apiv2/.repo-metadata.json is excluded by !vendor/**, !**/vendor/**
  • vendor/cloud.google.com/go/storage/internal/apiv2/storage_client.go is excluded by !vendor/**, !**/vendor/**
  • vendor/cloud.google.com/go/storage/internal/apiv2/storagepb/storage.pb.go is excluded by !**/*.pb.go, !vendor/**, !**/vendor/**
  • vendor/cloud.google.com/go/storage/internal/apiv2/storagepb/storage_grpc.pb.go is excluded by !**/*.pb.go, !vendor/**, !**/vendor/**
  • vendor/cloud.google.com/go/storage/internal/version.go is excluded by !vendor/**, !**/vendor/**
  • vendor/cloud.google.com/go/storage/pcu.go is excluded by !vendor/**, !**/vendor/**
  • vendor/cloud.google.com/go/storage/reader.go is excluded by !vendor/**, !**/vendor/**
  • vendor/cloud.google.com/go/storage/storage.go is excluded by !vendor/**, !**/vendor/**
  • vendor/cloud.google.com/go/storage/writer.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/Azure/azure-sdk-for-go/sdk/azcore/CHANGELOG.md is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/Azure/azure-sdk-for-go/sdk/azcore/arm/internal/resource/resource_identifier.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/Azure/azure-sdk-for-go/sdk/azcore/internal/exported/exported.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/Azure/azure-sdk-for-go/sdk/azcore/internal/shared/constants.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/Azure/azure-sdk-for-go/sdk/azcore/runtime/pager.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/Azure/azure-sdk-for-go/sdk/azidentity/CHANGELOG.md is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/Azure/azure-sdk-for-go/sdk/azidentity/developer_credential_util.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/Azure/azure-sdk-for-go/sdk/azidentity/developer_credential_util_nonwindows.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/Azure/azure-sdk-for-go/sdk/azidentity/developer_credential_util_windows.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/Azure/azure-sdk-for-go/sdk/azidentity/version.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/Azure/azure-sdk-for-go/sdk/storage/azblob/CHANGELOG.md is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/Azure/azure-sdk-for-go/sdk/storage/azblob/internal/exported/version.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/AzureAD/microsoft-authentication-library-for-go/apps/confidential/confidential.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/AzureAD/microsoft-authentication-library-for-go/apps/internal/base/base.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/AzureAD/microsoft-authentication-library-for-go/apps/internal/base/storage/items.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/AzureAD/microsoft-authentication-library-for-go/apps/internal/base/storage/storage.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/AzureAD/microsoft-authentication-library-for-go/apps/internal/oauth/ops/accesstokens/accesstokens.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/AzureAD/microsoft-authentication-library-for-go/apps/internal/oauth/ops/authority/authority.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/AzureAD/microsoft-authentication-library-for-go/apps/public/public.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/GoogleCloudPlatform/opentelemetry-operations-go/exporter/metric/metric.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/GoogleCloudPlatform/opentelemetry-operations-go/exporter/metric/option.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/GoogleCloudPlatform/opentelemetry-operations-go/exporter/metric/version.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/GoogleCloudPlatform/opentelemetry-operations-go/internal/resourcemapping/resourcemapping.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/cncf/xds/go/udpa/annotations/migrate.pb.go is excluded by !**/*.pb.go, !vendor/**, !**/vendor/**
  • vendor/github.com/cncf/xds/go/udpa/annotations/security.pb.go is excluded by !**/*.pb.go, !vendor/**, !**/vendor/**
  • vendor/github.com/cncf/xds/go/udpa/annotations/sensitive.pb.go is excluded by !**/*.pb.go, !vendor/**, !**/vendor/**
  • vendor/github.com/cncf/xds/go/udpa/annotations/status.pb.go is excluded by !**/*.pb.go, !vendor/**, !**/vendor/**
  • vendor/github.com/cncf/xds/go/udpa/annotations/versioning.pb.go is excluded by !**/*.pb.go, !vendor/**, !**/vendor/**
  • vendor/github.com/cncf/xds/go/udpa/type/v1/typed_struct.pb.go is excluded by !**/*.pb.go, !vendor/**, !**/vendor/**
  • vendor/github.com/cncf/xds/go/xds/annotations/v3/migrate.pb.go is excluded by !**/*.pb.go, !vendor/**, !**/vendor/**
  • vendor/github.com/cncf/xds/go/xds/annotations/v3/security.pb.go is excluded by !**/*.pb.go, !vendor/**, !**/vendor/**
  • vendor/github.com/cncf/xds/go/xds/annotations/v3/sensitive.pb.go is excluded by !**/*.pb.go, !vendor/**, !**/vendor/**
  • vendor/github.com/cncf/xds/go/xds/annotations/v3/status.pb.go is excluded by !**/*.pb.go, !vendor/**, !**/vendor/**
  • vendor/github.com/cncf/xds/go/xds/annotations/v3/versioning.pb.go is excluded by !**/*.pb.go, !vendor/**, !**/vendor/**
  • vendor/github.com/cncf/xds/go/xds/core/v3/authority.pb.go is excluded by !**/*.pb.go, !vendor/**, !**/vendor/**
  • vendor/github.com/cncf/xds/go/xds/core/v3/cidr.pb.go is excluded by !**/*.pb.go, !vendor/**, !**/vendor/**
  • vendor/github.com/cncf/xds/go/xds/core/v3/collection_entry.pb.go is excluded by !**/*.pb.go, !vendor/**, !**/vendor/**
  • vendor/github.com/cncf/xds/go/xds/core/v3/context_params.pb.go is excluded by !**/*.pb.go, !vendor/**, !**/vendor/**
  • vendor/github.com/cncf/xds/go/xds/core/v3/extension.pb.go is excluded by !**/*.pb.go, !vendor/**, !**/vendor/**
  • vendor/github.com/cncf/xds/go/xds/core/v3/resource.pb.go is excluded by !**/*.pb.go, !vendor/**, !**/vendor/**
  • vendor/github.com/cncf/xds/go/xds/core/v3/resource_locator.pb.go is excluded by !**/*.pb.go, !vendor/**, !**/vendor/**
  • vendor/github.com/cncf/xds/go/xds/core/v3/resource_name.pb.go is excluded by !**/*.pb.go, !vendor/**, !**/vendor/**
  • vendor/github.com/cncf/xds/go/xds/data/orca/v3/orca_load_report.pb.go is excluded by !**/*.pb.go, !vendor/**, !**/vendor/**
  • vendor/github.com/cncf/xds/go/xds/service/orca/v3/orca.pb.go is excluded by !**/*.pb.go, !vendor/**, !**/vendor/**
  • vendor/github.com/cncf/xds/go/xds/service/orca/v3/orca_grpc.pb.go is excluded by !**/*.pb.go, !vendor/**, !**/vendor/**
  • vendor/github.com/cncf/xds/go/xds/type/matcher/v3/cel.pb.go is excluded by !**/*.pb.go, !vendor/**, !**/vendor/**
  • vendor/github.com/cncf/xds/go/xds/type/matcher/v3/domain.pb.go is excluded by !**/*.pb.go, !vendor/**, !**/vendor/**
  • vendor/github.com/cncf/xds/go/xds/type/matcher/v3/http_inputs.pb.go is excluded by !**/*.pb.go, !vendor/**, !**/vendor/**
  • vendor/github.com/cncf/xds/go/xds/type/matcher/v3/ip.pb.go is excluded by !**/*.pb.go, !vendor/**, !**/vendor/**
  • vendor/github.com/cncf/xds/go/xds/type/matcher/v3/matcher.pb.go is excluded by !**/*.pb.go, !vendor/**, !**/vendor/**
  • vendor/github.com/cncf/xds/go/xds/type/matcher/v3/range.pb.go is excluded by !**/*.pb.go, !vendor/**, !**/vendor/**
  • vendor/github.com/cncf/xds/go/xds/type/matcher/v3/regex.pb.go is excluded by !**/*.pb.go, !vendor/**, !**/vendor/**
  • vendor/github.com/cncf/xds/go/xds/type/matcher/v3/string.pb.go is excluded by !**/*.pb.go, !vendor/**, !**/vendor/**
  • vendor/github.com/cncf/xds/go/xds/type/v3/cel.pb.go is excluded by !**/*.pb.go, !vendor/**, !**/vendor/**
  • vendor/github.com/cncf/xds/go/xds/type/v3/range.pb.go is excluded by !**/*.pb.go, !vendor/**, !**/vendor/**
  • vendor/github.com/cncf/xds/go/xds/type/v3/typed_struct.pb.go is excluded by !**/*.pb.go, !vendor/**, !**/vendor/**
  • vendor/github.com/coreos/ignition/v2/config/v3_3/config.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/coreos/ignition/v2/config/v3_3/translate/translate.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/coreos/ignition/v2/config/v3_3/types/clevis.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/coreos/ignition/v2/config/v3_3/types/config.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/coreos/ignition/v2/config/v3_3/types/device.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/coreos/ignition/v2/config/v3_3/types/directory.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/coreos/ignition/v2/config/v3_3/types/disk.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/coreos/ignition/v2/config/v3_3/types/file.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/coreos/ignition/v2/config/v3_3/types/filesystem.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/coreos/ignition/v2/config/v3_3/types/headers.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/coreos/ignition/v2/config/v3_3/types/ignition.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/coreos/ignition/v2/config/v3_3/types/kargs.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/coreos/ignition/v2/config/v3_3/types/luks.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/coreos/ignition/v2/config/v3_3/types/mode.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/coreos/ignition/v2/config/v3_3/types/node.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/coreos/ignition/v2/config/v3_3/types/partition.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/coreos/ignition/v2/config/v3_3/types/passwd.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/coreos/ignition/v2/config/v3_3/types/path.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/coreos/ignition/v2/config/v3_3/types/proxy.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/coreos/ignition/v2/config/v3_3/types/raid.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/coreos/ignition/v2/config/v3_3/types/resource.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/coreos/ignition/v2/config/v3_3/types/schema.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/coreos/ignition/v2/config/v3_3/types/storage.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/coreos/ignition/v2/config/v3_3/types/systemd.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/coreos/ignition/v2/config/v3_3/types/tang.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/coreos/ignition/v2/config/v3_3/types/tls.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/coreos/ignition/v2/config/v3_3/types/unit.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/coreos/ignition/v2/config/v3_3/types/url.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/coreos/ignition/v2/config/v3_3/types/verification.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/coreos/ignition/v2/config/v3_4/config.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/coreos/ignition/v2/config/v3_4/translate/translate.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/coreos/ignition/v2/config/v3_4/types/clevis.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/coreos/ignition/v2/config/v3_4/types/config.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/coreos/ignition/v2/config/v3_4/types/device.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/coreos/ignition/v2/config/v3_4/types/directory.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/coreos/ignition/v2/config/v3_4/types/disk.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/coreos/ignition/v2/config/v3_4/types/file.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/coreos/ignition/v2/config/v3_4/types/filesystem.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/coreos/ignition/v2/config/v3_4/types/headers.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/coreos/ignition/v2/config/v3_4/types/ignition.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/coreos/ignition/v2/config/v3_4/types/kargs.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/coreos/ignition/v2/config/v3_4/types/luks.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/coreos/ignition/v2/config/v3_4/types/mode.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/coreos/ignition/v2/config/v3_4/types/node.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/coreos/ignition/v2/config/v3_4/types/partition.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/coreos/ignition/v2/config/v3_4/types/passwd.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/coreos/ignition/v2/config/v3_4/types/path.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/coreos/ignition/v2/config/v3_4/types/proxy.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/coreos/ignition/v2/config/v3_4/types/raid.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/coreos/ignition/v2/config/v3_4/types/resource.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/coreos/ignition/v2/config/v3_4/types/schema.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/coreos/ignition/v2/config/v3_4/types/storage.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/coreos/ignition/v2/config/v3_4/types/systemd.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/coreos/ignition/v2/config/v3_4/types/tang.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/coreos/ignition/v2/config/v3_4/types/tls.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/coreos/ignition/v2/config/v3_4/types/unit.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/coreos/ignition/v2/config/v3_4/types/url.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/coreos/ignition/v2/config/v3_4/types/verification.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/coreos/ignition/v2/config/v3_5/config.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/coreos/ignition/v2/config/v3_5/translate/translate.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/coreos/ignition/v2/config/v3_5/types/cex.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/coreos/ignition/v2/config/v3_5/types/clevis.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/coreos/ignition/v2/config/v3_5/types/config.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/coreos/ignition/v2/config/v3_5/types/device.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/coreos/ignition/v2/config/v3_5/types/directory.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/coreos/ignition/v2/config/v3_5/types/disk.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/coreos/ignition/v2/config/v3_5/types/file.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/coreos/ignition/v2/config/v3_5/types/filesystem.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/coreos/ignition/v2/config/v3_5/types/headers.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/coreos/ignition/v2/config/v3_5/types/ignition.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/coreos/ignition/v2/config/v3_5/types/kargs.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/coreos/ignition/v2/config/v3_5/types/luks.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/coreos/ignition/v2/config/v3_5/types/mode.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/coreos/ignition/v2/config/v3_5/types/node.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/coreos/ignition/v2/config/v3_5/types/partition.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/coreos/ignition/v2/config/v3_5/types/passwd.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/coreos/ignition/v2/config/v3_5/types/path.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/coreos/ignition/v2/config/v3_5/types/proxy.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/coreos/ignition/v2/config/v3_5/types/raid.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/coreos/ignition/v2/config/v3_5/types/resource.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/coreos/ignition/v2/config/v3_5/types/schema.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/coreos/ignition/v2/config/v3_5/types/storage.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/coreos/ignition/v2/config/v3_5/types/systemd.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/coreos/ignition/v2/config/v3_5/types/tang.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/coreos/ignition/v2/config/v3_5/types/tls.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/coreos/ignition/v2/config/v3_5/types/unit.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/coreos/ignition/v2/config/v3_5/types/url.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/coreos/ignition/v2/config/v3_5/types/verification.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/coreos/ignition/v2/config/v3_6/config.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/coreos/ignition/v2/config/v3_6/translate/translate.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/coreos/ignition/v2/config/v3_6/types/cex.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/coreos/ignition/v2/config/v3_6/types/clevis.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/coreos/ignition/v2/config/v3_6/types/config.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/coreos/ignition/v2/config/v3_6/types/device.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/coreos/ignition/v2/config/v3_6/types/directory.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/coreos/ignition/v2/config/v3_6/types/disk.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/coreos/ignition/v2/config/v3_6/types/file.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/coreos/ignition/v2/config/v3_6/types/filesystem.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/coreos/ignition/v2/config/v3_6/types/headers.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/coreos/ignition/v2/config/v3_6/types/ignition.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/coreos/ignition/v2/config/v3_6/types/kargs.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/coreos/ignition/v2/config/v3_6/types/luks.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/coreos/ignition/v2/config/v3_6/types/mode.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/coreos/ignition/v2/config/v3_6/types/node.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/coreos/ignition/v2/config/v3_6/types/partition.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/coreos/ignition/v2/config/v3_6/types/passwd.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/coreos/ignition/v2/config/v3_6/types/path.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/coreos/ignition/v2/config/v3_6/types/proxy.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/coreos/ignition/v2/config/v3_6/types/raid.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/coreos/ignition/v2/config/v3_6/types/resource.go is excluded by !vendor/**, !**/vendor/**
📒 Files selected for processing (37)
  • go.mod
  • pkg/asset/agent/image/ignition.go
  • pkg/asset/agent/image/ignition_test.go
  • pkg/asset/agent/image/unconfigured_ignition.go
  • pkg/asset/agent/joiner/clusterinfo.go
  • pkg/asset/agent/joiner/clusterinfo_test.go
  • pkg/asset/cluster/tfvars/tfvars.go
  • pkg/asset/ignition/bootstrap/bootstrap_ignition.go
  • pkg/asset/ignition/bootstrap/bootstrap_ignition_test.go
  • pkg/asset/ignition/bootstrap/common.go
  • pkg/asset/ignition/bootstrap/ibmcloud/storage.go
  • pkg/asset/ignition/machine/arbiter.go
  • pkg/asset/ignition/machine/arbiter_ignition_customizations_test.go
  • pkg/asset/ignition/machine/master.go
  • pkg/asset/ignition/machine/node.go
  • pkg/asset/ignition/machine/worker.go
  • pkg/asset/ignition/node.go
  • pkg/asset/imagebased/image/ignition.go
  • pkg/asset/imagebased/image/ignition_test.go
  • pkg/asset/machines/arbiter_test.go
  • pkg/asset/machines/machineconfig/authorizedkeys.go
  • pkg/asset/machines/machineconfig/chrony.go
  • pkg/asset/machines/machineconfig/disks.go
  • pkg/asset/machines/machineconfig/disks_test.go
  • pkg/asset/machines/machineconfig/fips.go
  • pkg/asset/machines/machineconfig/hyperthreading.go
  • pkg/asset/machines/machineconfig/ipv6.go
  • pkg/asset/machines/machineconfig/multipath.go
  • pkg/asset/machines/machineconfig/powersmt.go
  • pkg/asset/machines/machineconfig/routes.go
  • pkg/asset/machines/master_test.go
  • pkg/asset/machines/worker_test.go
  • pkg/infrastructure/baremetal/bootstrap.go
  • pkg/infrastructure/clusterapi/helpers.go
  • pkg/infrastructure/clusterapi/ignition.go
  • pkg/infrastructure/openstack/preprovision/bootstrapignition.go
  • pkg/types/nutanix/helpers.go
✅ Files skipped from review due to trivial changes (18)
  • pkg/asset/ignition/bootstrap/bootstrap_ignition.go
  • pkg/infrastructure/clusterapi/helpers.go
  • pkg/asset/machines/worker_test.go
  • pkg/asset/machines/master_test.go
  • pkg/asset/ignition/machine/node.go
  • pkg/asset/machines/machineconfig/hyperthreading.go
  • pkg/infrastructure/clusterapi/ignition.go
  • pkg/asset/machines/machineconfig/chrony.go
  • pkg/asset/ignition/machine/arbiter_ignition_customizations_test.go
  • pkg/asset/ignition/bootstrap/bootstrap_ignition_test.go
  • pkg/asset/machines/machineconfig/routes.go
  • pkg/asset/machines/arbiter_test.go
  • pkg/asset/agent/image/ignition_test.go
  • pkg/asset/machines/machineconfig/powersmt.go
  • pkg/infrastructure/openstack/preprovision/bootstrapignition.go
  • pkg/asset/ignition/machine/master.go
  • pkg/asset/machines/machineconfig/ipv6.go
  • pkg/infrastructure/baremetal/bootstrap.go
🚧 Files skipped from review as they are similar to previous changes (16)
  • pkg/asset/agent/image/ignition.go
  • pkg/asset/cluster/tfvars/tfvars.go
  • pkg/asset/agent/image/unconfigured_ignition.go
  • pkg/asset/agent/joiner/clusterinfo.go
  • pkg/asset/ignition/bootstrap/ibmcloud/storage.go
  • pkg/asset/machines/machineconfig/multipath.go
  • pkg/asset/agent/joiner/clusterinfo_test.go
  • pkg/asset/machines/machineconfig/fips.go
  • pkg/asset/machines/machineconfig/disks_test.go
  • pkg/asset/machines/machineconfig/authorizedkeys.go
  • pkg/asset/imagebased/image/ignition_test.go
  • pkg/asset/ignition/machine/arbiter.go
  • pkg/asset/imagebased/image/ignition.go
  • pkg/asset/ignition/machine/worker.go
  • pkg/asset/ignition/bootstrap/common.go
  • pkg/asset/ignition/node.go

The latest ignition contains the API addtion to deploy confidential
clusters.

Signed-off-by: Alice Frosi <afrosi@redhat.com>
Signed-off-by: Fangge Jin <fjin@redhat.com>
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 23, 2026

@fangge1212: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-ovn ae49915 link true /test e2e-gcp-ovn
ci/prow/e2e-agent-compact-ipv4-appliance-diskimage ae49915 link false /test e2e-agent-compact-ipv4-appliance-diskimage
ci/prow/e2e-agent-5control-ipv4 ae49915 link false /test e2e-agent-5control-ipv4
ci/prow/e2e-aws-ovn ae49915 link true /test e2e-aws-ovn
ci/prow/e2e-agent-two-node-fencing-ipv4 ae49915 link false /test e2e-agent-two-node-fencing-ipv4
ci/prow/e2e-metal-ipi-ovn-dualstack ae49915 link false /test e2e-metal-ipi-ovn-dualstack
ci/prow/e2e-agent-compact-ipv4-none-platform ae49915 link false /test e2e-agent-compact-ipv4-none-platform
ci/prow/e2e-azure-ovn-shared-vpc ae49915 link false /test e2e-azure-ovn-shared-vpc
ci/prow/e2e-metal-assisted ae49915 link false /test e2e-metal-assisted
ci/prow/azure-private ae49915 link false /test azure-private
ci/prow/e2e-agent-compact-ipv6-minimaliso ae49915 link false /test e2e-agent-compact-ipv6-minimaliso
ci/prow/e2e-gcp-ovn-byo-vpc ae49915 link false /test e2e-gcp-ovn-byo-vpc
ci/prow/e2e-azure-default-config ae49915 link false /test e2e-azure-default-config
ci/prow/e2e-openstack-ovn ae49915 link true /test e2e-openstack-ovn
ci/prow/e2e-gcp-xpn-dedicated-dns-project ae49915 link false /test e2e-gcp-xpn-dedicated-dns-project
ci/prow/e2e-metal-ipi-ovn ae49915 link false /test e2e-metal-ipi-ovn
ci/prow/e2e-nutanix-ovn ae49915 link false /test e2e-nutanix-ovn
ci/prow/e2e-gcp-secureboot ae49915 link false /test e2e-gcp-secureboot
ci/prow/e2e-metal-ovn-two-node-arbiter ae49915 link false /test e2e-metal-ovn-two-node-arbiter
ci/prow/e2e-gcp-custom-dns ae49915 link false /test e2e-gcp-custom-dns
ci/prow/openstack-manifests ae49915 link true /test openstack-manifests
ci/prow/azure-ovn-marketplace-images ae49915 link false /test azure-ovn-marketplace-images
ci/prow/e2e-gcp-default-config ae49915 link false /test e2e-gcp-default-config
ci/prow/e2e-gcp-xpn-custom-dns ae49915 link false /test e2e-gcp-xpn-custom-dns
ci/prow/e2e-ibmcloud-ovn ae49915 link false /test e2e-ibmcloud-ovn
ci/prow/e2e-agent-sno-ipv6 ae49915 link false /test e2e-agent-sno-ipv6
ci/prow/e2e-agent-compact-ipv4 ae49915 link true /test e2e-agent-compact-ipv4
ci/prow/e2e-gcp-custom-endpoints ae49915 link false /test e2e-gcp-custom-endpoints
ci/prow/e2e-gcp-ovn-xpn ae49915 link false /test e2e-gcp-ovn-xpn
ci/prow/e2e-agent-4control-ipv4 ae49915 link false /test e2e-agent-4control-ipv4
ci/prow/e2e-openstack-nfv-intel ae49915 link false /test e2e-openstack-nfv-intel
ci/prow/e2e-metal-ipi-ovn-swapped-hosts ae49915 link false /test e2e-metal-ipi-ovn-swapped-hosts
ci/prow/e2e-agent-sno-ipv4-pxe ae49915 link false /test e2e-agent-sno-ipv4-pxe
ci/prow/gcp-private ae49915 link false /test gcp-private
ci/prow/e2e-metal-ipi-ovn-virtualmedia ae49915 link false /test e2e-metal-ipi-ovn-virtualmedia
ci/prow/e2e-openstack-proxy ae49915 link false /test e2e-openstack-proxy
ci/prow/e2e-metal-ovn-two-node-fencing ae49915 link false /test e2e-metal-ovn-two-node-fencing
ci/prow/e2e-agent-ha-dualstack ae49915 link false /test e2e-agent-ha-dualstack
ci/prow/e2e-azure-ovn ae49915 link true /test e2e-azure-ovn
ci/prow/e2e-metal-single-node-live-iso ae49915 link false /test e2e-metal-single-node-live-iso
ci/prow/e2e-azurestack ae49915 link false /test e2e-azurestack
ci/prow/e2e-metal-ipi-ovn-ipv6 ae49915 link true /test e2e-metal-ipi-ovn-ipv6
ci/prow/gcp-custom-endpoints-proxy-wif ae49915 link false /test gcp-custom-endpoints-proxy-wif
ci/prow/e2e-agent-compact-ipv4-iso-no-registry ae49915 link false /test e2e-agent-compact-ipv4-iso-no-registry

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@rna-afk
Copy link
Contributor

rna-afk commented Mar 23, 2026

PR needs the two fixes I mentioned in the other PR. Version change from 3.2 to 3.6.

AWSmachines file

clusterapi file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants