OCPBUGS-77917: PowerVS: Use short regions and provide a default resource group in survey by AshwinHIBM · Pull Request #10369 · openshift/installer

AshwinHIBM · 2026-03-07T15:45:06Z

Provide default region and resource groups that are a part of the options presented to the user during the survey. This is required because it is expected that the default option is a part of the list of options as per https://github.com/AlecAivazis/survey/blob/master/select.go#L232:L238

AshwinHIBM · 2026-03-07T19:13:29Z

/test e2e-powervs-capi-ovn

openshift-ci-robot · 2026-03-31T09:34:20Z

@AshwinHIBM: This pull request references Jira Issue OCPBUGS-77917, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.22.0) matches configured target version for branch (4.22.0)
bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Provide default region and resource groups that are a part of the options presented to the user during the survey. This is required because it is expected that the default option is a part of the list of options as per https://github.com/AlecAivazis/survey/blob/master/select.go#L232:L238

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

coderabbitai · 2026-03-31T09:34:33Z

Important

Review skipped

Auto reviews are limited based on label configuration.

🚫 Review skipped — only excluded labels are configured. (1)

do-not-merge/work-in-progress

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: b8395998-532e-4b76-b527-a6e8b20aa64e

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

AshwinHIBM · 2026-03-31T09:34:42Z

/verified by @AshwinHIBM

openshift-ci-robot · 2026-03-31T09:34:56Z

@AshwinHIBM: This PR has been marked as verified by @AshwinHIBM.

Details

In response to this:

/verified by @AshwinHIBM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

mjturek · 2026-03-31T15:34:36Z

/lgtm

mjturek · 2026-03-31T15:34:43Z

/approve

mjturek · 2026-03-31T21:33:16Z

/approved

mjturek · 2026-04-01T18:43:37Z

/test okd-scos-images

mjturek · 2026-04-01T18:44:12Z

/approve

rna-afk · 2026-04-09T16:21:41Z

/approve

openshift-ci · 2026-04-09T16:22:13Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mjturek, rna-afk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~pkg/asset/installconfig/powervs/OWNERS~~ [mjturek,rna-afk]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

rna-afk · 2026-04-09T18:05:33Z

-	sort.Strings(longRegions)
 	sort.Strings(shortRegions)

 	var regionTransform survey.Transformer = func(ans interface{}) interface{} {


Do we need this now since we moved to the short region?

openshift-merge-bot · 2026-04-09T20:26:24Z

/retest-required

Remaining retests: 0 against base HEAD 4acb8b9 and 2 for PR HEAD 96ce608 in total

openshift-ci · 2026-04-09T21:52:35Z

@AshwinHIBM: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-powervs-capi-ovn	`1e64b38`	link	false	`/test e2e-powervs-capi-ovn`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-merge-bot · 2026-04-10T05:25:41Z

/retest-required

Remaining retests: 0 against base HEAD 522ca80 and 1 for PR HEAD 96ce608 in total

openshift-ci-robot · 2026-04-10T10:45:28Z

@AshwinHIBM: Jira Issue Verification Checks: Jira Issue OCPBUGS-77917
✔️ This pull request was pre-merge verified.
✔️ All associated pull requests have merged.
✔️ All associated, merged pull requests were pre-merge verified.

Jira Issue OCPBUGS-77917 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓

Details

In response to this:

Provide default region and resource groups that are a part of the options presented to the user during the survey. This is required because it is expected that the default option is a part of the list of options as per https://github.com/AlecAivazis/survey/blob/master/select.go#L232:L238

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-merge-robot · 2026-04-12T00:51:23Z

Fix included in release 4.22.0-0.nightly-2026-04-11-163821

openshift-ci Bot requested review from mjturek and mkumatag March 7, 2026 15:46

prb112 reviewed Mar 8, 2026

View reviewed changes

Comment thread pkg/asset/installconfig/powervs/session.go Outdated

prb112 reviewed Mar 8, 2026

View reviewed changes

Comment thread pkg/asset/installconfig/powervs/session.go

AshwinHIBM force-pushed the survey-shortregions branch from 1e64b38 to 302e54c Compare March 8, 2026 11:16

Use short regions and provide a default resource group in survey

96ce608

AshwinHIBM force-pushed the survey-shortregions branch from 302e54c to 96ce608 Compare March 9, 2026 04:38

AshwinHIBM changed the title ~~Power VS: Use short regions and provide a default resource group in survey~~ OCPBUGS-77917: PowerVS: Use short regions and provide a default resource group in survey Mar 31, 2026

openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Mar 31, 2026

openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Mar 31, 2026

openshift-ci Bot assigned mjturek Mar 31, 2026

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Mar 31, 2026

openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 9, 2026

rna-afk reviewed Apr 9, 2026

View reviewed changes

openshift-merge-bot Bot merged commit 7454053 into openshift:main Apr 10, 2026
16 checks passed

Conversation

AshwinHIBM commented Mar 7, 2026

Uh oh!

AshwinHIBM commented Mar 7, 2026

Uh oh!

Uh oh!

Uh oh!

openshift-ci-robot commented Mar 31, 2026

Uh oh!

coderabbitai Bot commented Mar 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Uh oh!

AshwinHIBM commented Mar 31, 2026

Uh oh!

openshift-ci-robot commented Mar 31, 2026

Uh oh!

mjturek commented Mar 31, 2026

Uh oh!

mjturek commented Mar 31, 2026

Uh oh!

mjturek commented Mar 31, 2026

Uh oh!

mjturek commented Apr 1, 2026

Uh oh!

mjturek commented Apr 1, 2026

Uh oh!

rna-afk commented Apr 9, 2026

Uh oh!

openshift-ci Bot commented Apr 9, 2026

Uh oh!

rna-afk Apr 9, 2026

Choose a reason for hiding this comment

Uh oh!

openshift-merge-bot Bot commented Apr 9, 2026

Uh oh!

openshift-ci Bot commented Apr 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-merge-bot Bot commented Apr 10, 2026

Uh oh!

Uh oh!

openshift-ci-robot commented Apr 10, 2026

Uh oh!

openshift-merge-robot commented Apr 12, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

coderabbitai Bot commented Mar 31, 2026 •

edited

Loading

openshift-ci Bot commented Apr 9, 2026 •

edited

Loading