Skip to content

Conversation

@logonoff
Copy link
Member

@logonoff logonoff commented Jan 7, 2026

  • Bumped yup to 1.7.1 to remove hard @types/lodash dependency
  • Unit tests mostly AI generated, dependencies and optionalDependencies tests are hand written
  • Added Record<string, string> validation

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 7, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: logonoff

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 7, 2026
@logonoff logonoff force-pushed the yup branch 6 times, most recently from af57de9 to f6aacf5 Compare January 7, 2026 20:40
@codecov-commenter
Copy link

codecov-commenter commented Jan 7, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 17.38%. Comparing base (321e614) to head (74f8864).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #289      +/-   ##
==========================================
- Coverage   25.20%   17.38%   -7.82%     
==========================================
  Files          40       66      +26     
  Lines        1210     1875     +665     
  Branches      244      362     +118     
==========================================
+ Hits          305      326      +21     
- Misses        889     1533     +644     
  Partials       16       16              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@logonoff logonoff changed the title feat: bump yup to 1.7.1 chore(deps): bump yup to 1.7.1 Jan 7, 2026
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 7, 2026

@logonoff: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants