[release-4.22] OCPBUGS-85532: Add init container for Manila node daemonset by openshift-cherrypick-robot · Pull Request #555 · openshift/csi-operator

openshift-cherrypick-robot · 2026-05-13T18:36:31Z

This is an automated cherry-pick of #552

/assign openshift-ci-robot

The Manila CSI driver node plugin fatally exits on startup when the NFS CSI plugin socket (/var/lib/kubelet/plugins/csi-nfsplugin/csi.sock) is not yet available. After node disruptions, both DaemonSets restart concurrently and the Manila driver crashes because upstream ProbeForever only retries on DeadlineExceeded, not on Unavailable (connection refused). This causes excessive container restarts (>3), failing the CI invariant test. Add a wait-for-nfs-plugin init container to the Manila node DaemonSet that polls for the NFS plugin socket before allowing the csi-driver container to start. This ensures proper startup ordering between the two DaemonSets without requiring changes to the upstream driver.

openshift-ci-robot · 2026-05-13T18:36:36Z

@openshift-cherrypick-robot: Detected clone of Jira Issue OCPBUGS-85457 with correct target version. Will retitle the PR to link to the clone.
/retitle [release-4.22] OCPBUGS-85532: Add init container for Manila node daemonset

Details

In response to this:

This is an automated cherry-pick of #552

/assign openshift-ci-robot

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

coderabbitai · 2026-05-13T18:36:39Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 75784e5a-bd36-41f8-ab20-2a2b1332b374

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

openshift-ci-robot · 2026-05-13T18:36:54Z

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-85532, which is invalid:

release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

This is an automated cherry-pick of #552

/assign openshift-ci-robot

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

mandre · 2026-05-19T11:31:08Z

/jira refresh
/retest

openshift-ci-robot · 2026-05-19T11:31:16Z

@mandre: This pull request references Jira Issue OCPBUGS-85532, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.22.0) matches configured target version for branch (4.22.0)
bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
release note text is set and does not match the template
dependent bug Jira Issue OCPBUGS-85457 is in the state ON_QA, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
dependent Jira Issue OCPBUGS-85457 targets the "5.0.0" version, which is one of the valid target versions: 5.0.0
bug has dependents

Details

In response to this:

/jira refresh
/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

mandre

/lgtm
/approve
/backport-risk-assessed
/verified later @mandre

openshift-ci · 2026-05-19T13:39:06Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mandre, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [mandre]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

mandre · 2026-05-19T13:39:35Z

The HCP job is currently broken on openstack.
/override ci/prow/hypershift-e2e-openstack-aws-csi-manila

openshift-ci · 2026-05-19T13:40:03Z

@mandre: Overrode contexts on behalf of mandre: ci/prow/hypershift-e2e-openstack-aws-csi-manila

Details

In response to this:

The HCP job is currently broken on openstack.
/override ci/prow/hypershift-e2e-openstack-aws-csi-manila

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-ci · 2026-05-19T13:40:04Z

@openshift-cherrypick-robot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/hypershift-e2e-openstack-aws-csi-manila	`6478596`	link	true	`/test hypershift-e2e-openstack-aws-csi-manila`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

mandre · 2026-05-19T15:00:30Z

/label backport-risk-assessed

mandre · 2026-05-19T15:00:50Z

/verified later @mandre

openshift-ci-robot · 2026-05-19T15:01:07Z

@mandre: This PR has been marked to be verified later by @mandre.

Details

In response to this:

/verified later @mandre

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci · 2026-05-19T15:01:14Z

@mandre: The label(s) backport-risk-assessed cannot be applied or removed, because you are not in one of the allowed teams and are not an allowed user. Must be a member of one of these teams: openshift-patch-managers, openshift-release-oversight, openshift-staff-engineers, openshift-sustaining-engineers

Details

In response to this:

/label backport-risk-assessed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

stephenfin · 2026-05-19T15:03:35Z

/label backport-risk-assessed

openshift-ci · 2026-05-19T15:04:45Z

@stephenfin: The label(s) backport-risk-assessed cannot be applied or removed, because you are not in one of the allowed teams and are not an allowed user. Must be a member of one of these teams: openshift-patch-managers, openshift-release-oversight, openshift-staff-engineers, openshift-sustaining-engineers

Details

In response to this:

/label backport-risk-assessed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

mpatlasov · 2026-05-19T23:15:23Z

/label backport-risk-assessed

openshift-ci-robot · 2026-05-19T23:25:29Z

@openshift-cherrypick-robot: Jira Issue OCPBUGS-85532: All pull requests linked via external trackers have merged:

openshift/csi-operator#555

This pull request has the verified-later tag and will need to be manually moved to VERIFIED after testing. Jira Issue OCPBUGS-85532 has been moved to the MODIFIED state.

Details

In response to this:

This is an automated cherry-pick of #552

/assign openshift-ci-robot

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-merge-robot · 2026-05-20T08:25:44Z

Fix included in release 4.22.0-0.nightly-2026-05-20-020825

openshift-cherrypick-robot assigned openshift-ci-robot May 13, 2026

openshift-cherrypick-robot mentioned this pull request May 13, 2026

OCPBUGS-85457: Add init container for Manila node daemonset #552

Merged

openshift-ci Bot changed the title ~~[release-4.22] OCPBUGS-85457: Add init container for Manila node daemonset~~ [release-4.22] OCPBUGS-85532: Add init container for Manila node daemonset May 13, 2026

openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels May 13, 2026

openshift-ci Bot requested review from jsafrane and mpatlasov May 13, 2026 18:37

openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels May 19, 2026

mandre reviewed May 19, 2026

View reviewed changes

openshift-ci Bot assigned mandre May 19, 2026

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label May 19, 2026

openshift-ci Bot assigned radeore May 19, 2026

openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 19, 2026

openshift-ci-robot added verified-later verified Signifies that the PR passed pre-merge verification criteria labels May 19, 2026

openshift-ci Bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label May 19, 2026

openshift-merge-bot Bot merged commit 08c62f7 into openshift:release-4.22 May 19, 2026
24 checks passed

Conversation

openshift-cherrypick-robot commented May 13, 2026

Uh oh!

openshift-ci-robot commented May 13, 2026

Uh oh!

coderabbitai Bot commented May 13, 2026

Review skipped

Uh oh!

openshift-ci-robot commented May 13, 2026

Uh oh!

mandre commented May 19, 2026

Uh oh!

openshift-ci-robot commented May 19, 2026

Uh oh!

mandre left a comment

Choose a reason for hiding this comment

Uh oh!

openshift-ci Bot commented May 19, 2026

Uh oh!

mandre commented May 19, 2026

Uh oh!

openshift-ci Bot commented May 19, 2026

Uh oh!

openshift-ci Bot commented May 19, 2026

Uh oh!

mandre commented May 19, 2026

Uh oh!

mandre commented May 19, 2026

Uh oh!

openshift-ci-robot commented May 19, 2026

Uh oh!

openshift-ci Bot commented May 19, 2026

Uh oh!

stephenfin commented May 19, 2026

Uh oh!

openshift-ci Bot commented May 19, 2026

Uh oh!

mpatlasov commented May 19, 2026

Uh oh!

Uh oh!

openshift-ci-robot commented May 19, 2026

Uh oh!

openshift-merge-robot commented May 20, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants