Skip to content

NO-JIRA: Normalize generation of driver metrics RBAC proxy sidecar (extended) #434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
stephenfin wants to merge 1 commit into
base: main
Choose a base branch
from
Open

NO-JIRA: Normalize generation of driver metrics RBAC proxy sidecar (extended) #434

stephenfin wants to merge 1 commit into from

Conversation

@stephenfin
Copy link
Contributor

@stephenfin stephenfin commented Sep 24, 2025

This builds on #380 by changing the name of the proxy sidecar used for driver metrics.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Sep 24, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 24, 2025

@stephenfin: This pull request explicitly references no jira issue.

Details

In response to this:

This builds on #380 by changing the name of the proxy sidecar used for driver metrics.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@stephenfin stephenfin marked this pull request as draft September 24, 2025 15:40
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 24, 2025
@openshift-ci openshift-ci bot requested review from dobsonj and mpatlasov September 24, 2025 15:41
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 24, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: stephenfin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 24, 2025
@stephenfin
Copy link
Contributor Author

stephenfin commented Oct 23, 2025

/retest

@stephenfin stephenfin marked this pull request as ready for review October 30, 2025 11:19
@stephenfin
Copy link
Contributor Author

stephenfin commented Oct 30, 2025

/retest

@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 30, 2025
@openshift-ci openshift-ci bot requested review from gnufied and jsafrane October 30, 2025 11:20
@stephenfin stephenfin force-pushed the normalize-driver-metrics branch from 6764a2c to 43f6569 Compare October 30, 2025 11:21
@stephenfin
assets: Change name of driver metrics sidecar
35ad859 
This aligns us closer with the other sidecar containers' own metrics
sidecars.

Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
@stephenfin stephenfin force-pushed the normalize-driver-metrics branch from 43f6569 to 35ad859 Compare December 6, 2025 22:03
@stephenfin
Copy link
Contributor Author

stephenfin commented Dec 7, 2025

/test e2e-openstack

1 similar comment
@stephenfin
Copy link
Contributor Author

stephenfin commented Dec 7, 2025

/test e2e-openstack

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 7, 2025

@stephenfin: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-openstack 35ad859 link false /test e2e-openstack
ci/prow/hypershift-e2e-openstack-aws-csi-cinder 35ad859 link true /test hypershift-e2e-openstack-aws-csi-cinder
ci/prow/e2e-openstack-cinder-csi 35ad859 link true /test e2e-openstack-cinder-csi
ci/prow/hypershift-e2e-aks 35ad859 link true /test hypershift-e2e-aks
ci/prow/e2e-azurestack-csi 35ad859 link false /test e2e-azurestack-csi

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dobsonj dobsonj Awaiting requested review from dobsonj

@mpatlasov mpatlasov Awaiting requested review from mpatlasov

@gnufied gnufied Awaiting requested review from gnufied

@jsafrane jsafrane Awaiting requested review from jsafrane

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@stephenfin @openshift-ci-robot