CONSOLE-4991: Reenable all unit tests#16025
Conversation
|
@logonoff: This pull request references CONSOLE-4991 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
📝 WalkthroughWalkthroughThis pull request systematically migrates test files across OpenShift Console frontend packages from direct 🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
No actionable comments were generated in the recent review. 🎉 Comment |
|
@logonoff: This pull request references CONSOLE-4991 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
| it('does not display save and reload buttons without permission', () => { | ||
| it('does not display save and reload buttons without permission', async () => { | ||
| renderWithProviders( |
There was a problem hiding this comment.
@krishagarwal278 FYI since this was skipped in #15751
| // Disabling as this test is flaking. @vikram-raj to investigate. | ||
| xit('should submit right form data when user fills out an image stream tag', async () => { | ||
| it('should submit right form data when user fills out an image stream tag', async () => { | ||
| const user = userEvent.setup(); |
There was a problem hiding this comment.
@vikram-raj @rhamilto FYI since this was skipped during the PF6 upgrade
|
test only changes: |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: logonoff The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@logonoff: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
environment.spec.tsxtests were broken because the mocked redux store didn't include the DeploymentModel used for rbac (according to claude). this has been addedbuildconfigtests were because userEvent.type is a slow method (it types each letter one by one which can be slow to simulate, especially if CI is overloaded). We can't really get around this, but we can increase the jest timeout which is what I've doneuserEventto the setup pattern recommended in the latest version.Summary by CodeRabbit