CONSOLE-5063: Remove AppInitSDK (WIP)#16019
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@logonoff: This pull request references CONSOLE-5063 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
logonoff
force-pushed
the
CONSOLE-5063-s3e7-branch-closing
branch
2 times, most recently
from
c549689 to
a5a76ad
Compare
|
@logonoff: This pull request references CONSOLE-5063 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: logonoff The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
component/sdk
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: logonoff The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/label px-approved |
openshift-ci
bot
added
px-approved
|
@logonoff: This pull request references CONSOLE-5063 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
logonoff
force-pushed
the
CONSOLE-5063-s3e7-branch-closing
branch
from
a5a76ad to
4a8b11d
Compare
frontend/public/module/auth.ts
Outdated
| logoutURL, | ||
| } = window.SERVER_FLAGS; | ||
| // type cast to prevent missing properties errors when building with limited SDK types | ||
| } = (window.SERVER_FLAGS as unknown) as Record<string, string>; |
There was a problem hiding this comment.
I can look into this, maybe it's related to some other type issue.
logonoff
force-pushed
the
CONSOLE-5063-s3e7-branch-closing
branch
from
4a8b11d to
081f4a7
Compare
logonoff
force-pushed
the
CONSOLE-5063-s3e7-branch-closing
branch
from
081f4a7 to
5043883
Compare
|
@logonoff: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
3 participants
useReduxStoreremoved, reverted fallback redux store creation added in enable redux store context in SDK from app host #10448coFetch-related code moved entirely to dynamic-plugin-sdk package to follow up on Convert coFetch utilities to typescript and move to plugin SDK #9660utilsConfigremoved, reverted coFetch sourcing via dependency injection added in enable redux store context in SDK from app host #10448storeHandlerobject directly after initializing our redux storeinitConsolePluginsnow called directly after initializing PluginStore (speeding up loading times slightly)