OCPBUGS-74557: Fixed Metrics page React error #306 by exporting QueryBrowser component#16016
OCPBUGS-74557: Fixed Metrics page React error #306 by exporting QueryBrowser component#16016krishagarwal278 wants to merge 1 commit intoopenshift:mainfrom
Conversation
…ing QueryBrowser component
|
@krishagarwal278: This pull request references Jira Issue OCPBUGS-74557, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: krishagarwal278 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
📝 WalkthroughWalkthroughThis pull request expands the public API surface of the console-shared components package by re-exporting the 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
No actionable comments were generated in the recent review. 🎉 Tip Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord. Comment |
logonoff
left a comment
There was a problem hiding this comment.
what components are importing from console shared root barrel that require this? can we rewrite the imports instead of writing an export?
|
/jira refresh |
|
@krishagarwal278: This pull request references Jira Issue OCPBUGS-74557, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/retest |
1 similar comment
|
/retest |
|
@krishagarwal278: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |


Summary by CodeRabbit