Skip to content

Conversation

@sowmya-sl
Copy link

@sowmya-sl sowmya-sl commented Dec 18, 2025

Add dedicated endpoint and handler for installing Helm charts from OCI
registries. This provides a simplified installation flow for OCI charts
that doesn't require HelmChartRepository lookup.

Changes:

  • Add InstallOCIChart function in actions for OCI-only installations
  • Add HandleInstallOCIChart handler with OCI URL validation
  • Register /api/helm/oci-chart endpoint in server routes
  • Add tests for both the methods

HELM-598

OCI-based Helm charts were failing to install because the action
configuration lacked a registry client. This change:

- Add GetDefaultOCIRegistry() to create and attach a registry client
  to the Helm action configuration
- Integrate registry client initialization into all Helm handlers:
  install, upgrade, uninstall, rollback, and chart get operations
- Add unit tests for the new registry client function
- Update older tests to use mock registry Client function

Without a registry client, operations on OCI charts (oci://) would fail
with errors about missing registry support.

Fixes: HELM-611
Add dedicated endpoint and handler for installing Helm charts from OCI
registries. This provides a simplified installation flow for OCI charts
that doesn't require HelmChartRepository lookup.

Changes:
- Add InstallOCIChart function in actions for OCI-only installations
- Add HandleInstallOCIChart handler with OCI URL validation
- Register /api/helm/oci-chart endpoint in server routes
- Add tests for both the methods

HELM-598
@coderabbitai
Copy link

coderabbitai bot commented Dec 18, 2025

Important

Review skipped

Auto reviews are limited based on label configuration.

🚫 Excluded labels (none allowed) (1)
  • do-not-merge/work-in-progress

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 18, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 18, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added the component/backend Related to backend label Dec 18, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 18, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sowmya-sl
Once this PR has been reviewed and has the lgtm label, please assign jhadvig for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

- Add zot server scripts (zot.sh, zotWithoutTls.sh, zot-stop.sh) and zot configuration files for TLS and non-TLS modes.
- Add downloadHelm.sh to download helm v3.19.0 for OCI chart uploads.
- Update GetOCIRegistry to support insecure TLS and plain HTTP modes. These modes are necessary as we are self hosting the oci registry for test.
- Add TestInstallOCIChart test cases for OCI registries.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component/backend Related to backend do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant