Skip to content

Conversation

@vikram-raj
Copy link
Member

Before:
image

image

After:

image

@openshift-ci-robot openshift-ci-robot added jira/severity-low Referenced Jira bug's severity is low for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Dec 1, 2025
@openshift-ci-robot
Copy link
Contributor

@vikram-raj: This pull request references Jira Issue OCPBUGS-62261, which is invalid:

  • expected the bug to target the "4.21.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Before:
image

image

After:

image

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai
Copy link

coderabbitai bot commented Dec 1, 2025

Walkthrough

This PR removes extraneous semicolons after JSX elements in two component files (BrokerRow.tsx and ChannelRow.tsx), restoring valid JSX syntax. No functional changes to component logic, rendering, or exports.

Changes

Cohort / File(s) Summary
Semicolon cleanup in JSX elements
frontend/packages/knative-plugin/src/components/eventing/brokers-list/BrokerRow.tsx, frontend/packages/knative-plugin/src/components/eventing/channels-list/ChannelRow.tsx
Removed extraneous semicolons after LazyActionMenu JSX elements within TableData cells. No changes to component logic, rendering, or data flow.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

  • Both changes are simple, repetitive punctuation fixes with no logical complexity
  • Cosmetic syntax correction with no functional impact
  • Same pattern applied consistently across two files
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Cache: Disabled due to data retention organization setting

Knowledge base: Disabled due to Reviews -> Disable Knowledge Base setting

📥 Commits

Reviewing files that changed from the base of the PR and between 971f0fa and 9c5ba11.

📒 Files selected for processing (2)
  • frontend/packages/knative-plugin/src/components/eventing/brokers-list/BrokerRow.tsx (1 hunks)
  • frontend/packages/knative-plugin/src/components/eventing/channels-list/ChannelRow.tsx (1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
**

⚙️ CodeRabbit configuration file

-Focus on major issues impacting performance, readability, maintainability and security. Avoid nitpicks and avoid verbosity.

Files:

  • frontend/packages/knative-plugin/src/components/eventing/brokers-list/BrokerRow.tsx
  • frontend/packages/knative-plugin/src/components/eventing/channels-list/ChannelRow.tsx
🧬 Code graph analysis (2)
frontend/packages/knative-plugin/src/components/eventing/brokers-list/BrokerRow.tsx (1)
frontend/packages/console-dynamic-plugin-sdk/src/api/internal-api.ts (1)
  • LazyActionMenu (67-68)
frontend/packages/knative-plugin/src/components/eventing/channels-list/ChannelRow.tsx (1)
frontend/packages/console-dynamic-plugin-sdk/src/api/internal-api.ts (1)
  • LazyActionMenu (67-68)
🔇 Additional comments (2)
frontend/packages/knative-plugin/src/components/eventing/brokers-list/BrokerRow.tsx (1)

35-37: JSX cleanup looks good

Removing the trailing semicolon after <LazyActionMenu context={context} /> results in clean, valid JSX with no behavior change. Consistent with other usages of LazyActionMenu.

frontend/packages/knative-plugin/src/components/eventing/channels-list/ChannelRow.tsx (1)

45-47: Consistent JSX syntax fix

The removal of the trailing semicolon after <LazyActionMenu context={context} /> is correct and keeps this row consistent with BrokerRow and other JSX usage.


Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci bot added component/knative Related to knative-plugin approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Dec 1, 2025
@vikram-raj
Copy link
Member Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Dec 1, 2025
@openshift-ci-robot
Copy link
Contributor

@vikram-raj: This pull request references Jira Issue OCPBUGS-62261, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.21.0) matches configured target version for branch (4.21.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @yapei

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from yapei December 1, 2025 10:35
Copy link
Member

@logonoff logonoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Member

@jhadvig jhadvig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 1, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 1, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jhadvig, logonoff, vikram-raj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@vikram-raj
Copy link
Member Author

/verified later @yapei

@openshift-ci-robot openshift-ci-robot added verified-later verified Signifies that the PR passed pre-merge verification criteria labels Dec 1, 2025
@openshift-ci-robot
Copy link
Contributor

@vikram-raj: This PR has been marked to be verified later by @yapei.

Details

In response to this:

/verified later @yapei

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 383f995 and 2 for PR HEAD 9c5ba11 in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 1, 2025

@vikram-raj: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 8e655e0 into openshift:main Dec 2, 2025
8 checks passed
@openshift-ci-robot
Copy link
Contributor

@vikram-raj: Jira Issue OCPBUGS-62261: All pull requests linked via external trackers have merged:

This pull request has the verified-later tag and will need to be manually moved to VERIFIED after testing. Jira Issue OCPBUGS-62261 has been moved to the MODIFIED state.

Details

In response to this:

Before:
image

image

After:

image

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@vikram-raj vikram-raj deleted the ocpbugs-62261 branch December 4, 2025 06:10
@openshift-merge-robot
Copy link
Contributor

Fix included in accepted release 4.21.0-0.nightly-2025-12-08-112148

@vikram-raj
Copy link
Member Author

/cherry-pick release-4.20

@openshift-cherrypick-robot

@vikram-raj: new pull request created: #15834

Details

In response to this:

/cherry-pick release-4.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. component/knative Related to knative-plugin jira/severity-low Referenced Jira bug's severity is low for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria verified-later

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants