OCPBUGS-65765, OCPBUGS-65678: apiVersion is empty on YAML creation page - Runtime error occurs when create MachineConfig with default yaml from… #15763

cajieh · 2025-11-24T15:46:54Z

… console

openshift-ci-robot · 2025-11-24T15:47:03Z

@cajieh: This pull request references Jira Issue OCPBUGS-65678, which is invalid:

expected the bug to target the "4.21.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

… console

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

coderabbitai · 2025-11-24T15:47:12Z

Walkthrough

Added two new default YAML templates (MachineConfigModel and ServiceMonitorModel) to the YAML templates file, and adjusted the default-template detection in the Create YAML component to use the resolved template when calculating isDefaultTemplate. No exported APIs were changed.

Changes

Cohort / File(s)	Summary
YAML template additions `frontend/public/models/yaml-templates.ts`	Added two new default templates: a MachineConfigModel template containing an OpenShift MachineConfig manifest with ignition version, storage files, and a sample `/etc/example-config` file; and a ServiceMonitorModel template containing a ServiceMonitor manifest with a basic app selector and endpoint configuration.
Create YAML behavior tweak `frontend/public/components/create-yaml.tsx`	In `CreateYAMLInner`, changed the `isDefaultTemplate` calculation to compare against `resolvedTemplate` instead of `template`, aligning the default check with how `resolvedTemplate` is chosen and used elsewhere.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Review YAML manifest syntax and ensure indentation/escaping and resource fields match expected schemas for MachineConfig and ServiceMonitor.
Validate the ignition storage/file content and keys (paths, permissions) for MachineConfig template.
Verify the ServiceMonitor template matches PrometheusOperator expectations (selector, endpoints).
Confirm the isDefaultTemplate change doesn't alter UI flows unexpectedly (template selection, initial resource rendering).

✨ Finishing touches

📝 Generate docstrings

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Cache: Disabled due to data retention organization setting

Knowledge base: Disabled due to Reviews -> Disable Knowledge Base setting

📥 Commits

Reviewing files that changed from the base of the PR and between 36ec7c3 and b4e519c.

📒 Files selected for processing (2)

frontend/public/components/create-yaml.tsx (1 hunks)
frontend/public/models/yaml-templates.ts (2 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

frontend/public/models/yaml-templates.ts

🧰 Additional context used

📓 Path-based instructions (1)

**

⚙️ CodeRabbit configuration file

-Focus on major issues impacting performance, readability, maintainability and security. Avoid nitpicks and avoid verbosity.

Files:

frontend/public/components/create-yaml.tsx

🔇 Additional comments (1)

frontend/public/components/create-yaml.tsx (1)

66-67: Bug fix correctly aligns default template detection with resolved template.

The change fixes a logic error where isDefaultTemplate was comparing the template prop (often undefined when no custom template is provided) instead of the resolvedTemplate that's actually used. When template is undefined, the fallback chain resolves to either a model-specific or DEFAULT template, but the old check would incorrectly return false. This prevented the apiVersion override (lines 77-78) from being applied, likely causing the runtime error mentioned in the PR title when creating resources with the default template.

The fix correctly identifies when the DEFAULT template is being used after resolution.

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

cajieh · 2025-11-24T15:48:03Z

/jira refresh

openshift-ci-robot · 2025-11-24T15:48:11Z

@cajieh: This pull request references Jira Issue OCPBUGS-65678, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.21.0) matches configured target version for branch (4.21.0)
bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @yapei

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

… console

openshift-ci-robot · 2025-11-24T16:11:31Z

@cajieh: This pull request references Jira Issue OCPBUGS-65765, which is invalid:

expected the bug to target the "4.21.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

This pull request references Jira Issue OCPBUGS-65678, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.21.0) matches configured target version for branch (4.21.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @yapei

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

… console

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

logonoff · 2025-12-02T19:33:23Z

/jira refresh

openshift-ci-robot · 2025-12-02T19:33:29Z

@logonoff: This pull request references Jira Issue OCPBUGS-65765, which is invalid:

expected the bug to target the "4.21.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

This pull request references Jira Issue OCPBUGS-65678, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.21.0) matches configured target version for branch (4.21.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @yapei

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

logonoff · 2025-12-02T19:34:05Z

/jira refresh

openshift-ci-robot · 2025-12-02T19:34:15Z

@logonoff: This pull request references Jira Issue OCPBUGS-65765, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.21.0) matches configured target version for branch (4.21.0)
bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @yapei

This pull request references Jira Issue OCPBUGS-65678, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.21.0) matches configured target version for branch (4.21.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @yapei

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Leo6Leo · 2025-12-09T16:17:24Z

/retest-required

openshift-ci-robot · 2025-12-10T01:05:38Z

/retest-required

Remaining retests: 0 against base HEAD d93076f and 0 for PR HEAD b4e519c in total

openshift-ci-robot · 2025-12-10T06:05:36Z

/hold

Revision b4e519c was retested 3 times: holding

Leo6Leo · 2025-12-11T13:55:57Z

/retest-required

Leo6Leo · 2025-12-11T18:18:34Z

/retest-required

openshift-bot · 2025-12-12T08:26:55Z

/jira refresh

The requirements for Jira bugs have changed (Jira issues linked to PRs on main branch need to target different OCP), recalculating validity.

openshift-ci-robot · 2025-12-12T08:28:29Z

@openshift-bot: This pull request references Jira Issue OCPBUGS-65765, which is invalid:

expected the bug to target either version "4.22." or "openshift-4.22.", but it targets "4.21.0" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

This pull request references Jira Issue OCPBUGS-65678, which is invalid:

expected the bug to target either version "4.22." or "openshift-4.22.", but it targets "4.21.0" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

The requirements for Jira bugs have changed (Jira issues linked to PRs on main branch need to target different OCP), recalculating validity.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Leo6Leo · 2025-12-12T14:48:50Z

/retest-required

cajieh · 2025-12-15T09:43:23Z

/test e2e-gcp-console

cajieh · 2025-12-15T09:47:35Z

/jira refresh

openshift-ci-robot · 2025-12-15T09:47:40Z

@cajieh: This pull request references Jira Issue OCPBUGS-65765, which is invalid:

expected the bug to target either version "4.22." or "openshift-4.22.", but it targets "4.21.0" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

This pull request references Jira Issue OCPBUGS-65678, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.22.0) matches configured target version for branch (4.22.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @yapei

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

cajieh · 2025-12-15T09:49:19Z

/jira refresh

openshift-ci-robot · 2025-12-15T09:49:27Z

@cajieh: This pull request references Jira Issue OCPBUGS-65765, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.22.0) matches configured target version for branch (4.22.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @yapei

This pull request references Jira Issue OCPBUGS-65678, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.22.0) matches configured target version for branch (4.22.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @yapei

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

cajieh · 2025-12-17T14:38:20Z

/unhold

cajieh · 2025-12-17T14:38:30Z

/retest

openshift-ci-robot · 2025-12-17T20:33:30Z

/retest-required

Remaining retests: 0 against base HEAD 9ac9e36 and 2 for PR HEAD b4e519c in total

openshift-ci-robot · 2025-12-18T18:48:11Z

/retest-required

Remaining retests: 0 against base HEAD d3b540a and 1 for PR HEAD b4e519c in total

openshift-ci · 2025-12-19T09:06:23Z

@cajieh: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci-robot · 2025-12-19T09:35:45Z

@cajieh: Jira Issue OCPBUGS-65765: All pull requests linked via external trackers have merged:

openshift/console#15763

This pull request has the verified-later tag and will need to be manually moved to VERIFIED after testing. Jira Issue OCPBUGS-65765 has been moved to the MODIFIED state.

Jira Issue OCPBUGS-65678: All pull requests linked via external trackers have merged:

openshift/console#15763

This pull request has the verified-later tag and will need to be manually moved to VERIFIED after testing. Jira Issue OCPBUGS-65678 has been moved to the MODIFIED state.

Details

In response to this:

… console

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

cajieh · 2025-12-19T12:33:02Z

/cherry-pick release-4.21

openshift-cherrypick-robot · 2025-12-19T12:33:44Z

@cajieh: new pull request created: #15871

Details

In response to this:

/cherry-pick release-4.21

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-merge-robot · 2025-12-22T04:48:56Z

Fix included in accepted release 4.22.0-0.nightly-2025-12-21-224908

openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Nov 24, 2025

openshift-ci bot requested review from Leo6Leo, spadgett and yapei November 24, 2025 15:48

openshift-ci bot added component/core Related to console core functionality approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 24, 2025

Runtime error occurs when create MachineConfig with default yaml from…

b4e519c

… console

cajieh force-pushed the runtime-error-create-machineConfig-default-yaml- branch from 36ec7c3 to b4e519c Compare November 24, 2025 16:09

cajieh changed the title ~~OCPBUGS-65678: Runtime error occurs when create MachineConfig with default yaml from…~~ [WIP] OCPBUGS-65765, OCPBUGS-65678: apiVersion is empty on YAML creation page - Runtime error occurs when create MachineConfig with default yaml from… Nov 24, 2025

openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 24, 2025

openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 25, 2025

openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Dec 2, 2025

openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 10, 2025

openshift-ci-robot added jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. and removed jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Dec 12, 2025

openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Dec 15, 2025

openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 17, 2025

openshift-merge-bot bot merged commit 99c3437 into openshift:main Dec 19, 2025
8 checks passed

openshift-cherrypick-robot mentioned this pull request Dec 19, 2025

[release-4.21] OCPBUGS-69931, OCPBUGS-69932: apiVersion is empty on YAML creation page - Runtime error occurs when create MachineConfig with default yaml from… #15871

Open

OCPBUGS-65765, OCPBUGS-65678: apiVersion is empty on YAML creation page - Runtime error occurs when create MachineConfig with default yaml from… #15763

OCPBUGS-65765, OCPBUGS-65678: apiVersion is empty on YAML creation page - Runtime error occurs when create MachineConfig with default yaml from… #15763

Conversation

cajieh commented Nov 24, 2025

Uh oh!

openshift-ci-robot commented Nov 24, 2025

Uh oh!

coderabbitai bot commented Nov 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Uh oh!

cajieh commented Nov 24, 2025

Uh oh!

openshift-ci-robot commented Nov 24, 2025

Uh oh!

openshift-ci-robot commented Nov 24, 2025

Uh oh!

logonoff commented Dec 2, 2025

Uh oh!

openshift-ci-robot commented Dec 2, 2025

Uh oh!

logonoff commented Dec 2, 2025

Uh oh!

openshift-ci-robot commented Dec 2, 2025

Uh oh!

Leo6Leo commented Dec 9, 2025

Uh oh!

openshift-ci-robot commented Dec 10, 2025

Uh oh!

openshift-ci-robot commented Dec 10, 2025

Uh oh!

Leo6Leo commented Dec 11, 2025

Uh oh!

Leo6Leo commented Dec 11, 2025

Uh oh!

openshift-bot commented Dec 12, 2025

Uh oh!

openshift-ci-robot commented Dec 12, 2025

Uh oh!

Leo6Leo commented Dec 12, 2025

Uh oh!

cajieh commented Dec 15, 2025

Uh oh!

cajieh commented Dec 15, 2025

Uh oh!

openshift-ci-robot commented Dec 15, 2025

Uh oh!

cajieh commented Dec 15, 2025

Uh oh!

openshift-ci-robot commented Dec 15, 2025

Uh oh!

cajieh commented Dec 17, 2025

Uh oh!

cajieh commented Dec 17, 2025

Uh oh!

openshift-ci-robot commented Dec 17, 2025

Uh oh!

openshift-ci-robot commented Dec 18, 2025

Uh oh!

openshift-ci bot commented Dec 19, 2025

Uh oh!

Uh oh!

openshift-ci-robot commented Dec 19, 2025

Uh oh!

cajieh commented Dec 19, 2025

Uh oh!

openshift-cherrypick-robot commented Dec 19, 2025

Uh oh!

openshift-merge-robot commented Dec 22, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

coderabbitai bot commented Nov 24, 2025 •

edited

Loading