-
Notifications
You must be signed in to change notification settings - Fork 666
OCPBUGS-44235: Fix Helm chart installation with CA/TLS certificates #15607
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPBUGS-44235: Fix Helm chart installation with CA/TLS certificates #15607
Conversation
|
@martinszuc: This pull request references Jira Issue OCPBUGS-44235, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Hi @martinszuc. Thanks for your PR. I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/ok-to-test |
|
/retest |
Console uses Kubernetes CRDs to manage Helm repositories, not Helm's repository cache. Setting chartPathOptions.RepoURL forced Helm to look for a cache that doesn't exist in the console pod's read-only filesystem. Remove RepoURL assignments and use direct URL downloads with CaFile, CertFile, and KeyFile for authentication. Fixes https://issues.redhat.com/browse/OCPBUGS-44235 Signed-off-by: Martin Szuc <mszuc@redhat.com>
Test that authentication setup does not set RepoURL and verify chart downloads work with CA/TLS certificates. Signed-off-by: Martin Szuc <mszuc@redhat.com>
d83db26 to
aed7a1e
Compare
|
/jira refresh /cc @jhadvig |
|
@vikram-raj: This pull request references Jira Issue OCPBUGS-44235, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/lgtm |
|
/hold |
|
@martinszuc: This pull request references Jira Issue OCPBUGS-44235, which is valid. 3 validation(s) were run on this bug
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/retest |
jhadvig
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @martinszuc 👍 Change looks good ✌️
/hold cancel
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: baijum, jhadvig, martinszuc The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/verified by @baijum |
|
@baijum: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@martinszuc: Jira Issue Verification Checks: Jira Issue OCPBUGS-44235 Jira Issue OCPBUGS-44235 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Fix included in accepted release 4.21.0-0.nightly-2025-11-05-234508 |
|
/cherrypick release-4.18 |
|
@martinszuc: new pull request created: #15860 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/cherrypick release-4.19 |
|
@martinszuc: new pull request created: #15861 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/cherrypick release-4.20 |
|
@martinszuc: new pull request created: #15862 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
OCPBUGS-44235: Fix Helm chart installation with CA/TLS certificates
Fixes: https://issues.redhat.com/browse/OCPBUGS-44235
Problem
Helm chart installation fails when CA certificates or client TLS certificates are configured:
Browsing works. Installing fails.
Root Cause
Console uses Kubernetes CRDs for repository management, not Helm's repository cache. The code set
chartPathOptions.RepoURLduring authentication, forcing Helm to look for a cache at$HOME/.cache/helm/repository/. This cache doesn't exist in the console pod's read-only filesystem.Solution
Remove
chartPathOptions.RepoURLassignments. Helm downloads directly from URLs usingCaFile,CertFile, andKeyFilewithout requiring repository cache.Reproduction
See: https://github.com/openshift-helm/test-scenarios/tree/main/ca-certificate-test