Skip to content

NETOBSERV-2296 add missing annotations on netobserv quickstart #1080

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
jpinsonneau wants to merge 1 commit into
base: main
Choose a base branch
from
Open

NETOBSERV-2296 add missing annotations on netobserv quickstart #1080

jpinsonneau wants to merge 1 commit into from
+6 −0

Conversation

@jpinsonneau
Copy link
Contributor

@jpinsonneau jpinsonneau commented Dec 11, 2025

Add missing annotations on netobserv quickstart

@jpinsonneau
Copy link
Contributor Author

jpinsonneau commented Dec 11, 2025

/cherry-pick release-4.19

@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Dec 11, 2025

@jpinsonneau: once the present PR merges, I will cherry-pick it on top of release-4.19 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick release-4.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@jpinsonneau
Copy link
Contributor Author

jpinsonneau commented Dec 11, 2025

/cherry-pick release-4.20

@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Dec 11, 2025

@jpinsonneau: once the present PR merges, I will cherry-pick it on top of release-4.20 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick release-4.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@jpinsonneau
Copy link
Contributor Author

jpinsonneau commented Dec 11, 2025

/cherry-pick release-4.21

@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Dec 11, 2025

@jpinsonneau: once the present PR merges, I will cherry-pick it on top of release-4.21 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick release-4.21

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@jpinsonneau
Copy link
Contributor Author

jpinsonneau commented Dec 11, 2025

/cherry-pick release-4.22

@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Dec 11, 2025

@jpinsonneau: once the present PR merges, I will cherry-pick it on top of release-4.22 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick release-4.22

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@jpinsonneau
Copy link
Contributor Author

jpinsonneau commented Dec 15, 2025

/test e2e-aws-console

@memodi
Copy link

memodi commented Dec 16, 2025

Screenshot 2025-12-16 at 2 28 26 PM

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Dec 16, 2025
jhadvig
jhadvig approved these changes Dec 22, 2025
View reviewed changes
Copy link
Member

@jhadvig jhadvig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@jhadvig
Copy link
Member

jhadvig commented Dec 22, 2025

/label acknowledge-critical-fixes-only
/approve

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. labels Dec 22, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 22, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jhadvig, jpinsonneau

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jhadvig
Copy link
Member

jhadvig commented Dec 22, 2025

/retest

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 22, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 22, 2025

@jpinsonneau: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jhadvig jhadvig jhadvig approved these changes

@invincibleJai invincibleJai Awaiting requested review from invincibleJai

@lokanandaprabhu lokanandaprabhu Awaiting requested review from lokanandaprabhu

Assignees

@jhadvig jhadvig

Labels

acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jpinsonneau @openshift-cherrypick-robot @memodi @jhadvig