Skip to content

[release-4.22] OCPBUGS-84739: Use dedicated service accounts for multus pods#2985

Open
openshift-cherrypick-robot wants to merge 1 commit intoopenshift:release-4.22from
openshift-cherrypick-robot:cherry-pick-2961-to-release-4.22
Open

[release-4.22] OCPBUGS-84739: Use dedicated service accounts for multus pods#2985
openshift-cherrypick-robot wants to merge 1 commit intoopenshift:release-4.22from
openshift-cherrypick-robot:cherry-pick-2961-to-release-4.22

Conversation

@openshift-cherrypick-robot
Copy link
Copy Markdown

This is an automated cherry-pick of #2961

/assign ehearne-redhat

The cni-sysctl-allowlist-ds pod was using the default service account.
Add serviceAccountName: multus-ancillary-tools to use a dedicated SA.

Also make sure that defaultt SA isn't used when multus network node
identity is enabled.

This work was taken from yboaron's PR in openshift#2845. yboaron has given me permission to
take over his work on this.

Signed-off-by: Evan Hearne <ehearne@redhat.com>
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 30, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 77256549-69fc-41a8-85aa-fc0df6c6ba30

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@openshift-cherrypick-robot: Jira Issue OCPBUGS-65631 has been cloned as Jira Issue OCPBUGS-84739. Will retitle bug to link to clone.

WARNING: Unexpected sprint field type []interface {} on source issue. Please update sprint manually on clone.

/retitle [release-4.22] OCPBUGS-84739: Use dedicated service accounts for multus pods

Details

In response to this:

This is an automated cherry-pick of #2961

/assign ehearne-redhat

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci Bot changed the title [release-4.22] OCPBUGS-65631: Use dedicated service accounts for multus pods [release-4.22] OCPBUGS-84739: Use dedicated service accounts for multus pods Apr 30, 2026
@openshift-ci-robot openshift-ci-robot added jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Apr 30, 2026
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-84739, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
  • expected dependent Jira Issue OCPBUGS-65631 to target a version in 5.0.0, but it targets "5.0" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

This is an automated cherry-pick of #2961

/assign ehearne-redhat

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@ehearne-redhat
Copy link
Copy Markdown
Contributor

/jira refresh

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@ehearne-redhat: This pull request references Jira Issue OCPBUGS-84739, which is invalid:

  • expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is ON_QA instead
  • expected dependent Jira Issue OCPBUGS-65631 to target a version in 5.0.0, but it targets "5.0" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@ehearne-redhat
Copy link
Copy Markdown
Contributor

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Apr 30, 2026
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@ehearne-redhat: This pull request references Jira Issue OCPBUGS-84739, which is valid.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.22.0) matches configured target version for branch (4.22.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note type set to "Release Note Not Required"
  • dependent bug Jira Issue OCPBUGS-65631 is in the state ON_QA, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Jira Issue OCPBUGS-65631 targets the "5.0.0" version, which is one of the valid target versions: 5.0.0
  • bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Jira (weliang@redhat.com), skipping review request.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@ehearne-redhat
Copy link
Copy Markdown
Contributor

/retest-required

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 30, 2026

@openshift-cherrypick-robot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/security a19dae4 link false /test security

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@ehearne-redhat
Copy link
Copy Markdown
Contributor

/retest-required

@everettraven
Copy link
Copy Markdown

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label May 6, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 6, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: everettraven, openshift-cherrypick-robot
Once this PR has been reviewed and has the lgtm label, please assign abhat for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ehearne-redhat
Copy link
Copy Markdown
Contributor

/verified by ci/prow/e2e-gcp-ovn, ci/prow/unit

---
apiVersion: v1
kind: Pod
metadata:
  annotations:
    cluster-autoscaler.kubernetes.io/enable-ds-eviction: "false"
  creationTimestamp: "2026-04-30T09:26:05Z"
  generateName: multus-
  generation: 1
  labels:
    app: multus
    ...
  name: multus-cncch
  namespace: openshift-multus
  ...
  serviceAccount: multus-node-identity
  serviceAccountName: multus-node-identity
  ...
  phase: Running
  podIP: 10.0.0.5
  podIPs:
  - ip: 10.0.0.5
  qosClass: Burstable
  startTime: "2026-04-30T09:26:05Z"
---
apiVersion: v1
kind: Pod
metadata:
  annotations:
    cluster-autoscaler.kubernetes.io/enable-ds-eviction: "false"
  creationTimestamp: "2026-04-30T09:41:35Z"
  generateName: multus-additional-cni-plugins-
  ...
  name: multus-additional-cni-plugins-5p2bh
  namespace: openshift-multus
  ...
  serviceAccount: multus-ancillary-tools
  serviceAccountName: multus-ancillary-tools
  ...
  phase: Running
  podIP: 10.0.128.3
  podIPs:
  - ip: 10.0.128.3
  qosClass: Burstable
  startTime: "2026-04-30T09:42:15Z"

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label May 8, 2026
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@ehearne-redhat: This PR has been marked as verified by ci/prow/e2e-gcp-ovn,ci/prow/unit.

Details

In response to this:

/verified by ci/prow/e2e-gcp-ovn, ci/prow/unit

---
apiVersion: v1
kind: Pod
metadata:
 annotations:
   cluster-autoscaler.kubernetes.io/enable-ds-eviction: "false"
 creationTimestamp: "2026-04-30T09:26:05Z"
 generateName: multus-
 generation: 1
 labels:
   app: multus
   ...
 name: multus-cncch
 namespace: openshift-multus
 ...
 serviceAccount: multus-node-identity
 serviceAccountName: multus-node-identity
 ...
 phase: Running
 podIP: 10.0.0.5
 podIPs:
 - ip: 10.0.0.5
 qosClass: Burstable
 startTime: "2026-04-30T09:26:05Z"
---
apiVersion: v1
kind: Pod
metadata:
 annotations:
   cluster-autoscaler.kubernetes.io/enable-ds-eviction: "false"
 creationTimestamp: "2026-04-30T09:41:35Z"
 generateName: multus-additional-cni-plugins-
 ...
 name: multus-additional-cni-plugins-5p2bh
 namespace: openshift-multus
 ...
 serviceAccount: multus-ancillary-tools
 serviceAccountName: multus-ancillary-tools
 ...
 phase: Running
 podIP: 10.0.128.3
 podIPs:
 - ip: 10.0.128.3
 qosClass: Burstable
 startTime: "2026-04-30T09:42:15Z"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants