CORENET-6581: Add transport label to CUDN telemetry recording rule

[mattedallo]

Add the transport dimension to the CUDN recording rule:

max by(role, topology) → max by(role, topology, transport)

This preserves the Geneve / EVPN / NoOverlay / Localnet breakdown in the aggregated telemetry metric.

Depends on (upstream ovn-kubernetes):

• Add transport label to CUDN count metric ovn-kubernetes/ovn-kubernetes#6265

Summary by CodeRabbit

• Chores
  • Enhanced cluster monitoring metrics aggregation by adding transport-level dimensionality to control plane metric recording rules in both managed and self-hosted deployments for improved monitoring granularity.

[openshift-ci-robot]

@mattedallo: This pull request references CORENET-6581 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set.

Details

In response to this:

Add the transport dimension to the CUDN recording rule:

max by(role, topology) → max by(role, topology, transport)

This preserves the Geneve / EVPN / NoOverlay / Localnet breakdown in the aggregated telemetry metric.

Depends on (upstream ovn-kubernetes):

• Add transport label to CUDN count metric ovn-kubernetes/ovn-kubernetes#6265

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: fe2d441b-d28a-4183-b10a-fc1b8c9db0fe

📥 Commits

Reviewing files that changed from the base of the PR and between 142432a and 9c178ed.

📒 Files selected for processing (2)

• bindata/network/ovn-kubernetes/managed/alert-rules-control-plane.yaml
• bindata/network/ovn-kubernetes/self-hosted/alert-rules-control-plane.yaml

---

Walkthrough

Two Prometheus recording rules in OVN-Kubernetes alert configurations are updated to include the transport label in their aggregation dimensions, changing the time series cardinality for the cluster:ovnkube_clustermanager_cluster_user_defined_networks:max metric.

Changes

Cohort / File(s)	Summary
Prometheus Recording Rule Updates bindata/network/ovn-kubernetes/managed/alert-rules-control-plane.yaml, bindata/network/ovn-kubernetes/self-hosted/alert-rules-control-plane.yaml	Updated the cluster:ovnkube_clustermanager_cluster_user_defined_networks:max recording rule expression to add transport label to the max by() aggregation dimensions alongside role and topology.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 12

✅ Passed checks (12 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately summarizes the main change: adding a transport label to a CUDN telemetry recording rule, which aligns with the changeset modifications across both alert-rules files.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	The PR only modifies YAML files containing Prometheus alert rules with no Go test code or Ginkgo test definitions present.
Test Structure And Quality	✅ Passed	This PR modifies only Prometheus PrometheusRule YAML files with no Go test code changes, making the Ginkgo test code quality check not applicable.
Microshift Test Compatibility	✅ Passed	This PR does not add new Ginkgo e2e tests, only modifies Prometheus rule YAML files with a transport label addition.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	This PR modifies only Prometheus alert rule configuration files (YAML) in the bindata/network/ovn-kubernetes/ directories. These are declarative monitoring rules, not Ginkgo e2e tests. The custom check applies specifically to new Ginkgo e2e tests (It(), Describe(), Context(), When(), etc.) which are Go test patterns not present in this PR. Since no e2e tests are added, the SNO test compatibility check is not applicable.
Topology-Aware Scheduling Compatibility	✅ Passed	PR modifies only Prometheus recording rules within PrometheusRule resources, adding a transport label dimension to metric aggregation. No deployment manifests, operator code, controllers, or scheduling constructs are present.
Ote Binary Stdout Contract	✅ Passed	The OTE Binary Stdout Contract check is not applicable to this PR. The PR exclusively modifies Prometheus alert rule configuration files (YAML files in bindata/network/ovn-kubernetes/), which are static data files containing no executable code.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	This PR only modifies Prometheus alert rule YAML files and does not add or modify any Ginkgo e2e tests.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[mattedallo]

/test all

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mattedallo
Once this PR has been reviewed and has the lgtm label, please assign jcaamano for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@mattedallo: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-aws-ovn-rhcos10-techpreview	9c178ed	link	false	/test e2e-aws-ovn-rhcos10-techpreview
ci/prow/e2e-aws-ovn-serial-1of2	9c178ed	link	true	/test e2e-aws-ovn-serial-1of2
ci/prow/e2e-aws-ovn-hypershift-conformance	9c178ed	link	true	/test e2e-aws-ovn-hypershift-conformance
ci/prow/e2e-azure-ovn-upgrade	9c178ed	link	true	/test e2e-azure-ovn-upgrade
ci/prow/e2e-gcp-ovn-upgrade	9c178ed	link	true	/test e2e-gcp-ovn-upgrade
ci/prow/4.22-upgrade-from-stable-4.21-e2e-gcp-ovn-upgrade	9c178ed	link	false	/test 4.22-upgrade-from-stable-4.21-e2e-gcp-ovn-upgrade
ci/prow/e2e-aws-ovn-upgrade	9c178ed	link	true	/test e2e-aws-ovn-upgrade
ci/prow/4.22-upgrade-from-stable-4.21-e2e-azure-ovn-upgrade	9c178ed	link	false	/test 4.22-upgrade-from-stable-4.21-e2e-azure-ovn-upgrade
ci/prow/security	9c178ed	link	false	/test security
ci/prow/e2e-aws-ovn-upgrade-ipsec	9c178ed	link	true	/test e2e-aws-ovn-upgrade-ipsec
ci/prow/lint	9c178ed	link	true	/test lint

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.