LOG-9400: API description does not list possible values for deliveryMode#3286
LOG-9400: API description does not list possible values for deliveryMode#3286Clee2691 wants to merge 1 commit into
Conversation
|
@Clee2691: This pull request references LOG-9400 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.8.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughThis PR improves documentation clarity for the ChangesDeliveryMode Documentation Clarification
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
/retest |
1 similar comment
|
/retest |
|
/approve |
|
@Clee2691 do we need to run |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Clee2691, jcantrill The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I ran |
|
/retest |
|
/lgtm |
|
/retest |
|
@Clee2691: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Description
This PR adds the possible values for
DeliveryMode./cc @vparfonov
/assign @jcantrill
Links
Summary by CodeRabbit
Release Notes
DeliveryModevalues (AtLeastOnceandAtMostOnce) in documentation comments and schema descriptions across multiple output configurations.