Skip to content

fix(dependencies): remove ginko cli install#3284

Open
jcantrill wants to merge 1 commit into
openshift:masterfrom
jcantrill:fix_ginko_mismatch
Open

fix(dependencies): remove ginko cli install#3284
jcantrill wants to merge 1 commit into
openshift:masterfrom
jcantrill:fix_ginko_mismatch

Conversation

@jcantrill
Copy link
Copy Markdown
Contributor

@jcantrill jcantrill commented May 19, 2026

Description

This PR removes ginko CLI install that is unused by test to resolve:

 Ginkgo detected a version mismatch between the Ginkgo CLI and the version of Ginkgo imported by your packages:
  Ginkgo CLI Version:
    2.23.4
  Mismatched package versions found:
    2.27.2 used by input_selection
  Ginkgo will continue to attempt to run but you may see errors (including flag
  parsing errors) and should either update your go.mod or your version of the
  Ginkgo CLI to match.
  To install the matching version of the CLI run
    go install github.com/onsi/ginkgo/v2/ginkgo
  from a path that contains a go.mod file.  Alternatively you can use
    go run github.com/onsi/ginkgo/v2/ginkgo
  from a path that contains a go.mod file to invoke the matching version of the
  Ginkgo CLI.

cc @vparfonov @Clee2691

Summary by CodeRabbit

  • Chores

    • Automatically set the test report output path when test reporting is enabled for clearer, centralized test logs.
    • Removed an unnecessary build-time installation step to simplify setup and reduce overhead.
  • Tests

    • Standardized e2e test execution to use the Go test runner with sensible default options (including timeout), improving reliability and consistency of test runs.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 19, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 20c80662-b4f3-4dd0-a927-1fac48103b81

📥 Commits

Reviewing files that changed from the base of the PR and between 01fdc92 and 1e90568.

📒 Files selected for processing (2)
  • hack/lib/init.sh
  • hack/testing-olm/test-367-logforwarding.sh
💤 Files with no reviewable changes (1)
  • hack/lib/init.sh

📝 Walkthrough

Walkthrough

Init script now conditionally sets JUNIT_REPORT_OUTPUT and drops an explicit ginkgo install; the Log Forwarding test runner defines GOTEST_OPTIONS and runs per-directory tests with go test instead of ginkgo.

Changes

Test initialization and execution

Layer / File(s) Summary
Init script: JUNIT output and ginkgo removal
hack/lib/init.sh
Conditionally exports JUNIT_REPORT_OUTPUT=$LOG_DIR/raw_test_output.log when JUNIT_REPORT is set; removes the go install line that installed github.com/onsi/ginkgo/v2/ginkgo@v2.23.4.
Log Forwarding runner: go test + GOTEST_OPTIONS
hack/testing-olm/test-367-logforwarding.sh
Adds default GOTEST_OPTIONS (timeout and Ginkgo-related flags) and replaces per-directory ginkgo invocation with go test ${GOTEST_OPTIONS} "$dir" piping output to test.log.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Poem

🐰 I hopped through scripts to clear the ground,
Trimmed ginkgo's install that used to surround.
When JUNIT awakens, raw logs now flow,
Tests run with go test where ginkgo would go.
Tiny changes—lighter paths to show.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description explains the issue and rationale but lacks mandatory sections: /cc and /assign reviewer/approver assignments are missing. Add /cc and /assign statements with actual reviewer/approver GitHub usernames from the OWNERS file to meet template requirements.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: removing a Ginkgo CLI install step from the initialization script to resolve a version mismatch issue.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci Bot requested review from Clee2691 and vparfonov May 19, 2026 20:02
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 19, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jcantrill

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 19, 2026
@vparfonov
Copy link
Copy Markdown
Contributor

/retest

@jcantrill jcantrill force-pushed the fix_ginko_mismatch branch from 01fdc92 to 1e90568 Compare May 20, 2026 18:14
@jcantrill
Copy link
Copy Markdown
Contributor Author

/retest

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 20, 2026

@jcantrill: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-target 1e90568 link true /test e2e-target
ci/prow/functional-target 1e90568 link true /test functional-target

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. release/6.6

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants