Skip to content

feat(alerts): add runbook_url for CollectorNodeDown alert#3282

Open
jcantrill wants to merge 1 commit into
openshift:masterfrom
jcantrill:log7256_alert_runbook
Open

feat(alerts): add runbook_url for CollectorNodeDown alert#3282
jcantrill wants to merge 1 commit into
openshift:masterfrom
jcantrill:log7256_alert_runbook

Conversation

@jcantrill
Copy link
Copy Markdown
Contributor

@jcantrill jcantrill commented May 18, 2026

LOG-7256

Description

This PR:
*adds the runbook url for the CollectorNodeDownAlert

Links

cc @vparfonov @Clee2691

Summary by CodeRabbit

  • Documentation
    • Added runbook URL annotations to the CollectorNodeDown alert rule, enabling users to quickly access operational runbooks for troubleshooting collector node issues. Updates were applied across alerting configurations, providing direct remediation guidance links when alerts are triggered.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 18, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jcantrill

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 18, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 18, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: e4c811a4-e2c9-404b-9116-65bf57d0e875

📥 Commits

Reviewing files that changed from the base of the PR and between 1e78ce5 and 022c623.

📒 Files selected for processing (2)
  • bundle/manifests/collector_monitoring.coreos.com_v1_prometheusrule.yaml
  • config/prometheus/collector_alerts.yaml

📝 Walkthrough

Walkthrough

A runbook_url annotation is added to the CollectorNodeDown alert rule in both the Prometheus alert configuration source and the generated CRD manifest, pointing to the corresponding runbook in the OpenShift runbooks repository.

Changes

CollectorNodeDown Alert Runbook URL

Layer / File(s) Summary
Add runbook_url annotation to CollectorNodeDown alert
config/prometheus/collector_alerts.yaml, bundle/manifests/collector_monitoring.coreos.com_v1_prometheusrule.yaml
The CollectorNodeDown alert gains a runbook_url annotation linking to the OpenShift runbooks repository in both the configuration source and generated manifest.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 A runbook link, so small and bright,
For CollectorNodeDown alerts in the night,
Two files in sync, a simple pair,
Guidance for those who dare to care! 📚✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the main change: adding a runbook_url annotation to the CollectorNodeDown alert, which matches the actual changeset.
Description check ✅ Passed The description includes the JIRA reference, explains the intent, mentions the dependency on another PR, and provides links. However, it lacks explicit /cc and /assign directives required by the template.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@jcantrill
Copy link
Copy Markdown
Contributor Author

/retest

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 19, 2026

@jcantrill: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. release/6.6

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant