Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: vparfonov The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
| }) | ||
| }) | ||
|
|
||
| //TODO: Enrichment and PayloadKey not supporting by Syslog form upstream |
There was a problem hiding this comment.
What are the implications here? I'm not certain why enrichment was ever passed on as it was our concept that did not need to be passed on? It was an indicator to add the kube info. Same with Payload key which was an indicator from CLF on how to populate the message field.
There was a problem hiding this comment.
not actual, already fixed but forgot remove comment
see: 8f32b77#diff-9da62957a4d8f525b14cf8934bd55180d99abee9e3046cb79d2d2574cfe6e152R210
|
/test all |
0a9239c to
e8a1299
Compare
e8a1299 to
d9421f3
Compare
|
/test all |
|
/retest |
|
/test e2e-target |
|
/test functional-target |
1 similar comment
|
/test functional-target |
Switch to Syslog encoder from upstream instead of forked one
26e4f73 to
c9333f4
Compare
|
@vparfonov: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Description
Update CLO to use Vector v0.54.0
Switch to Syslog encoder from upstream instead of forked
Temporary use Vector image from own repository for checking tests
Depends on:
/cc @cahartma @Clee2691
/assign @jcantrill
Links