LOG-7888: add tests for timestamp field in audit logs#3220
LOG-7888: add tests for timestamp field in audit logs#3220vparfonov wants to merge 1 commit intoopenshift:masterfrom
Conversation
|
/hold |
openshift-ci
bot
added
the
do-not-merge/hold
|
@vparfonov: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
vparfonov
changed the title
openshift-ci-robot
added
the
jira/valid-reference
|
@vparfonov: This pull request references LOG-7888 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.8.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/hold |
openshift-ci
bot
added
the
do-not-merge/hold
jcantrill
added
release/6.6
and removed
do-not-merge/hold
|
/hold |
|
/lgtm |
openshift-ci
bot
added
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jcantrill, vparfonov The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
| Expect(len(auditLogs)).To(Equal(1), "Expected one audit log") | ||
|
|
||
| Expect(auditLogs[0].LogType).To(Equal(string(obs.InputTypeAudit)), "Expected audit log type") | ||
| Expect(auditLogs[0].Timestamp).ToNot(BeZero(), "Expected audit log timestamp") |
There was a problem hiding this comment.
Can we validate this against the timestamp that was used in the event?
| Expect(auditLogs).To(HaveLen(1)) | ||
| Expect(auditLogs[0].LogType).To(Equal(string(obs.InputTypeAudit))) | ||
| Expect(auditLogs[0].LogSource).To(Equal(string(logSource))) | ||
| Expect(auditLogs[0].Timestamp).ToNot(BeZero()) |
3 participants
Description
These functional tests validate the existing behavior and provide ensure no bugs are introduced in future updatesю
/cc @Clee2691 @cahartma
/assign @jcantrill
Links