Skip to content

OCPBUGS-83552: Bump google.golang.org/grpc to 1.79.3#395

Open
sbiradar10 wants to merge 1 commit into
openshift:release-4.22from
sbiradar10:4.22-branch
Open

OCPBUGS-83552: Bump google.golang.org/grpc to 1.79.3#395
sbiradar10 wants to merge 1 commit into
openshift:release-4.22from
sbiradar10:4.22-branch

Conversation

@sbiradar10
Copy link
Copy Markdown

@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels May 18, 2026
@openshift-ci-robot
Copy link
Copy Markdown

@sbiradar10: This pull request references Jira Issue OCPBUGS-83552, which is invalid:

  • expected Jira Issue OCPBUGS-83552 to depend on a bug targeting a version in 5.0.0 and in one of the following states: MODIFIED, ON_QA, VERIFIED, but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

https://redhat.atlassian.net/browse/OCPBUGS-83552

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 18, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 0efb40ff-5e6d-4470-a377-1748df0e494c

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci Bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 18, 2026
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented May 18, 2026

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented May 18, 2026

@sbiradar10: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/security 5bd355e link false /test security
ci/prow/e2e-openstack 5bd355e link true /test e2e-openstack
ci/prow/unit 5bd355e link true /test unit
ci/prow/images 5bd355e link true /test images
ci/prow/verify-deps 5bd355e link true /test verify-deps

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-ci openshift-ci Bot requested review from eshulman2 and stephenfin May 18, 2026 17:50
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented May 18, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sbiradar10
Once this PR has been reviewed and has the lgtm label, please assign damdo for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sbiradar10
Copy link
Copy Markdown
Author

@stephenfin I did this pr for 4.22 branch but look like conflicts is happening. not sure why
can you help here why its happening ?

@stephenfin
Copy link
Copy Markdown

@stephenfin I did this pr for 4.22 branch but look like conflicts is happening. not sure why can you help here why its happening ?

We sync up our branches with the upstream equivalent by default. A sync has merged on this branch recently. This will need to be re-assessed to see if it make sense and, if so, recreated.

@sbiradar10
Copy link
Copy Markdown
Author

@stephenfin I did this pr for 4.22 branch but look like conflicts is happening. not sure why can you help here why its happening ?

We sync up our branches with the upstream equivalent by default. A sync has merged on this branch recently. This will need to be re-assessed to see if it make sense and, if so, recreated.

I checked the grpc version on 4.22 branch and its still google.golang.org/grpc v1.76.0 so this needs bump,
not sure what i am mising here ?

@stephenfin
Copy link
Copy Markdown

@stephenfin I did this pr for 4.22 branch but look like conflicts is happening. not sure why can you help here why its happening ?

We sync up our branches with the upstream equivalent by default. A sync has merged on this branch recently. This will need to be re-assessed to see if it make sense and, if so, recreated.

I checked the grpc version on 4.22 branch and its still google.golang.org/grpc v1.76.0 so this needs bump, not sure what i am mising here ?

Okay, then this needs to be recreated and force pushed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants