Skip to content

chore(SREP-4514: Enable code rabbit inheritance for repo)#460

Open
devppratik wants to merge 3 commits into
openshift:masterfrom
devppratik:add-coderabbit-config
Open

chore(SREP-4514: Enable code rabbit inheritance for repo)#460
devppratik wants to merge 3 commits into
openshift:masterfrom
devppratik:add-coderabbit-config

Conversation

@devppratik
Copy link
Copy Markdown

@devppratik devppratik commented May 19, 2026

Enable inheritance from upstream openshift coderabbit repo with exclusion for certain folders.

Summary by CodeRabbit

  • Documentation

    • Clarified installation/quick-start commands and added guidance for excluding fix commits from blame.
    • Regenerated API manifest descriptions to use clearer YAML block formatting.
  • Chores

    • Adjusted repository review path filters to ignore build/dependency and test-fixture paths.
    • Updated team ownership alias mappings.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 19, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 6aa61c5c-2923-4e6a-a269-e48161238134

📥 Commits

Reviewing files that changed from the base of the PR and between 83bac51 and e3542d5.

📒 Files selected for processing (2)
  • deploy_pko/CustomResourceDefinition-apischemes.cloudingress.managed.openshift.io.yaml
  • deploy_pko/CustomResourceDefinition-publishingstrategies.cloudingress.managed.openshift.io.yaml
✅ Files skipped from review due to trivial changes (2)
  • deploy_pko/CustomResourceDefinition-publishingstrategies.cloudingress.managed.openshift.io.yaml
  • deploy_pko/CustomResourceDefinition-apischemes.cloudingress.managed.openshift.io.yaml

Walkthrough

This PR updates repository tooling/docs and team metadata, and reformats CRD OpenAPI description fields: CodeRabbit path filters, pre-commit setup docs with pinned version and git-blame guidance, OWNERS_ALIASES roster edits, and YAML description formatting in two CRD manifests.

Changes

Repository Configuration and Team Roster Updates

Layer / File(s) Summary
CodeRabbit review configuration
.coderabbit.yaml
Enables inheritance and defines path_filters excluding build artifacts (build/**, .venv/**) and test fixtures (testdata/**, .test-fixtures/**) from review targeting.
Pre-commit hook documentation and setup
.pre-commit-config.yaml
Replaces generic pip install instructions with explicit "Quick start (uv)" and "Quick start (pip)" sections (pip pinned to pre-commit==4.6.0), and adds documentation linking to git-blame ignore-revs-file for excluding fix commits.
Team member roster update
OWNERS_ALIASES
Updates srep-functional-team-aurora alias by adding BATMAN-JD and geowa4, removing luis-falcon, while retaining dakotalongRH, eth1030, and joshbranham.
CRD: apischemes description formatting
deploy_pko/CustomResourceDefinition-apischemes.cloudingress.managed.openshift.io.yaml
Reformatted v1alpha1 openAPIV3Schema description strings into YAML block scalars and touched the file top line; no schema structural changes.
CRD: publishingstrategies description formatting
deploy_pko/CustomResourceDefinition-publishingstrategies.cloudingress.managed.openshift.io.yaml
Reformatted v1alpha1 openAPIV3Schema description text into YAML block-literal form and touched the top line; schema structure unchanged.

🎯 2 (Simple) | ⏱️ ~10 minutes


Important

Pre-merge checks failed

Please resolve all errors before merging. Addressing warnings is optional.

❌ Failed checks (1 error, 1 warning)

Check name Status Explanation Resolution
Stable And Deterministic Test Names ❌ Error Test file test/e2e/cloud_ingress_operator_tests.go line 193 has dynamic test name using variable concatenation instead of static string. Replace ginkgo.It("manually deleted "+cioServiceName+" load balancer..." with static string: ginkgo.It("manually deleted rh-api load balancer should be recreated"...
Microshift Test Compatibility ⚠️ Warning Tests reference openshift-kube-apiserver namespace (unavailable on MicroShift) without MicroShift skip protection. Add [Skipped:MicroShift] label, guard with exutil.IsMicroShiftCluster() check, or add [apigroup:...] tag.
✅ Passed checks (13 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly refers to enabling CodeRabbit inheritance for the repository, which directly matches the main changes in .coderabbit.yaml that enable inheritance and define path filters.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Test Structure And Quality ✅ Passed PR contains no Ginkgo test code changes; custom check for test quality is not applicable. Changes are limited to configuration files, CRD manifests, and build/boilerplate files.
Single Node Openshift (Sno) Test Compatibility ✅ Passed PR adds 7 new Ginkgo e2e tests. None make multi-node assumptions: no node counting, anti-affinity, topology spreads, node drains, or failover expectations. Tests are compatible with SNO.
Topology-Aware Scheduling Compatibility ✅ Passed PR changes only configuration, ownership, and CRD formatting; no deployment manifests, operator code, or scheduling constraints introduced.
Ote Binary Stdout Contract ✅ Passed PR modifies only YAML config files (.coderabbit.yaml, .pre-commit-config.yaml), alias files, and CRD manifests—no Go executable code, making the OTE stdout check inapplicable.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed PR contains no Ginkgo e2e test additions. Changes are configuration/manifest files only: .coderabbit.yaml, .pre-commit-config.yaml, OWNERS_ALIASES, and CRD YAML formatting.
No-Weak-Crypto ✅ Passed No weak cryptography (MD5, SHA1, DES, RC4, 3DES, Blowfish, ECB) patterns found in PR. Changes involve config, documentation, and YAML formatting only.
Container-Privileges ✅ Passed No container privilege escalation settings (privileged mode, hostPID/Network/IPC, SYS_ADMIN, or allowPrivilegeEscalation) found in any modified files or repository manifests.
No-Sensitive-Data-In-Logs ✅ Passed PR adds configuration files and boilerplate templates with no new logging statements that expose passwords, tokens, API keys, PII, session IDs, or customer data.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci Bot requested review from boranx and ritmun May 19, 2026 15:12
@codecov
Copy link
Copy Markdown

codecov Bot commented May 19, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 41.57%. Comparing base (304b109) to head (e3542d5).
⚠️ Report is 17 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #460   +/-   ##
=======================================
  Coverage   41.57%   41.57%           
=======================================
  Files          27       27           
  Lines        2665     2665           
=======================================
  Hits         1108     1108           
  Misses       1478     1478           
  Partials       79       79           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@devppratik devppratik changed the title chore: enable coderabbit config inheritance chore(SREP-4514): enable coderabbit config inheritance May 19, 2026
@devppratik devppratik changed the title chore(SREP-4514): enable coderabbit config inheritance chore(SREP-4514: Enable code rabbit inheritance for repo) May 19, 2026
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 19, 2026
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented May 19, 2026

@devppratik: This pull request references SREP-4514 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set.

Details

In response to this:

Enable inheritance from upstream openshift coderabbit repo with exclusion for certain folders.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

- Enable inheritance from upstream openshift coderabbit repo
- Add path exclusion filters for boilerplate, generated code, and test fixtures
@devppratik devppratik force-pushed the add-coderabbit-config branch from e8ed3d4 to d0afaa4 Compare May 19, 2026 15:51
@krishvoor
Copy link
Copy Markdown
Member

/test validate

@krishvoor
Copy link
Copy Markdown
Member

/rebase

@devppratik
Copy link
Copy Markdown
Author

/test validate
/test images

@devppratik
Copy link
Copy Markdown
Author

/test validate

devppratik and others added 2 commits May 29, 2026 11:23
Fix indentation and formatting in PKO CRD files to match
the output of the current controller-gen version.

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 29, 2026

@devppratik: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@devppratik
Copy link
Copy Markdown
Author

/label tide/merge-method-squash

@openshift-ci openshift-ci Bot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label May 29, 2026
@AlexSmithGH
Copy link
Copy Markdown
Contributor

/lgtm
/approve

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label May 29, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 29, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: AlexSmithGH, devppratik
Once this PR has been reviewed and has the lgtm label, please assign luis-falcon for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants