Skip to content

CCO-793: Separate test extension into independent Go module #955

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
huangmingxia wants to merge 3 commits into
base: master
Choose a base branch
from
Open

CCO-793: Separate test extension into independent Go module #955

huangmingxia wants to merge 3 commits into from

Conversation

@huangmingxia
Copy link
Contributor

@huangmingxia huangmingxia commented Dec 16, 2025

refactor: extract cloud-credential-tests-ext as standalone module

  • Create independent go.mod for test extension
  • Remove OpenShift Origin test dependencies from main module
  • Clean up unused dependencies in root go.mod

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Dec 16, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Dec 16, 2025 •
edited by openshift-ci bot
Loading

@huangmingxia: This pull request references CCO-793 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.22.0" version, but no target version was set.

Details

In response to this:

refactor: extract cloud-credential-tests-ext as standalone module

  • Create independent go.mod for test extension
  • Remove OpenShift Origin test dependencies from main module
  • Clean up unused dependencies in root go.mod

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from 2uasimojo and suhanime December 16, 2025 13:47
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 16, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: huangmingxia
Once this PR has been reviewed and has the lgtm label, please assign 2uasimojo for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@huangmingxia
Copy link
Contributor Author

huangmingxia commented Dec 16, 2025

/cc @jstuever

@openshift-ci openshift-ci bot requested a review from jstuever December 16, 2025 13:49
@codecov
Copy link

codecov bot commented Dec 16, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 46.71%. Comparing base (8f1a631) to head (5c2729a).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #955      +/-   ##
==========================================
+ Coverage   46.47%   46.71%   +0.24%     
==========================================
  Files          98       97       -1     
  Lines       12184    12121      -63     
==========================================
  Hits         5662     5662              
+ Misses       5872     5809      -63     
  Partials      650      650

see 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@huangmingxia
Copy link
Contributor Author

huangmingxia commented Dec 16, 2025

/payload-job periodic-ci-openshift-cloud-credential-operator-release-4.21-periodics-e2e-aws-manual-oidc

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 16, 2025

@huangmingxia: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-cloud-credential-operator-release-4.21-periodics-e2e-aws-manual-oidc

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/758b9280-da9c-11f0-8de4-74610e2162ec-0

@huangmingxia
Copy link
Contributor Author

huangmingxia commented Dec 16, 2025

/payload-job periodic-ci-openshift-cloud-credential-operator-release-4.21-periodics-e2e-azure-manual-oidc

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 16, 2025

@huangmingxia: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-cloud-credential-operator-release-4.21-periodics-e2e-azure-manual-oidc

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/81fadc60-da9c-11f0-84ba-a5f6bcebcd0e-0

@huangmingxia
Copy link
Contributor Author

huangmingxia commented Dec 16, 2025

/payload-job periodic-ci-openshift-cloud-credential-operator-release-4.21-periodics-e2e-gcp-manual-oidc

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 16, 2025

@huangmingxia: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-cloud-credential-operator-release-4.21-periodics-e2e-gcp-manual-oidc

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/a932afb0-da9c-11f0-8c17-3e5853c71d27-0

@huangmingxia
Copy link
Contributor Author

huangmingxia commented Dec 16, 2025

/payload-job periodic-ci-openshift-openshift-tests-private-release-4.21-multi-nightly-aws-ipi-proxy-sts-mini-perm-arm-f7

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 16, 2025

@huangmingxia: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-openshift-tests-private-release-4.21-multi-nightly-aws-ipi-proxy-sts-mini-perm-arm-f7

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/e1edb250-da9c-11f0-89f9-66fba887946c-0

@huangmingxia
Copy link
Contributor Author

huangmingxia commented Dec 16, 2025

/payload-job periodic-ci-openshift-openshift-tests-private-release-4.21-amd64-nightly-aws-ipi-private-fips-f28-disasterrecovery

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 16, 2025

@huangmingxia: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-openshift-tests-private-release-4.21-amd64-nightly-aws-ipi-private-fips-f28-disasterrecovery

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/37f345a0-daae-11f0-9a39-eec79bc89e17-0

@huangmingxia
Copy link
Contributor Author

huangmingxia commented Dec 16, 2025

/payload-job periodic-ci-openshift-openshift-tests-private-release-4.21-amd64-nightly-azure-mag-ipi-fips-f7

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 16, 2025

@huangmingxia: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-openshift-tests-private-release-4.21-amd64-nightly-azure-mag-ipi-fips-f7

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/571da290-daae-11f0-9ffe-57ff0fc696cd-0

@huangmingxia
Copy link
Contributor Author

huangmingxia commented Dec 16, 2025

/payload-job periodic-ci-openshift-openshift-tests-private-release-4.21-multi-nightly-gcp-ipi-labels-tags-filestore-csi-fips-amd-f28-destructive

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 16, 2025

@huangmingxia: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-openshift-tests-private-release-4.21-multi-nightly-gcp-ipi-labels-tags-filestore-csi-fips-amd-f28-destructive

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/6d8b3650-daae-11f0-8207-c0533f29eb38-0

@huangmingxia
Copy link
Contributor Author

huangmingxia commented Dec 16, 2025

/payload-job periodic-ci-openshift-openshift-tests-private-release-4.21-amd64-nightly-gcp-ipi-disc-priv-oidc-fips-mini-perm-f28

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 16, 2025

@huangmingxia: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-openshift-tests-private-release-4.21-amd64-nightly-gcp-ipi-disc-priv-oidc-fips-mini-perm-f28

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/7fda8f40-daae-11f0-9dee-370e5b3fd029-0

@huangmingxia
Copy link
Contributor Author

huangmingxia commented Dec 16, 2025

/payload-job periodic-ci-openshift-openshift-tests-private-release-4.21-amd64-nightly-vsphere-ipi-f14-sanity-reliability-test

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 16, 2025

@huangmingxia: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-openshift-tests-private-release-4.21-amd64-nightly-vsphere-ipi-f14-sanity-reliability-test

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/96bc4190-daae-11f0-8c35-d6138c591622-0

@huangmingxia
Copy link
Contributor Author

huangmingxia commented Dec 16, 2025

/payload-job periodic-ci-openshift-openshift-tests-private-release-4.21-amd64-nightly-ibmcloud-ipi-mini-perm-f28

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 16, 2025

@huangmingxia: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-openshift-tests-private-release-4.21-amd64-nightly-ibmcloud-ipi-mini-perm-f28

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/a9b56f10-daae-11f0-902f-c149d0c63e2a-0

@jstuever
Copy link
Contributor

jstuever commented Dec 16, 2025

@huangmingxia Can you put the go.mod, go.sum, and all of the vendor/ changes into their own commit. This will make it significantly easier to review the PR because we can filter the Files changed by commit. Currently, there are 4,536 files marked as changed. Github will only show us 3,000, and is very slow and buggy when doing so. If all of the vendor changes are in a single commit, then we can filter out that commit to only see the non-vendor changes.

@huangmingxia
CCO-793: refactor: extract cloud-credential-tests-ext as standalone m…
ad7e92f 
…odule

- Move cloud-credential-tests-ext from cmd/ to test/extend/
- Create independent go.mod for test extension module
- Update Makefile to reflect new location
@huangmingxia
deps: update main module go.mod, go.sum and vendor dependencies
1e95fd5 
This commit includes vendor/ directory changes and go.mod/go.sum
updates for the main module.
@huangmingxia
deps: add vendor dependencies for test extension module
5c2729a 
This commit includes test/extend/vendor/ directory for the newly
created test extension module.
@huangmingxia huangmingxia force-pushed the CCO-793 branch 2 times, most recently from 7809657 to 5c2729a Compare December 17, 2025 09:17
@huangmingxia
Copy link
Contributor Author

huangmingxia commented Dec 17, 2025

/retest-required

@huangmingxia
Copy link
Contributor Author

huangmingxia commented Dec 17, 2025

/test okd-scos-images

2 similar comments
@huangmingxia
Copy link
Contributor Author

huangmingxia commented Dec 18, 2025

/test okd-scos-images

@huangmingxia
Copy link
Contributor Author

huangmingxia commented Dec 18, 2025

/test okd-scos-images

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 18, 2025

@huangmingxia: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@huangmingxia
Copy link
Contributor Author

huangmingxia commented Dec 18, 2025

Hi @jstuever I’ve updated the commit info. Could you please help review it again when you have time? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@2uasimojo 2uasimojo Awaiting requested review from 2uasimojo

@suhanime suhanime Awaiting requested review from suhanime

@jstuever jstuever Awaiting requested review from jstuever

Assignees

No one assigned

Labels

jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@huangmingxia @openshift-ci-robot @jstuever