-
Notifications
You must be signed in to change notification settings - Fork 159
[OCPERT-210] Add OpenShift Tests Extension (OTE) integration by using the automated migration OTE tool #954
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…d migration OTE tool
|
Need more test |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #954 +/- ##
==========================================
- Coverage 46.47% 46.33% -0.14%
==========================================
Files 98 99 +1
Lines 12184 12220 +36
==========================================
Hits 5662 5662
- Misses 5872 5908 +36
Partials 650 650
🚀 New features to boost your workflow:
|
|
@ming1013 Thanks! |
| @@ -0,0 +1,20 @@ | |||
| # Include bindata targets | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this Makefile should not be here, for multi-modules strategy solution, test extension resources should be compiled via root Makefile
| ) | ||
|
|
||
| // Exclude the external cloud-credential-operator module to avoid conflicts with local code | ||
| exclude github.com/openshift/cloud-credential-operator v0.0.0-20251125050939-3fd434e647db |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this file only contains test dependencies. it won't be conflict with operator product code
|
Same concern like router operator, required changes (test-ext compress and cp) in root Makefile is missed. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ming1013 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@ming1013: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Tested by:
$ ./cmd/extension/cloud-credential-operator-tests-ext list | grep -F '"name": "[sig-' |wc -l
16
Part of automated migration OTE tool log:
What Was Created
Test Files Migrated
Build Verification
✅ Extension binary builds successfully
✅ Binary executes and shows help
✅ Suite registered: openshift/cloud-credential-operator/tests
The tests will be discovered and run when the extension is used within the OpenShift testing
infrastructure.
Directory structure:
/home/minl/cloud-credential-operator/ # Target repository root
├── cmd/
│ └── extension/
│ └── main.go # OTE extension binary
├── test/
│ ├── e2e/ # Test files
│ │ ├── go.mod # Test module (separate from root)
│ │ ├── go.sum
│ │ └── *.go # Test files
│ ├── testdata/ # Testdata files
│ │ ├── bindata.go # Generated
│ │ ├── fixtures.go # Wrapper functions
│ │ └── credentials_request.yaml # Test data
│ ├── Makefile # Test build targets
│ └── bindata.mk # Bindata generation
├── go.mod # Root module (updated with OTE + replace directive)
└── Makefile # Root Makefile (extension target added)