Skip to content

Conversation

@ming1013
Copy link

Tested by:

$ ./cmd/extension/cloud-credential-operator-tests-ext list | grep -F '"name": "[sig-' |wc -l
16

Part of automated migration OTE tool log:

What Was Created

  1. Extension Binary: cmd/extension/main.go - Successfully builds to a 315MB binary
  2. Test Module: test/e2e/go.mod - Separate module with OTE dependencies
  3. Testdata Infrastructure: test/testdata/fixtures.go - Wrapper for accessing test fixtures
  4. Build System: Updated Makefiles with tests-ext-build target
  5. Module Configuration: Root and test go.mod files properly configured with replace directives

Test Files Migrated

  • 4 test files copied from openshift-tests-private
  • 1 testdata file (credentials_request.yaml)
  • All FixturePath calls automatically updated
  • Imports automatically cleaned up

Build Verification

✅ Extension binary builds successfully
✅ Binary executes and shows help
✅ Suite registered: openshift/cloud-credential-operator/tests

The tests will be discovered and run when the extension is used within the OpenShift testing
infrastructure.

Directory structure:

/home/minl/cloud-credential-operator/ # Target repository root
├── cmd/
│ └── extension/
│ └── main.go # OTE extension binary
├── test/
│ ├── e2e/ # Test files
│ │ ├── go.mod # Test module (separate from root)
│ │ ├── go.sum
│ │ └── *.go # Test files
│ ├── testdata/ # Testdata files
│ │ ├── bindata.go # Generated
│ │ ├── fixtures.go # Wrapper functions
│ │ └── credentials_request.yaml # Test data
│ ├── Makefile # Test build targets
│ └── bindata.mk # Bindata generation
├── go.mod # Root module (updated with OTE + replace directive)
└── Makefile # Root Makefile (extension target added)

@ming1013
Copy link
Author

Need more test
/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 15, 2025
@openshift-ci openshift-ci bot requested review from 2uasimojo and dlom December 15, 2025 09:24
@ming1013
Copy link
Author

ming1013 commented Dec 15, 2025

@codecov
Copy link

codecov bot commented Dec 15, 2025

Codecov Report

❌ Patch coverage is 0% with 36 lines in your changes missing coverage. Please review.
✅ Project coverage is 46.33%. Comparing base (3fd434e) to head (9bdcb8c).

Files with missing lines Patch % Lines
cmd/extension/main.go 0.00% 36 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #954      +/-   ##
==========================================
- Coverage   46.47%   46.33%   -0.14%     
==========================================
  Files          98       99       +1     
  Lines       12184    12220      +36     
==========================================
  Hits         5662     5662              
- Misses       5872     5908      +36     
  Partials      650      650              
Files with missing lines Coverage Δ
cmd/extension/main.go 0.00% <0.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@huangmingxia
Copy link
Contributor

@ming1013 Thanks!
As discussed, I will submit the create separate Go module change as a separate PR. After the create separate Go module PR is merged, we can re-run the tool and update this PR accordingly.

@ming1013 ming1013 changed the title Add OpenShift Tests Extension (OTE) integration by using the automated migration OTE tool [OCPERT-210] Add OpenShift Tests Extension (OTE) integration by using the automated migration OTE tool Dec 15, 2025
@@ -0,0 +1,20 @@
# Include bindata targets
Copy link

@rioliu-rh rioliu-rh Dec 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this Makefile should not be here, for multi-modules strategy solution, test extension resources should be compiled via root Makefile

)

// Exclude the external cloud-credential-operator module to avoid conflicts with local code
exclude github.com/openshift/cloud-credential-operator v0.0.0-20251125050939-3fd434e647db

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this file only contains test dependencies. it won't be conflict with operator product code

@rioliu-rh
Copy link

Same concern like router operator, required changes (test-ext compress and cp) in root Makefile is missed.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 15, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ming1013
Once this PR has been reviewed and has the lgtm label, please assign suhanime for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 15, 2025

@ming1013: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/security 9bdcb8c link true /test security
ci/prow/verify-deps 9bdcb8c link true /test verify-deps
ci/prow/verify 9bdcb8c link true /test verify

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants