Update openshift/release branch references from master to main#4931
Update openshift/release branch references from master to main#4931deepsm007 wants to merge 1 commit intoopenshift:mainfrom
Conversation
|
Pipeline controller notification For optional jobs, comment This repository is configured in: automatic mode |
|
/lgtm |
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
WalkthroughBranch references and related URLs were changed from "master" to "main" across documentation, tests, and a few source files; one generator now sorts URL lists for deterministic job name generation. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes ✨ Finishing touches🧪 Generate unit tests (beta)
Tip Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord. Comment |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deepsm007, hector-vido The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
cmd/promoted-image-governor/README.md (1)
41-45:⚠️ Potential issue | 🟡 MinorUpdate the remaining master link to main.
Line 44 still points to/blob/master, which is inconsistent with the branch rename and likely stale.Proposed fix
-The pre-submit job [pull-ci-openshift-release-openshift-image-mirror-mappings](https://prow.ci.openshift.org/?job=pull-ci-openshift-release-openshift-image-mirror-mappings) ([definition](https://github.com/openshift/release/blob/master/ci-operator/jobs/openshift/release/openshift-release-master-presubmits.yaml)) +The pre-submit job [pull-ci-openshift-release-openshift-image-mirror-mappings](https://prow.ci.openshift.org/?job=pull-ci-openshift-release-openshift-image-mirror-mappings) ([definition](https://github.com/openshift/release/blob/main/ci-operator/jobs/openshift/release/openshift-release-master-presubmits.yaml))
0d6746c to
355579c
Compare
|
New changes are detected. LGTM label has been removed. |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@pkg/controller/prpqr_reconciler/prpqr_reconciler_test.go`:
- Around line 90-92: The test's sentinel "missing" job name no longer matches
the job Branch set to "main" in the v1.ReleaseJobSpec
(CIOperatorMetadata.Branch), so the fake dispatcher will not exercise the "not
found" path; update the sentinel name in the fake dispatcher to use "main"
(e.g., change periodic-ci-openshift-release-master-missing to
periodic-ci-openshift-release-main-missing) or, better, derive the sentinel job
name from the test's Jobs[...].CIOperatorMetadata (Org/Repo/Branch) so the fake
dispatcher and the test spec stay in sync; update the code in the fake
dispatcher setup where the sentinel/missing job name is registered to use the
Branch from the test spec.
355579c to
c12cd0e
Compare
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
cmd/multi-pr-prow-plugin/server_test.go (1)
329-338:⚠️ Potential issue | 🟡 MinorInconsistent branch reference for
openshift/releasein test data.The fake PR at line 335 uses
Ref: "master"foropenshift/release#876, but the config resolver at line 339 has an entry withBranch: "main"for the same repository. This inconsistency suggests an incomplete rename and could cause confusion in test maintenance. Update line 335 to also use"main"for consistency with the config setup.Proposed fix
"openshift/release#876": { Base: github.PullRequestBranch{ Repo: github.Repo{ Owner: github.User{Login: "openshift"}, Name: "release", }, - Ref: "master", + Ref: "main", }, Number: 876, },
🧹 Nitpick comments (1)
cmd/testgrid-config-generator/README.md (1)
57-57: LGTM! Branch reference correctly updated.The URL successfully points to the main branch, aligning with the repository-wide branch rename.
Optional cleanup: The static analysis tool correctly flags that this reference definition
[release-controller-config]is unused in the document. Line 3 references[release-controller](defined on line 58) instead. Consider either using this reference or removing the definition for cleaner documentation.
c12cd0e to
1f45aa5
Compare
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
cmd/multi-pr-prow-plugin/server_test.go (1)
399-652:⚠️ Potential issue | 🟠 MajorUpdate expected
Branchvalues frommastertomainthroughout test cases.The
jobMetadataFromRawCommandfunction extracts the branch directly from the command string at position 2 (line 307-319 of server.go). Since all test commands inTestDetermineJobRunsusemain(e.g.,/testwith openshift/ci-tools/main/unit), the expectedJobMetadata.Branchvalues should bemain, notmaster. Update all affected test cases accordingly.
|
/test e2e |
1f45aa5 to
349d7cf
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@cmd/promoted-image-governor/README.md`:
- Around line 32-33: The README contains a typo: replace the phrase "Genenerate
the mapping files" with "Generate the mapping files" so that the second bullet
reads correctly; update the README entry (the line containing "Genenerate the
mapping files") to fix the misspelling.
| - Read [the config file](https://github.com/openshift/release/blob/main/core-services/image-mirroring/openshift/_config.yaml) and [the release-controllers' config](https://github.com/openshift/release/tree/main/core-services/release-controller/_releases) | ||
| - Genenerate the mapping files |
There was a problem hiding this comment.
Fix typo: “Genenerate” → “Generate”.
Small doc typo in the mapping files section.
✏️ Proposed fix
-- Genenerate the mapping files
+- Generate the mapping files📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| - Read [the config file](https://github.com/openshift/release/blob/main/core-services/image-mirroring/openshift/_config.yaml) and [the release-controllers' config](https://github.com/openshift/release/tree/main/core-services/release-controller/_releases) | |
| - Genenerate the mapping files | |
| - Read [the config file](https://github.com/openshift/release/blob/main/core-services/image-mirroring/openshift/_config.yaml) and [the release-controllers' config](https://github.com/openshift/release/tree/main/core-services/release-controller/_releases) | |
| - Generate the mapping files |
🧰 Tools
🪛 LanguageTool
[grammar] ~32-~32: Ensure spelling is correct
Context: ...ml) and the release-controllers' config - Genenerate the mapping files ### Explain Looks f...
(QB_NEW_EN_ORTHOGRAPHY_ERROR_IDS_1)
🤖 Prompt for AI Agents
In `@cmd/promoted-image-governor/README.md` around lines 32 - 33, The README
contains a typo: replace the phrase "Genenerate the mapping files" with
"Generate the mapping files" so that the second bullet reads correctly; update
the README entry (the line containing "Genenerate the mapping files") to fix the
misspelling.
349d7cf to
8e0aaf8
Compare
8e0aaf8 to
65e772c
Compare
|
@deepsm007: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
/cc @hector-vido @openshift/test-platform