-
Notifications
You must be signed in to change notification settings - Fork 73
Docs updates based on AI / helpdesk #556
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: jupierce The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@jupierce: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
| **Working with ART** | ||
| - [The Technical Release Team](/docs/release-oversight/the-technical-release-team) | ||
| - [Payload Testing](/docs/release-oversight/payload-testing) | ||
| - [Improving CI Signal](/docs/release-oversight/improving-ci-signal) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably working with TRT
| * [Workflow](#workflow): A workflow is the highest level component of the step registry. It contains three chains: pre, test, post. | ||
| * [Step](#step): A step is the lowest level component in the test step registry. It describes an individual test step (like "install cluster" or "run e2e tests"). | ||
| * [Chain](#chain): A chain is a registry component that specifies multiple steps to be run in sequence. Any item of the chain can be either a step or another chain. | ||
| * [Workflow](#workflow): A workflow is the highest level component of the step registry. It defines a complete test scenario with three phases: pre (setup), test (main tests), and post (cleanup). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would stick with chains, not phases
| Here's the sequence of images that get created (called the "pipeline"): | ||
|
|
||
| * `pipeline:root`: imports or builds the `build_root` image (your build environment) | ||
| * `pipeline:src`: clones your repository's code into the `root` image | ||
| * `pipeline:bin`: runs your build commands (like `make build`) to create compiled artifacts | ||
| * `pipeline:test-bin`: optionally runs different commands to build test-specific artifacts |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I liked the explanation before better.
- Those are IST, not images
- FROM ... show the layering
| ### Q: "unable to import image" | ||
| **A:** The base image doesn't exist or isn't accessible. Verify: | ||
| - Image name and tag are correct | ||
| - Image exists in the specified namespace |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
image exists in QCI
| # Run rehearsals | ||
| make rehearse | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No such thing
| the producer repository and import it in the consumer repository. Generally, a central `ImageStream` is used for | ||
| continuous integration; a repository opts into using an integration stream with the `releases.integration` field in the | ||
| `ci-operator` configuration and opts into publishing to the stream with the `promotion` field. | ||
| ## End-to-End Testing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think a lot of the text (in this whole file) is swapped for examples. I would keep the text and add examples.
/hold
Generated with AI, requires careful team review.