Skip to content

Conversation

@jupierce
Copy link
Contributor

/hold
Generated with AI, requires careful team review.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 30, 2025
@openshift-ci openshift-ci bot requested review from Prucek and liangxia September 30, 2025 17:08
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 30, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jupierce
Once this PR has been reviewed and has the lgtm label, please assign danilo-gemoli for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 30, 2025

@jupierce: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/links e63b165 link true /test links

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Comment on lines +77 to +80
**Working with ART**
- [The Technical Release Team](/docs/release-oversight/the-technical-release-team)
- [Payload Testing](/docs/release-oversight/payload-testing)
- [Improving CI Signal](/docs/release-oversight/improving-ci-signal)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably working with TRT

* [Workflow](#workflow): A workflow is the highest level component of the step registry. It contains three chains: pre, test, post.
* [Step](#step): A step is the lowest level component in the test step registry. It describes an individual test step (like "install cluster" or "run e2e tests").
* [Chain](#chain): A chain is a registry component that specifies multiple steps to be run in sequence. Any item of the chain can be either a step or another chain.
* [Workflow](#workflow): A workflow is the highest level component of the step registry. It defines a complete test scenario with three phases: pre (setup), test (main tests), and post (cleanup).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would stick with chains, not phases

Comment on lines +153 to +158
Here's the sequence of images that get created (called the "pipeline"):

* `pipeline:root`: imports or builds the `build_root` image (your build environment)
* `pipeline:src`: clones your repository's code into the `root` image
* `pipeline:bin`: runs your build commands (like `make build`) to create compiled artifacts
* `pipeline:test-bin`: optionally runs different commands to build test-specific artifacts
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I liked the explanation before better.

  • Those are IST, not images
  • FROM ... show the layering

### Q: "unable to import image"
**A:** The base image doesn't exist or isn't accessible. Verify:
- Image name and tag are correct
- Image exists in the specified namespace
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image exists in QCI

Comment on lines +307 to +309
# Run rehearsals
make rehearse

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No such thing

the producer repository and import it in the consumer repository. Generally, a central `ImageStream` is used for
continuous integration; a repository opts into using an integration stream with the `releases.integration` field in the
`ci-operator` configuration and opts into publishing to the stream with the `promotion` field.
## End-to-End Testing
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think a lot of the text (in this whole file) is swapped for examples. I would keep the text and add examples.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants