Skip to content

[DNM] Initial attempt at using wait step to back out of failed servicing. #428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
rhjanders wants to merge 5 commits into
base: main
Choose a base branch
from
Open

[DNM] Initial attempt at using wait step to back out of failed servicing. #428

rhjanders wants to merge 5 commits into from

Conversation

@rhjanders
Copy link

@rhjanders rhjanders commented Aug 6, 2025

No description provided.

@rhjanders
Copy link
Author

rhjanders commented Aug 6, 2025

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 6, 2025
@openshift-ci openshift-ci bot requested review from honza and iurygregory August 6, 2025 06:51
@openshift-ci
Copy link

openshift-ci bot commented Aug 6, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rhjanders
Once this PR has been reviewed and has the lgtm label, please assign dtantsur for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rhjanders rhjanders force-pushed the servicing-backout branch 3 times, most recently from e0d237b to 8f97da3 Compare August 14, 2025 04:33
dtantsur
dtantsur reviewed Aug 14, 2025
View reviewed changes
internal/controller/metal3.io/baremetalhost_controller.go Outdated
info.log.Info("failed to recover from servicing error", "error", provResult.ErrorMessage)
return actionError{fmt.Errorf("failed to recover from servicing error: %s", provResult.ErrorMessage)}
}
if started {
Copy link
Member

@dtantsur dtantsur Aug 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should never be true really..

@rhjanders rhjanders force-pushed the servicing-backout branch 2 times, most recently from 07adfd2 to 4a86946 Compare August 21, 2025 08:09
@rhjanders
Initial attempt at using wait step to back out of failed servicing.
c40d0ad 
Generated-By: Claude Code Sonnet 4
Signed-off-by: Jacob Anders <janders@redhat.com>
@openshift-ci
Copy link

openshift-ci bot commented Sep 9, 2025

@rhjanders: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/vendor e757792 link true /test vendor
ci/prow/e2e-metal-ipi-ovn-dualstack e757792 link false /test e2e-metal-ipi-ovn-dualstack
ci/prow/okd-scos-e2e-aws-ovn e757792 link false /test okd-scos-e2e-aws-ovn
ci/prow/e2e-metal-ipi-serial-ipv4 e757792 link true /test e2e-metal-ipi-serial-ipv4

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-bot
Copy link

openshift-bot commented Dec 8, 2025

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 8, 2025
@openshift-bot
Copy link

openshift-bot commented Jan 8, 2026

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

@openshift-ci openshift-ci bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jan 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@honza honza Awaiting requested review from honza

@iurygregory iurygregory Awaiting requested review from iurygregory

1 more reviewer

@dtantsur dtantsur dtantsur left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rhjanders @openshift-bot @dtantsur