Skip to content

Boilerplate: Update to 1628663baae4b9c1b7c55ed302a3d9e99376d8c6#992

Open
AlexSmithGH wants to merge 1 commit into
openshift:masterfrom
AlexSmithGH:boilerplate-update--1628663baae4b9c1b7c55ed302a3d9e99376d8c6
Open

Boilerplate: Update to 1628663baae4b9c1b7c55ed302a3d9e99376d8c6#992
AlexSmithGH wants to merge 1 commit into
openshift:masterfrom
AlexSmithGH:boilerplate-update--1628663baae4b9c1b7c55ed302a3d9e99376d8c6

Conversation

@AlexSmithGH
Copy link
Copy Markdown
Contributor

@AlexSmithGH AlexSmithGH commented May 26, 2026

Conventions:

commit: 0fd7c667224a7d6987d3af367801d790d815e495
author: red-hat-konflux[bot]
chore(deps): update konflux references

commit: 5c9b1484a283341e2d9aca8300bf97cfc665ca69
author: red-hat-konflux[bot]
chore(deps): update registry.access.redhat.com/ubi8/ubi-minimal:latest docker digest to f0ed531 (#738)

commit: 203ecbf77405125ef1241944bf08eb1f342c609f
author: red-hat-konflux[bot]
chore(deps): update konflux references (#737)

commit: bed16abb324583e2d5196368f26adea310f738bd
author: Josh Branham
Update OWNERS_ALIASES

commit: dc60b38466460c3b128d21fd569a2a23ca885eef
author: George Adams
Add geowa4 to OWNERS approvers and srep-functional-team-aurora

What is being added?

Is this a fix for a bug? What's the bug? Is this a new feature? Please describe it. Is this just a small typo fix? That's fine too!

Checklist before requesting review

  • I have tested this locally
  • I have included unit tests
  • I have updated any corresponding documentation

Steps To Manually Test

Please provide us steps to reproduce the scenarios needed to test this. If an integration test is provided, let us know how to run it. If not, enumerate the steps to validate this does what it's supposed to.

  1. Start the operator
  2. Run the thing
  3. Observe X in the spec for the thing
  4. Clean up the thing

Ref OSD-0000

Summary by CodeRabbit

  • Chores
    • Updated container runtime base images to version 9.8 in both Docker configurations, incorporating the latest security patches and stability improvements.
    • Updated team ownership list for the Aurora functional team to reflect current team composition.

Conventions:
- openshift/golang-osd-operator: Update
---
openshift/boilerplate@c2342f1...1628663

commit: 0fd7c667224a7d6987d3af367801d790d815e495
author: red-hat-konflux[bot]
chore(deps): update konflux references

Signed-off-by: red-hat-konflux <126015336+red-hat-konflux[bot]@users.noreply.github.com>

commit: 5c9b1484a283341e2d9aca8300bf97cfc665ca69
author: red-hat-konflux[bot]
chore(deps): update registry.access.redhat.com/ubi8/ubi-minimal:latest docker digest to f0ed531 (openshift#738)

Signed-off-by: red-hat-konflux <126015336+red-hat-konflux[bot]@users.noreply.github.com>
Co-authored-by: red-hat-konflux[bot] <126015336+red-hat-konflux[bot]@users.noreply.github.com>

commit: 203ecbf77405125ef1241944bf08eb1f342c609f
author: red-hat-konflux[bot]
chore(deps): update konflux references (openshift#737)

Signed-off-by: red-hat-konflux <126015336+red-hat-konflux[bot]@users.noreply.github.com>
Co-authored-by: red-hat-konflux[bot] <126015336+red-hat-konflux[bot]@users.noreply.github.com>

commit: bed16abb324583e2d5196368f26adea310f738bd
author: Josh Branham
Update OWNERS_ALIASES

commit: dc60b38466460c3b128d21fd569a2a23ca885eef
author: George Adams
Add geowa4 to OWNERS approvers and srep-functional-team-aurora

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 26, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 6ee2040b-dcc1-46cf-af2a-793faa96d296

📥 Commits

Reviewing files that changed from the base of the PR and between 49cb8f4 and 7666e9e.

⛔ Files ignored due to path filters (2)
  • boilerplate/_data/last-boilerplate-commit is excluded by !boilerplate/**
  • boilerplate/openshift/golang-osd-operator/OWNERS_ALIASES is excluded by !boilerplate/**
📒 Files selected for processing (3)
  • OWNERS_ALIASES
  • build/Dockerfile
  • build/Dockerfile.olm-registry

Walkthrough

This PR updates team ownership in the srep-functional-team-aurora alias and bumps the UBI minimal base image version from 9.7 to 9.8 in both the main and OLM registry Dockerfiles, keeping builder stages and application logic unchanged.

Changes

Maintenance Updates

Layer / File(s) Summary
Team ownership update
OWNERS_ALIASES
The srep-functional-team-aurora alias is updated: geowa4 is added and luis-falcon is removed, with joshbranham remaining.
Docker base image version upgrades
build/Dockerfile, build/Dockerfile.olm-registry
Both Dockerfiles update their final stage base image from ubi-minimal:9.7-1778562320 to ubi-minimal:9.8-1779777572; builder stages and application binary copy operations remain unchanged.

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 10 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name Status Explanation Resolution
Test Structure And Quality ⚠️ Warning Test code lacks meaningful assertion messages (115 Expect calls, mostly without messages) and has 3 of 4 Eventually blocks missing timeout specifications, violating quality requirements #3 and #4. Add timeout parameters to all Eventually/Consistently calls (e.g., Eventually(..., 30*time.Second)) and include descriptive failure messages in assertions (e.g., Expect(err).NotTo(HaveOccurred(), "failed to create test pod"))
Description check ❓ Inconclusive The description provides commit history and changes from the upstream boilerplate update but lacks specific information about what is being added, with the required template sections left unfilled. Complete the template by explicitly describing what the boilerplate update adds (e.g., dependency updates, dockerfile changes) and clarify why the generic manual test steps don't apply to this automated boilerplate synchronization.
✅ Passed checks (10 passed)
Check name Status Explanation
Title check ✅ Passed The title references a boilerplate update to a specific commit hash, which directly corresponds to the PR's main objective of updating project boilerplate files and dependencies.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed Analyzed 203 Ginkgo test titles added in this PR. All test names use static, descriptive strings without dynamic content like pod names, timestamps, UUIDs, nodes, namespaces, or IP addresses.
Microshift Test Compatibility ✅ Passed PR contains only unit tests using Ginkgo with mocked clients and fake.NewClientBuilder(), not e2e tests that interact with an actual cluster.
Single Node Openshift (Sno) Test Compatibility ✅ Passed No new Ginkgo e2e tests are added in this PR; it only modifies OWNERS_ALIASES, Dockerfile base images, and boilerplate version metadata. SNO compatibility check not applicable.
Topology-Aware Scheduling Compatibility ✅ Passed PR updates boilerplate, OWNERS_ALIASES, and Dockerfile base images only. No deployment manifests or operators with topology-unaware scheduling constraints were added or modified.
Ote Binary Stdout Contract ✅ Passed main.go uses controller-runtime's zap logger, suite tests use Ginkgo v2's RunSpecs, and fmt usage limited to Sprintf—all stdout writes properly managed.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed PR contains no new Ginkgo e2e tests—only standard Go unit tests and configuration changes. The check does not apply.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci Bot requested review from luis-falcon and reedcort May 26, 2026 15:44
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 26, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AlexSmithGH

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 26, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 26, 2026

@AlexSmithGH: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 46.65%. Comparing base (49cb8f4) to head (7666e9e).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #992   +/-   ##
=======================================
  Coverage   46.65%   46.65%           
=======================================
  Files          46       46           
  Lines        7033     7033           
=======================================
  Hits         3281     3281           
  Misses       3414     3414           
  Partials      338      338           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@openshift-ci openshift-ci Bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 30, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 30, 2026

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants