feat: enable Perses monitoring UI plugin via COO#193
Conversation
|
❌ Generated Files Verification Failed One or more generated files in this PR are out of sync:
Please regenerate the files locally and commit the changes. |
tiraboschi
force-pushed
the
monitoring_ui_plugin
branch
from
da139b2 to
2545340
Compare
tiraboschi
force-pushed
the
monitoring_ui_plugin
branch
from
2545340 to
e2e5dd3
Compare
|
❌ Generated Files Verification Failed One or more generated files in this PR are out of sync:
Please regenerate the files locally and commit the changes. |
tiraboschi
force-pushed
the
monitoring_ui_plugin
branch
from
e2e5dd3 to
f5de59a
Compare
|
❌ Generated Files Verification Failed One or more generated files in this PR are out of sync:
Please regenerate the files locally and commit the changes. |
tiraboschi
force-pushed
the
monitoring_ui_plugin
branch
from
f5de59a to
c57775f
Compare
| │ │ ├── descheduler/ # KubeDescheduler | ||
| │ │ ├── node-health/ # NodeHealthCheck | ||
| │ │ ├── operators/ # Third-party operator CRs | ||
| │ │ ├── observability/ # PrometheusRules, PersesDashboard CRs |
There was a problem hiding this comment.
nit: At the moment you dont have any dashboards there. You dont have to update.
|
/lgtm |
tiraboschi
force-pushed
the
monitoring_ui_plugin
branch
from
c57775f to
e287e5e
Compare
|
❌ Generated Files Verification Failed One or more generated files in this PR are out of sync:
Please regenerate the files locally and commit the changes. |
|
/lgtm |
|
Looks like you need to run 'make update-crds' |
Add the 'monitoring' UIPlugin (Cluster Observability Operator) as an always-on asset so Perses dashboards are available in the OpenShift console without requiring ACM integration. The UIPlugin is a soft dependency: autopilot skips it silently when the uiplugins.observability.openshift.io CRD is absent (COO not installed). When ACM is present it manages the same UIPlugin with additional acm.* fields; SSA field managers don't conflict because autopilot only owns spec.monitoring.perses.enabled. The kubevirt-plugin UIPlugin (observability-operator) is removed: testing on a clean cluster confirmed it is not needed. A tombstone ensures it is deleted on clusters where it was previously deployed. RBAC updated to include delete verb for uiplugins. Signed-off-by: Simone Tiraboschi <stirabos@redhat.com>
tiraboschi
force-pushed
the
monitoring_ui_plugin
branch
from
e287e5e to
7366ba4
Compare
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tiraboschi The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
Bot
merged commit 8fa643a
into
openshift-virtualization:main
|
/cherry-pick release-4.22 |
|
@tiraboschi: only openshift-virtualization org members may request cherry picks. If you are already part of the org, make sure to change your membership to public. Otherwise you can still do the cherry-pick manually. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/cherry-pick release-4.22 |
|
@tiraboschi: new pull request created: #197 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
3 participants
Add the 'monitoring' UIPlugin (Cluster Observability Operator) as an always-on asset so Perses dashboards are available in the OpenShift console without requiring ACM integration.
The UIPlugin is a soft dependency: autopilot skips it silently when the uiplugins.observability.openshift.io CRD is absent (COO not installed). When ACM is present it manages the same UIPlugin with additional acm.* fields; SSA field managers don't conflict because autopilot only owns spec.monitoring.perses.enabled.