fix: skip CRD check for built-in Kubernetes API groups in crdNameFromGVK#191
Merged
tiraboschi merged 1 commit intoMay 25, 2026
Conversation
crdNameFromGVK was treating any apiVersion with a "/" as a CRD, so groups like apps, batch, and rbac.authorization.k8s.io would produce spurious CRD names (e.g. "deployments.apps") and cause assets to be skipped with "CRD not installed" errors. Fix uses the .k8s.io/.apiserver.k8s.io suffix to identify Kubernetes-owned groups, with an explicit allowlist for the legacy groups (apps, batch, policy, autoscaling) that predate that naming convention. Also guard IsManagedCRD against an empty crdName to avoid a false match if any asset has an empty RequiredCRD field. Co-Authored-By: Nir Dothan <nirdothan@users.noreply.github.com> Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Member
Author
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tiraboschi The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
nirdothan
approved these changes
May 25, 2026
|
@nirdothan: changing LGTM is restricted to collaborators DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
tiraboschi
merged commit a9f6209
into
openshift-virtualization:main
6 of 7 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a bug where built-in Kubernetes API groups (
apps,batch,rbac.authorization.k8s.io, etc.) were incorrectly treated as CRDs, causing assets using these APIs to be skipped with "CRD not installed" errors.Root cause
crdNameFromGVKinpkg/assets/registry.gotreated everyapiVersioncontaining/as a CRD. Soapps/v1produceddeployments.apps,rbac.authorization.k8s.io/v1producedclusterroles.rbac.authorization.k8s.io, etc.Fix
.k8s.io/.apiserver.k8s.iosuffix and return""(no CRD required).apps,batch,policy,autoscaling.IsManagedCRDagainst an emptycrdNameto avoid a false match if any asset has an emptyRequiredCRDfield.Test plan
TestCrdNameFromGVKadded covering core v1, all major.k8s.iogroups, legacy groups, and a representative set of real CRD groups (kubevirt, forklift, metallb, monitoring, openshift, medik8s).go test ./pkg/assets/...passes.Cherry-picked from #180 (authored by @nirdothan).